From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.44]) by mx.groups.io with SMTP id smtpd.web09.5161.1636117519761173534 for ; Fri, 05 Nov 2021 06:05:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7vvJPdPu; spf=pass (domain: arm.com, ip: 40.107.7.44, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CN93Bj3akDrkCfC9Rq6uU+QZ6ROHQscjzW6RrThjZt8=; b=7vvJPdPumjFUWhN0tdaOh36NHTy1G/0uv6smE5UK4pU0vN2zLC5ngx0k/GZtr53ROh0ov4Tj7PfUoPehGviOtgUqf/KbctbnwDI9aNp1q6r3FzsYork8Dlxf39mMZRzwOHqBhZCdB8Ok+VwzGgvfabYfUeSglaxC3d7yCKR9KQs= Received: from AM6PR10CA0014.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::27) by PR3PR08MB5721.eurprd08.prod.outlook.com (2603:10a6:102:84::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Fri, 5 Nov 2021 13:05:16 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::d8) by AM6PR10CA0014.outlook.office365.com (2603:10a6:209:89::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Fri, 5 Nov 2021 13:05:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Fri, 5 Nov 2021 13:05:16 +0000 Received: ("Tessian outbound e7ce0d853b63:v108"); Fri, 05 Nov 2021 13:05:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c8ba950b49f83db2 X-CR-MTA-TID: 64aa7808 Received: from ec75e7d37651.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 90FC052C-43EB-4C74-B2E2-91A64142F420.1; Fri, 05 Nov 2021 13:05:09 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec75e7d37651.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 Nov 2021 13:05:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdrVyd1c2fGfJhDTiBEVCvhI4ZNH1bR6xqQuOe0GTtRK4lX9E/yNSugORnFwDD/y8rSZEEgKXv/Y7ZU65/pXcb+zB7fWfgEa+GIc3dXx7+7AAmETht7R82hm8oyUOyI2uJzGcYQjpRHSG3sC0OWFH79o3KJ5zO0T43dgMfemJJsy/qj5bMLKMkiTNeDUq2rSB5NsZXKEXA0XpzYxt5urV3fCypWSoj+4OOt1H2mE90R9w7GDqD4Yh6q8kGrmUX2bw1HYpaVzQaxliv1DBRc6ly1OpgZHqO3irYsZYSldWmzut3jCSLiCIVv8yTgPplaG5hn+6FEwoIvQKIbCjuMDDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CN93Bj3akDrkCfC9Rq6uU+QZ6ROHQscjzW6RrThjZt8=; b=hu34A8N5aVoj0NNwJgzF56vpae4dgILX8A1L+f0sdqhWfREjyjNisiHIaJVrbdfK5QDWuEOveoNriYDZGSPtSMzCz/9KpSgDWBRHkH68G6bWrA6BU2zxOWRP3XlZSv/Y9zc7CB7fUfokMfu2JdO+mcxAGnqXiil2BiI6Ar0Cic3dnWKDxRCWmpz6+OvcEiLcK4oYdzlr4tAFZFImBR8tISkiFAZDKN4qn5nNlXtbUKj+1TIxPNalebgZlm+Qea3QpweU9euaoX37i61XWvhF4/9iB4wcbfQt388Rt1mu91wlmnBjARoD53ZL8uSNTm/IqN6NVKoI3PQrFbjS+4CziQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CN93Bj3akDrkCfC9Rq6uU+QZ6ROHQscjzW6RrThjZt8=; b=7vvJPdPumjFUWhN0tdaOh36NHTy1G/0uv6smE5UK4pU0vN2zLC5ngx0k/GZtr53ROh0ov4Tj7PfUoPehGviOtgUqf/KbctbnwDI9aNp1q6r3FzsYork8Dlxf39mMZRzwOHqBhZCdB8Ok+VwzGgvfabYfUeSglaxC3d7yCKR9KQs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB5895.eurprd08.prod.outlook.com (2603:10a6:20b:298::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Fri, 5 Nov 2021 13:05:07 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4669.010; Fri, 5 Nov 2021 13:05:07 +0000 Subject: Re: [edk2-devel] [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations To: devel@edk2.groups.io, khasim.mohammed@arm.com Cc: nd@arm.com, Deepak Pandey References: <20211026173959.15742-1-khasim.mohammed@arm.com> <20211026173959.15742-4-khasim.mohammed@arm.com> From: "Sami Mujawar" Message-ID: <148a9230-04b2-21a8-7a8c-8fcb35241d6d@arm.com> Date: Fri, 5 Nov 2021 13:05:13 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211026173959.15742-4-khasim.mohammed@arm.com> X-ClientProxiedBy: LO2P265CA0112.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::28) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0112.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Fri, 5 Nov 2021 13:05:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 270896a0-6568-4a44-0f28-08d9a05ce952 X-MS-TrafficTypeDiagnostic: AS8PR08MB5895:|PR3PR08MB5721: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3276;OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 31sYIDGnI1gnGVHx0TgHnW1SbF7uoMj9CNM/fhnTj/SYptDiYW1u7VVPyJcYp9chaWgJa/Xt9C0eSxpo/TyS9wiCXNdVBW8ZMBORfzbvtFPvPKlpRiRc2/HiF+QX9i+b6Wt0ugUVYpN+5TDPxGG5bDusS06+y/EBl6xnmLy1iNCAEWOzq5u3/78fADFfI4ul4+Hm0sRFF3CnCKzOE0d1RzkRbFaJAnYxr3sZIud9QYLZQR1yifk6gCJJTevRPDB9yq2M3fjk681XDRieTu0VaJTG6C+uf8ZtUwfhT8K3uXx1G84Crf+kQS1slNfMh7njTrrd3UkIjoq5vZeiVr8+p0zdfSj8BKFeZ0LzqRZfyCW3HQPMiCpnPFzokSK06uDhm1qWBs6VpIyiWNhWESL+6WjgOSahTNPSodV17I2BGfNWGoJJQwIOLkSaCxH1R6vXS2MC6OvtJBpou39hGFE/WzCONURb8Gf5QlBNq4CK4BaI6rbBuVtxtb+7A8rsbFtSvZVBWKGq11kZ8SJmuS8IksYaP18oHjckwGPjaVvmIL3eJqeWevKnam2lSHsVhV8MW6ln2XmFOYO4pxptQTR1chwM8Dcw3OV7nTzHzpO3px5pZYh3ALfFUaVWGOfYOckYLKbzIM7ydNgNySKaE39iy+63c8tKVPxVh0i7YAvoTaT9KhZRSNOYU4S8pDiXsJ73oK5bhTIcLv3aQ/MItrqa1Z+yeMPVjYiEDAgyILJB7PtYwgWPSQqsVmJgKE41l4Xi4Yx2gxH/vWFzQyFWOAavaXTMgyGwFXlXYl+JBcYxAW4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(30864003)(19627235002)(38100700002)(66556008)(36756003)(66476007)(2616005)(31696002)(5660300002)(52116002)(2906002)(44832011)(8936002)(86362001)(956004)(508600001)(6636002)(53546011)(16576012)(26005)(83380400001)(8676002)(4326008)(186003)(66946007)(31686004)(6666004)(38350700002)(316002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5895 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9fdf7aaf-c01c-4e07-c930-08d9a05ce433 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JjUFAXXnVu/o1KBsCdeGFjxLt/7TFYaG6epnj74mA3L00hjCE/oYVMjOSK8yEZf2jM4C4u0Wrk73VZtIfDHZez1YfDzbUG6GZoACVAsfuFxzJfyRu9Z4omegXv5QBot1v2itrWuGZat3fHfUD4UqnOZkcqyU9RMjfwSG5j0O351YzCi4TKE56kpCaOtr8sFWWMA6XInPGk6ZZX7pM1ugIYVX1TaSgWt6JjSuN6ZDrhn7UIKu1QkkjdBFzaYVZ03aLUz20QLvPP0D0jznjz0M3olzyXwZ++cuEVgClkQdXq1+USHjONtpFtpXm9n6o/w2PQYR5bTIY11TNmsrDRJiwsfB4HRYrWn8GKv0MEA3jYZ0PRNVH9rpcXUeWNEBg73yLeZCU/LKlNiqgeLW19teY75EOlla5IzNmxFOpE/IizKwBxiIQQWJ8bLEA8Zs0FKU7xCi5vUjGD8G4LyN6ZGe4GBkH3vYNPvY8e80VcEw/OzrwgzyyU7k+QjyHYqxfUwPXW97tAi184xj3TIIvScQZol4eKfhB1Pu9o8ofV04IzZZ0zF/0NasvUYlGY/hKPfIDT0wgQMD+KbVDIjlA0b9JLb0pKA6DXl/ViMeUgrhH6QCTdiO1NFa029k+VOIaPOd0g8fKnxkSH/jt1iuj8w6BcQLBI7/wq6nTb3K18hJjh2us9+Xkp0C/D5fdOwXwEiCnsk8jRAXmKZ8zzFdN0fvSf56/MKP8voZNwEJZHpwfTY2p4VpktRaEcHfiiq8MnQwl9ZuGR3vDKF6BWadZh+1kw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(8936002)(70206006)(186003)(31686004)(336012)(2906002)(2616005)(83380400001)(70586007)(6636002)(5660300002)(956004)(81166007)(30864003)(356005)(4326008)(82310400003)(36860700001)(31696002)(508600001)(19627235002)(6666004)(47076005)(44832011)(53546011)(6486002)(26005)(36756003)(86362001)(16576012)(316002)(32563001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 13:05:16.0840 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 270896a0-6568-4a44-0f28-08d9a05ce952 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5721 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Khasim, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 26/10/2021 06:39 PM, Khasim Mohammed via groups.io wrote: > This patch adds PCDs and updates the fdf file for N1Sdp > platform specific configurations. > > Signed-off-by: Deepak Pandey > Signed-off-by: Khasim Syed Mohammed > --- > Platform/ARM/N1Sdp/N1SdpPlatform.dec | 98 ++++++++++++++++++++++++++++ > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 37 ++++++++++- > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 13 +++- > 3 files changed, 144 insertions(+), 4 deletions(-) > create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dec > > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dec b/Platform/ARM/N1Sdp/N1SdpPlatform.dec > new file mode 100644 > index 0000000000..d56891b985 > --- /dev/null > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dec > @@ -0,0 +1,98 @@ > +## @file > +# Describes the N1Sdp configuration. > +# > +# Copyright (c) 2021, ARM Limited. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x0001001A > + PACKAGE_NAME = N1SdpPlatform > + PACKAGE_GUID = 29aacb23-61e8-4fe2-8a06-793537cd26e9 > + PACKAGE_VERSION = 0.1 > + > +################################################################################ > +# > +# Include Section - list of Include Paths that are provided by this package. > +# Comments are used for Keywords and Module Types. > +# > +# Supported Module Types: > +# BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION > +# > +################################################################################ > +[Includes.common] > + > +[LibraryClasses] > + ArmPlatformLib|Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.inf > + > +[Guids.common] > + gArmN1SdpTokenSpaceGuid = { 0xd8f1624a, 0x98c1, 0x4f64, { 0xa6, 0x41, 0x19, 0x5e, 0xb5, 0x3b, 0x26, 0x0f } } > + > +[PcdsFixedAtBuild] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskBase|0x88000000|UINT32|0x00000001 > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSize|0x18000000|UINT32|0x00000002 > + > + # PCIe > + gArmN1SdpTokenSpaceGuid.PcdPcieExpressBaseAddress|0x70000000|UINT32|0x00000007 > + > + # External memory > + gArmNeoverseN1SocTokenSpaceGuid.PcdExtMemorySpace|0|UINT64|0x00000029 > + > +[PcdsFeatureFlag.common] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSupported|FALSE|BOOLEAN|0x00000003 > + > +[PcdsFixedAtBuild.common] > + # CoreSight Debug and Trace components > + # CoreSight ETMs > + gArmN1SdpTokenSpaceGuid.PcdCsEtm0Base|0x402040000|UINT64|0x0000002D > + gArmN1SdpTokenSpaceGuid.PcdCsEtm0MaxBase|0x402040FFF|UINT64|0x0000002E > + gArmN1SdpTokenSpaceGuid.PcdCsEtm1Base|0x402140000|UINT64|0x0000002F > + gArmN1SdpTokenSpaceGuid.PcdCsEtm1MaxBase|0x402140FFF|UINT64|0x00000030 > + gArmN1SdpTokenSpaceGuid.PcdCsEtm2Base|0x403040000|UINT64|0x00000031 > + gArmN1SdpTokenSpaceGuid.PcdCsEtm2MaxBase|0x403040FFF|UINT64|0x00000032 > + gArmN1SdpTokenSpaceGuid.PcdCsEtm3Base|0x403140000|UINT64|0x00000033 > + gArmN1SdpTokenSpaceGuid.PcdCsEtm3MaxBase|0x403140FFF|UINT64|0x00000034 > + > + # CoreSight TMC (ETRs/ETFs/ETBs) > + gArmN1SdpTokenSpaceGuid.PcdCsEtf0Base|0x400410000|UINT64|0x00000035 > + gArmN1SdpTokenSpaceGuid.PcdCsEtf0MaxBase|0x400410FFF|UINT64|0x00000036 > + gArmN1SdpTokenSpaceGuid.PcdCsEtf1Base|0x400420000|UINT64|0x00000037 > + gArmN1SdpTokenSpaceGuid.PcdCsEtf1MaxBase|0x400420FFF|UINT64|0x00000038 > + gArmN1SdpTokenSpaceGuid.PcdCsEtf2Base|0x400010000|UINT64|0x00000039 > + gArmN1SdpTokenSpaceGuid.PcdCsEtf2MaxBase|0x400010FFF|UINT64|0x0000003A > + gArmN1SdpTokenSpaceGuid.PcdCsEtrBase|0x400120000|UINT64|0x00000043 > + gArmN1SdpTokenSpaceGuid.PcdCsEtrMaxBase|0x400120FFF|UINT64|0x00000044 > + > + # CoreSight Dynamic Funnel(s) > + gArmN1SdpTokenSpaceGuid.PcdCsFunnel0Base|0x4000B0000|UINT64|0x0000003B > + gArmN1SdpTokenSpaceGuid.PcdCsFunnel0MaxBase|0x4000B0FFF|UINT64|0x0000003C > + gArmN1SdpTokenSpaceGuid.PcdCsFunnel1Base|0x4000A0000|UINT64|0x0000003D > + gArmN1SdpTokenSpaceGuid.PcdCsFunnel1MaxBase|0x4000A0FFF|UINT64|0x0000003E > + > + # CoreSight Dynamic Replicator(s) > + gArmN1SdpTokenSpaceGuid.PcdCsReplicatorBase|0x400110000|UINT64|0x0000003F > + gArmN1SdpTokenSpaceGuid.PcdCsReplicatorMaxBase|0x400110FFF|UINT64|0x00000040 > + > + # CoreSight TPIU > + gArmN1SdpTokenSpaceGuid.PcdCsTpiuBase|0x400130000|UINT64|0x00000041 > + gArmN1SdpTokenSpaceGuid.PcdCsTpiuMaxBase|0x400130FFF|UINT64|0x00000042 > + > + # CoreSight STM and STM Stimulus > + gArmN1SdpTokenSpaceGuid.PcdCsStmBase|0x400800000|UINT64|0x00000045 > + gArmN1SdpTokenSpaceGuid.PcdCsStmMaxBase|0x400800FFF|UINT64|0x00000046 > + gArmN1SdpTokenSpaceGuid.PcdCsStmStimulusBase|0x4D000000|UINT32|0x00000047 > + gArmN1SdpTokenSpaceGuid.PcdCsStmStimulusSize|0x1000000|UINT32|0x00000048 > + > + # CoreSight Components' Size > + # > + # Newton TRMs specify the size for these coresight components as 64K. > + # The actual size is just 4K though 64K is reserved. Access to the > + # unmapped reserved region results in a DECERR response. > + # > + gArmN1SdpTokenSpaceGuid.PcdCsComponentSize|0x1000|UINT32|0x00000049 > + > + # Remote Chip PCIe > + gArmN1SdpTokenSpaceGuid.PcdRemotePcieIoTranslation|0x40075200000|UINT64|0x0000004A > + gArmN1SdpTokenSpaceGuid.PcdRemotePcieMmio32Translation|0x40000000000|UINT64|0x0000004B > + gArmN1SdpTokenSpaceGuid.PcdRemotePcieMmio64Translation|0x40000000000|UINT64|0x0000004C > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > index 61e7a909f8..0bc3fa6dfe 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > @@ -1,8 +1,18 @@ > +## @file > +# Component Description File for N1Sdp > # > -# Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. > +# This provides platform specific component descriptions and libraries that > +# conform to EFI/Framework standards. > # > -# SPDX-License-Identifier: BSD-2-Clause-Patent > +# Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.
> # > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > +# IMPLIED. > +# [SAMI] Is the above disclaimer required? Is the "SPDX-License-Identifier: BSD-2-Clause-Patent" not sufficient? I think I noticed something similar in another patch. Can you check, please? [/SAMI] > +## > > ################################################################################ > # > @@ -33,6 +43,9 @@ > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > + # file explorer library support > + FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > + > [LibraryClasses.common.SEC] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > @@ -71,6 +84,9 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > +!if $(TARGET) != RELEASE > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > +!endif > > [LibraryClasses.common.UEFI_DRIVER, LibraryClasses.common.UEFI_APPLICATION, LibraryClasses.common.DXE_RUNTIME_DRIVER, LibraryClasses.common.DXE_DRIVER] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > @@ -82,11 +98,16 @@ > ################################################################################ > > [PcdsFeatureFlag.common] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSupported|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE > > [PcdsFixedAtBuild.common] > gArmTokenSpaceGuid.PcdVFPEnabled|1 > > + # RAM Disk > + gArmN1SdpTokenSpaceGuid.PcdRamDiskBase|0x88000000 > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSize|0x18000000 > + > # Stacks for MPCores in Normal World > gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x80000000 > gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x40000 > @@ -99,6 +120,9 @@ > # Secondary DDR memory > gArmNeoverseN1SocTokenSpaceGuid.PcdDramBlock2Base|0x8080000000 > > + # External memory > + gArmNeoverseN1SocTokenSpaceGuid.PcdExtMemorySpace|0x40000000000 > + > # GIC Base Addresses > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C000000 > gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000 > @@ -198,6 +222,9 @@ > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > > + # Platform driver > + Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > + > # Human Interface Support > MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > @@ -236,6 +263,9 @@ > # SATA Controller > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > > + # NVMe boot devices > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > # Usb Support > MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf > MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > @@ -244,3 +274,6 @@ > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf > + > + # RAM Disk > + MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > index c4e1f7b4b8..6b097438ad 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > @@ -1,8 +1,10 @@ > +## @file > +# FDF file of N1Sdp > # > -# Copyright (c) 2018 - 2020, ARM Limited. All rights reserved. > +# Copyright (c) 2018 - 2021, ARM Limited. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > -# > +## > > ################################################################################ > # > @@ -109,6 +111,9 @@ READ_LOCK_STATUS = TRUE > # SATA Controller > INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > > + # NVMe boot devices > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + > # Usb Support > INF MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf > INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > @@ -137,10 +142,14 @@ READ_LOCK_STATUS = TRUE > > # FV FileSystem > INF MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf > + INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > # UEFI applications > INF ShellPkg/Application/Shell/Shell.inf > > + # Platform driver > + INF Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > + > # Bds > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf