[Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called
@ 2017-03-21  3:43 Jiaxin Wu
  2017-03-21  3:43 ` [Patch 1/2] MdeModulePkg/Network: " Jiaxin Wu
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Jiaxin Wu @ 2017-03-21  3:43 UTC (permalink / raw)
  To: edk2-devel
  Cc: Hegde Nagaraj P, Subramanian Sriram, Zhang Lubo, Ye Ting,
	Fu Siyuan, Wu Jiaxin

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/Network: Fix potential ASSERT if NetIp4IsUnicast is called
  NetworkPkg: Fix potential ASSERT if NetIp4IsUnicast is called

 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c    | 9 ++++++---
 MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c   | 8 ++++----
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c       | 5 +++--
 MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c       | 4 ++--
 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +-
 NetworkPkg/DnsDxe/DnsProtocol.c                         | 4 ++--
 NetworkPkg/TcpDxe/TcpMain.c                             | 5 +++--
 NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c                     | 5 +++--
 8 files changed, 24 insertions(+), 18 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Patch 1/2] MdeModulePkg/Network: Fix potential ASSERT if NetIp4IsUnicast is called
  2017-03-21  3:43 [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called Jiaxin Wu
@ 2017-03-21  3:43 ` Jiaxin Wu
  2017-03-21  3:43 ` [Patch 2/2] NetworkPkg: " Jiaxin Wu
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Jiaxin Wu @ 2017-03-21  3:43 UTC (permalink / raw)
  To: edk2-devel
  Cc: Hegde Nagaraj P, Subramanian Sriram, Zhang Lubo, Ye Ting,
	Fu Siyuan, Wu Jiaxin

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c    | 9 ++++++---
 MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c   | 8 ++++----
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c       | 5 +++--
 MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c       | 4 ++--
 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +-
 5 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c
index 8eea887..c8dc697 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c
@@ -1,9 +1,9 @@
 /** @file
   Helper functions for configuring or getting the parameters relating to Ip4.
 
-Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -613,17 +613,20 @@ Ip4Config2ConvertIfrNvDataToConfigNvData (
       CreatePopUp (EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"Invalid Subnet Mask!", NULL);
       return EFI_INVALID_PARAMETER;
     }
 
     Status = Ip4Config2StrToIp (IfrFormNvData->StationAddress, &StationAddress.v4);
-    if (EFI_ERROR (Status) || !NetIp4IsUnicast (NTOHL (StationAddress.Addr[0]), NTOHL (SubnetMask.Addr[0]))) {
+    if (EFI_ERROR (Status) || 
+        (SubnetMask.Addr[0] != 0 && !NetIp4IsUnicast (NTOHL (StationAddress.Addr[0]), NTOHL (SubnetMask.Addr[0]))) || 
+        !Ip4StationAddressValid (NTOHL (StationAddress.Addr[0]), NTOHL (SubnetMask.Addr[0]))) {
       CreatePopUp (EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"Invalid IP address!", NULL);
       return EFI_INVALID_PARAMETER;
     }
     
     Status = Ip4Config2StrToIp (IfrFormNvData->GatewayAddress, &Gateway.v4);
-    if (EFI_ERROR (Status) || ((Gateway.Addr[0] != 0) && !NetIp4IsUnicast (NTOHL (Gateway.Addr[0]), NTOHL (SubnetMask.Addr[0])))) {
+    if (EFI_ERROR (Status) || 
+        (Gateway.Addr[0] != 0 && SubnetMask.Addr[0] != 0 && !NetIp4IsUnicast (NTOHL (Gateway.Addr[0]), NTOHL (SubnetMask.Addr[0])))) {
       CreatePopUp (EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, L"Invalid Gateway!", NULL);
       return EFI_INVALID_PARAMETER;
     }
 
     Status = Ip4Config2StrToIpList (IfrFormNvData->DnsAddress, &DnsAddress, &DnsCount);
diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
index a2583a4..5494231 100644
--- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
+++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c
@@ -206,11 +206,11 @@ Mtftp4OverrideValid (
     CopyMem (&Ip, &Config->StationIp, sizeof (IP4_ADDR));
 
     Netmask = NTOHL (Netmask);
     Ip      = NTOHL (Ip);
 
-    if (!NetIp4IsUnicast (Gateway, Netmask) || !IP4_NET_EQUAL (Gateway, Ip, Netmask)) {
+    if ((Netmask != 0 && !NetIp4IsUnicast (Gateway, Netmask)) || !IP4_NET_EQUAL (Gateway, Ip, Netmask)) {
       return FALSE;
     }
   }
 
   return TRUE;
@@ -666,17 +666,17 @@ EfiMtftp4Configure (
     Netmask  = NTOHL (Netmask);
     Gateway  = NTOHL (Gateway);
     ServerIp = NTOHL (ServerIp);
 
     if (!ConfigData->UseDefaultSetting &&
-       ((!IP4_IS_VALID_NETMASK (Netmask) || !NetIp4IsUnicast (Ip, Netmask)))) {
+        ((!IP4_IS_VALID_NETMASK (Netmask) || (Netmask != 0 && !NetIp4IsUnicast (Ip, Netmask))))) {
 
       return EFI_INVALID_PARAMETER;
     }
 
-    if ((Gateway != 0) &&
-        (!IP4_NET_EQUAL (Gateway, Ip, Netmask) || !NetIp4IsUnicast (Gateway, Netmask))) {
+    if ((Gateway != 0) && 
+        (!IP4_NET_EQUAL (Gateway, Ip, Netmask) || (Netmask != 0 && !NetIp4IsUnicast (Gateway, Netmask)))) {
 
       return EFI_INVALID_PARAMETER;
     }
 
     OldTpl = gBS->RaiseTPL (TPL_CALLBACK);
diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c
index 8e70e01..2679f1b 100644
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c
@@ -1,9 +1,9 @@
 /** @file
   Implementation of TCP4 protocol services.
 
-Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php<BR>
 
@@ -181,11 +181,12 @@ Tcp4Configure (
 
     if (!TcpConfigData->AccessPoint.UseDefaultAddress) {
 
       CopyMem (&Ip, &TcpConfigData->AccessPoint.StationAddress, sizeof (IP4_ADDR));
       CopyMem (&SubnetMask, &TcpConfigData->AccessPoint.SubnetMask, sizeof (IP4_ADDR));
-      if (!IP4_IS_VALID_NETMASK (NTOHL (SubnetMask)) || !NetIp4IsUnicast (NTOHL (Ip), NTOHL (SubnetMask))) {
+      if (!IP4_IS_VALID_NETMASK (NTOHL (SubnetMask)) || 
+          (SubnetMask != 0 && !NetIp4IsUnicast (NTOHL (Ip), NTOHL (SubnetMask)))) {
         return EFI_INVALID_PARAMETER;
       }
     }
 
     Option = TcpConfigData->ControlOption;
diff --git a/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c b/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c
index bdb79b3..d719883 100644
--- a/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c
+++ b/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c
@@ -1,9 +1,9 @@
 /** @file
 
 (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -170,11 +170,11 @@ Udp4Configure (
     RemoteAddress  = NTOHL (RemoteAddress);
 
 
     if (!UdpConfigData->UseDefaultAddress &&
         (!IP4_IS_VALID_NETMASK (SubnetMask) ||
-         !((StationAddress == 0) || NetIp4IsUnicast (StationAddress, SubnetMask)) ||
+         !((StationAddress == 0) || (SubnetMask != 0 && NetIp4IsUnicast (StationAddress, SubnetMask))) ||
          IP4_IS_LOCAL_BROADCAST (RemoteAddress))) {
       //
       // Don't use default address, and subnet mask is invalid or StationAddress is not
       // a valid unicast IPv4 address or RemoteAddress is not a valid unicast IPv4 address
       // if it is not 0.
diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c
index cd00f5c..259568e 100644
--- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c
+++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c
@@ -2319,11 +2319,11 @@ EfiPxeBcSetStationIP (
   }
 
   if (NewStationIp != NULL) {
     if (IP4_IS_UNSPECIFIED(NTOHL (NewStationIp->Addr[0])) || 
         IP4_IS_LOCAL_BROADCAST(NTOHL (NewStationIp->Addr[0])) ||
-        (NewSubnetMask != NULL && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0])))) {
+        (NewSubnetMask != NULL && NewSubnetMask->Addr[0] != 0 && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0])))) {
       return EFI_INVALID_PARAMETER;
     }
   }
   
   Private = PXEBC_PRIVATE_DATA_FROM_PXEBC (This);
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Patch 2/2] NetworkPkg: Fix potential ASSERT if NetIp4IsUnicast is called
  2017-03-21  3:43 [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called Jiaxin Wu
  2017-03-21  3:43 ` [Patch 1/2] MdeModulePkg/Network: " Jiaxin Wu
@ 2017-03-21  3:43 ` Jiaxin Wu
  2017-03-21  4:58 ` [Patch 0/2] " Hegde, Nagaraj P
  2017-03-21  7:25 ` Subramanian, Sriram
  3 siblings, 0 replies; 6+ messages in thread
From: Jiaxin Wu @ 2017-03-21  3:43 UTC (permalink / raw)
  To: edk2-devel
  Cc: Hegde Nagaraj P, Subramanian Sriram, Zhang Lubo, Ye Ting,
	Fu Siyuan, Wu Jiaxin

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/DnsDxe/DnsProtocol.c     | 4 ++--
 NetworkPkg/TcpDxe/TcpMain.c         | 5 +++--
 NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 5 +++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/NetworkPkg/DnsDxe/DnsProtocol.c b/NetworkPkg/DnsDxe/DnsProtocol.c
index 6d117b2..0e7ed34 100644
--- a/NetworkPkg/DnsDxe/DnsProtocol.c
+++ b/NetworkPkg/DnsDxe/DnsProtocol.c
@@ -1,9 +1,9 @@
 /** @file
 Implementation of EFI_DNS4_PROTOCOL and EFI_DNS6_PROTOCOL interfaces.
 
-Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -244,11 +244,11 @@ Dns4Configure (
 
     Ip       = NTOHL (Ip);
     Netmask  = NTOHL (Netmask);
 
     if (!DnsConfigData->UseDefaultSetting &&
-       ((!IP4_IS_VALID_NETMASK (Netmask) || !NetIp4IsUnicast (Ip, Netmask)))) {
+        ((!IP4_IS_VALID_NETMASK (Netmask) || (Netmask != 0 && !NetIp4IsUnicast (Ip, Netmask))))) {
       Status = EFI_INVALID_PARAMETER;
       goto ON_EXIT;
     }
 
     Status = Dns4CopyConfigure (&Instance->Dns4CfgData, DnsConfigData);
diff --git a/NetworkPkg/TcpDxe/TcpMain.c b/NetworkPkg/TcpDxe/TcpMain.c
index 03942ee..fc3713e 100644
--- a/NetworkPkg/TcpDxe/TcpMain.c
+++ b/NetworkPkg/TcpDxe/TcpMain.c
@@ -1,10 +1,10 @@
 /** @file
   Implementation of EFI_TCP4_PROTOCOL and EFI_TCP6_PROTOCOL.
 
   (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
-  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php.
@@ -157,11 +157,12 @@ Tcp4Configure (
 
     if (!TcpConfigData->AccessPoint.UseDefaultAddress) {
 
       CopyMem (&Ip, &TcpConfigData->AccessPoint.StationAddress, sizeof (IP4_ADDR));
       CopyMem (&SubnetMask, &TcpConfigData->AccessPoint.SubnetMask, sizeof (IP4_ADDR));
-      if (!IP4_IS_VALID_NETMASK (NTOHL (SubnetMask)) || !NetIp4IsUnicast (NTOHL (Ip), NTOHL (SubnetMask))) {
+      if (!IP4_IS_VALID_NETMASK (NTOHL (SubnetMask)) || 
+          (SubnetMask != 0 && !NetIp4IsUnicast (NTOHL (Ip), NTOHL (SubnetMask)))) {
         return EFI_INVALID_PARAMETER;
       }
     }
 
     Option = TcpConfigData->ControlOption;
diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
index 36477e9..ab9e494 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c
@@ -1083,11 +1083,12 @@ EfiPxeBcUdpWrite (
     DoNotFragment = FALSE;
   } else {
     DoNotFragment = TRUE;
   }
 
-  if (!Mode->UsingIpv6 && GatewayIp != NULL && !NetIp4IsUnicast (NTOHL (GatewayIp->Addr[0]), EFI_NTOHL(Mode->SubnetMask))) {
+  if (!Mode->UsingIpv6 && GatewayIp != NULL && Mode->SubnetMask.Addr[0] != 0 && 
+      !NetIp4IsUnicast (NTOHL (GatewayIp->Addr[0]), EFI_NTOHL(Mode->SubnetMask))) {
     //
     // Gateway is provided but it's not a unicast IPv4 address, while it will be ignored for IPv6.
     //
     return EFI_INVALID_PARAMETER;
   }
@@ -2014,11 +2015,11 @@ EfiPxeBcSetStationIP (
   }
 
   if (!Mode->UsingIpv6 && NewStationIp != NULL) {
     if (IP4_IS_UNSPECIFIED(NTOHL (NewStationIp->Addr[0])) || 
         IP4_IS_LOCAL_BROADCAST(NTOHL (NewStationIp->Addr[0])) ||
-        (NewSubnetMask != NULL && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0])))) {
+        (NewSubnetMask != NULL && NewSubnetMask->Addr[0] != 0 && !NetIp4IsUnicast (NTOHL (NewStationIp->Addr[0]), NTOHL (NewSubnetMask->Addr[0])))) {
       return EFI_INVALID_PARAMETER;
     }
   }
   
   if (!Mode->Started) {
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called
  2017-03-21  3:43 [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called Jiaxin Wu
  2017-03-21  3:43 ` [Patch 1/2] MdeModulePkg/Network: " Jiaxin Wu
  2017-03-21  3:43 ` [Patch 2/2] NetworkPkg: " Jiaxin Wu
@ 2017-03-21  4:58 ` Hegde, Nagaraj P
  2017-03-21  7:10   ` Ye, Ting
  2017-03-21  7:25 ` Subramanian, Sriram
  3 siblings, 1 reply; 6+ messages in thread
From: Hegde, Nagaraj P @ 2017-03-21  4:58 UTC (permalink / raw)
  To: Jiaxin Wu, edk2-devel@lists.01.org
  Cc: Subramanian, Sriram, Zhang Lubo, Ye Ting, Fu Siyuan

Series Reviewed-by: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>

-----Original Message-----
From: Jiaxin Wu [mailto:jiaxin.wu@intel.com] 
Sent: Tuesday, March 21, 2017 9:13 AM
To: edk2-devel@lists.01.org
Cc: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>; Subramanian, Sriram <sriram-s@hpe.com>; Zhang Lubo <lubo.zhang@intel.com>; Ye Ting <ting.ye@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/Network: Fix potential ASSERT if NetIp4IsUnicast is called
  NetworkPkg: Fix potential ASSERT if NetIp4IsUnicast is called

 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c    | 9 ++++++---
 MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c   | 8 ++++----
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c       | 5 +++--
 MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c       | 4 ++--
 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +-
 NetworkPkg/DnsDxe/DnsProtocol.c                         | 4 ++--
 NetworkPkg/TcpDxe/TcpMain.c                             | 5 +++--
 NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c                     | 5 +++--
 8 files changed, 24 insertions(+), 18 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called
  2017-03-21  4:58 ` [Patch 0/2] " Hegde, Nagaraj P
@ 2017-03-21  7:10   ` Ye, Ting
  0 siblings, 0 replies; 6+ messages in thread
From: Ye, Ting @ 2017-03-21  7:10 UTC (permalink / raw)
  To: Hegde, Nagaraj P, Wu, Jiaxin, edk2-devel@lists.01.org
  Cc: Zhang, Lubo, Fu, Siyuan

Series Reviewed-by: Ye Ting <ting.ye@intel.com> 

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hegde, Nagaraj P
Sent: Tuesday, March 21, 2017 12:59 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
Subject: Re: [edk2] [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called

Series Reviewed-by: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>

-----Original Message-----
From: Jiaxin Wu [mailto:jiaxin.wu@intel.com] 
Sent: Tuesday, March 21, 2017 9:13 AM
To: edk2-devel@lists.01.org
Cc: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>; Subramanian, Sriram <sriram-s@hpe.com>; Zhang Lubo <lubo.zhang@intel.com>; Ye Ting <ting.ye@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/Network: Fix potential ASSERT if NetIp4IsUnicast is called
  NetworkPkg: Fix potential ASSERT if NetIp4IsUnicast is called

 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c    | 9 ++++++---
 MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c   | 8 ++++----
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c       | 5 +++--
 MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c       | 4 ++--
 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +-
 NetworkPkg/DnsDxe/DnsProtocol.c                         | 4 ++--
 NetworkPkg/TcpDxe/TcpMain.c                             | 5 +++--
 NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c                     | 5 +++--
 8 files changed, 24 insertions(+), 18 deletions(-)

-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called
  2017-03-21  3:43 [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called Jiaxin Wu
                   ` (2 preceding siblings ...)
  2017-03-21  4:58 ` [Patch 0/2] " Hegde, Nagaraj P
@ 2017-03-21  7:25 ` Subramanian, Sriram
  3 siblings, 0 replies; 6+ messages in thread
From: Subramanian, Sriram @ 2017-03-21  7:25 UTC (permalink / raw)
  To: Jiaxin Wu, edk2-devel@lists.01.org
  Cc: Hegde, Nagaraj P, Zhang Lubo, Ye Ting, Fu Siyuan

Series Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>

-----Original Message-----
From: Jiaxin Wu [mailto:jiaxin.wu@intel.com] 
Sent: Tuesday, March 21, 2017 9:13 AM
To: edk2-devel@lists.01.org
Cc: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com>; Subramanian, Sriram <sriram-s@hpe.com>; Zhang Lubo <lubo.zhang@intel.com>; Ye Ting <ting.ye@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called

Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdeModulePkg/Network: Fix potential ASSERT if NetIp4IsUnicast is called
  NetworkPkg: Fix potential ASSERT if NetIp4IsUnicast is called

 MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Nv.c    | 9 ++++++---
 MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.c   | 8 ++++----
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c       | 5 +++--
 MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Main.c       | 4 ++--
 MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c | 2 +-
 NetworkPkg/DnsDxe/DnsProtocol.c                         | 4 ++--
 NetworkPkg/TcpDxe/TcpMain.c                             | 5 +++--
 NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c                     | 5 +++--
 8 files changed, 24 insertions(+), 18 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-03-21  7:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21  3:43 [Patch 0/2] Fix potential ASSERT if NetIp4IsUnicast is called Jiaxin Wu
2017-03-21  3:43 ` [Patch 1/2] MdeModulePkg/Network: " Jiaxin Wu
2017-03-21  3:43 ` [Patch 2/2] NetworkPkg: " Jiaxin Wu
2017-03-21  4:58 ` [Patch 0/2] " Hegde, Nagaraj P
2017-03-21  7:10   ` Ye, Ting
2017-03-21  7:25 ` Subramanian, Sriram

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox