[patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

[patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

[Dandan Bi]

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
index 93f96f0..a73c4cc 100644
--- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
+++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
@@ -382,11 +382,11 @@ FreeImageRecord (
   }
   FreePool (ImageRecord);
 }
 
 /**
-  Protect UEFI PE/COFF image
+  Protect UEFI PE/COFF image.
 
   @param[in]  LoadedImage              The loaded image protocol
   @param[in]  LoadedImageDevicePath    The loaded image device path protocol
 **/
 VOID
-- 
1.9.5.msysgit.1

[patch 2/2] ShellPkg/Shell: Make comments align with the function

[Dandan Bi]

Cc: Chen A Chen <chen.a.chen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 ShellPkg/Application/Shell/Shell.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index dfcbfb8..5a941aa 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -1134,12 +1134,12 @@ ProcessCommandLine(
 /**
   Function try to find location of the Startup.nsh file.
   
   The buffer is callee allocated and should be freed by the caller.
 
-  @param    ImagePath             The path to the image for shell.  first place to look for the startup script
-  @param    FilePath              The path to the file for shell.  second place to look for the startup script.
+  @param    ImageDevicePath       The path to the image for shell.  first place to look for the startup script
+  @param    FileDevicePath        The path to the file for shell.  second place to look for the startup script.
 
   @retval   NULL                  No Startup.nsh file was found.
   @return   !=NULL                Pointer to NULL-terminated path.
 **/
 CHAR16 *
-- 
1.9.5.msysgit.1

Re: [patch 2/2] ShellPkg/Shell: Make comments align with the function

[Ni, Ruiyu]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, March 28, 2017 9:02 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch 2/2] ShellPkg/Shell: Make comments align with the function
> 
> Cc: Chen A Chen <chen.a.chen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Application/Shell/Shell.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index dfcbfb8..5a941aa 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -1134,12 +1134,12 @@ ProcessCommandLine(
>  /**
>    Function try to find location of the Startup.nsh file.
> 
>    The buffer is callee allocated and should be freed by the caller.
> 
> -  @param    ImagePath             The path to the image for shell.  first place to
> look for the startup script
> -  @param    FilePath              The path to the file for shell.  second place to look
> for the startup script.
> +  @param    ImageDevicePath       The path to the image for shell.  first place
> to look for the startup script
> +  @param    FileDevicePath        The path to the file for shell.  second place to
> look for the startup script.
> 
>    @retval   NULL                  No Startup.nsh file was found.
>    @return   !=NULL                Pointer to NULL-terminated path.
>  **/
>  CHAR16 *
> --
> 1.9.5.msysgit.1

Re: [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

[Tian, Feng]

Reviewed-by: Feng Tian <feng.tian@intel.com>

Thanks
Feng

-----Original Message-----
From: Bi, Dandan 
Sent: Tuesday, March 28, 2017 9:02 AM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Tian, Feng <feng.tian@intel.com>
Subject: [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
index 93f96f0..a73c4cc 100644
--- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
+++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
@@ -382,11 +382,11 @@ FreeImageRecord (
   }
   FreePool (ImageRecord);
 }
 
 /**
-  Protect UEFI PE/COFF image
+  Protect UEFI PE/COFF image.
 
   @param[in]  LoadedImage              The loaded image protocol
   @param[in]  LoadedImageDevicePath    The loaded image device path protocol
 **/
 VOID
-- 
1.9.5.msysgit.1