From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E871221939308 for ; Mon, 3 Apr 2017 16:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491261458; x=1522797458; h=mime-version:content-transfer-encoding:to:message-id: from:in-reply-to:cc:references:subject:date; bh=s/kWtElorb4XHW3clkA0IyjhtcJuqfYcihJQ1HeugVo=; b=go68PcMB8oZ+8hnozjCYkLyykw86awQmG5e8VucUVZNGF2UWRuCIKS1P x3qYj2gq/fqKLArOnVUrDwxsuUgwCw==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2017 16:17:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,272,1486454400"; d="scan'208";a="951351091" Received: from decohen-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.140.50]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2017 16:17:38 -0700 MIME-Version: 1.0 To: Phil Dennis-Jordan , edk2-devel@lists.01.org Message-ID: <149126145788.19831.18152083893503471902@jljusten-skl> From: Jordan Justen In-Reply-To: <1491173097-37305-2-git-send-email-lists@philjordan.eu> Cc: Phil Dennis-Jordan , Laszlo Ersek References: <1491173097-37305-1-git-send-email-lists@philjordan.eu> <1491173097-37305-2-git-send-email-lists@philjordan.eu> User-Agent: alot/0.5.1 Date: Mon, 03 Apr 2017 16:17:38 -0700 Subject: Re: [PATCH v2 1/3] OvmfPkg: VMWare SVGA2 display device register definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 23:17:39 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-04-02 15:44:55, Phil Dennis-Jordan wrote: > From: Phil Dennis-Jordan > = > This adds a header file defining symbolic constants for the VMWare SVGA2 > virtual display device in preparation for supporting it in QemuVideoDXE. > = > It is an extract of the file lib/vmware/svga_reg.h from commit > 329dd537456f93a806841ec8a8213aed11395def of VMWare's vmware-svga > repository at git://git.code.sf.net/p/vmware-svga/git (See also > http://vmware-svga.sourceforge.net/ ) > = > Only the bare essentials necessary for initialisation, modesetting and > framebuffer access have been kept from the original file. > = > The original file was released by VMWare under the MIT license, this > has been retained. > = > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Phil Dennis-Jordan > --- > = > Notes: > v2: > - New, custom header file instead of importing VMWare's verbatim. [La= szlo] > = > OvmfPkg/Include/IndustryStandard/VMWareSVGA2.h | 102 ++++++++++++++++++++ > 1 file changed, 102 insertions(+) > = > diff --git a/OvmfPkg/Include/IndustryStandard/VMWareSVGA2.h b/OvmfPkg/Inc= lude/IndustryStandard/VMWareSVGA2.h I think EDK II's file naming convention would prefer VmwareSvga2.h, or possibly VmWareSvga2.h. (But, the former looks better to me.) Since it covers svga and svga2, should we just drop the '2' from the filename? > new file mode 100644 > index 000000000000..9db553155957 > --- /dev/null > +++ b/OvmfPkg/Include/IndustryStandard/VMWareSVGA2.h > @@ -0,0 +1,102 @@ > +/** @file > + > + Macro and enum definitions of a subset of port numbers, register ident= ifiers > + and values required for driving the VMWare SVGA2 virtual display adapt= er, > + also implemented by Qemu. > + > + This file's contents was extracted from file lib/vmware/svga_reg.h in = commit > + 329dd537456f93a806841ec8a8213aed11395def of VMWare's vmware-svga repos= itory: > + git://git.code.sf.net/p/vmware-svga/git > + > + > + Copyright 1998-2009 VMware, Inc. All rights reserved. > + Portions Copyright 2017 Phil Dennis-Jordan > + > + Permission is hereby granted, free of charge, to any person > + obtaining a copy of this software and associated documentation > + files (the "Software"), to deal in the Software without > + restriction, including without limitation the rights to use, copy, > + modify, merge, publish, distribute, sublicense, and/or sell copies > + of the Software, and to permit persons to whom the Software is > + furnished to do so, subject to the following conditions: > + > + The above copyright notice and this permission notice shall be > + included in all copies or substantial portions of the Software. > + > + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > + BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > + ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + SOFTWARE. > + > +**/ > + > +#ifndef _VMWARE_SVGA2_H_ > +#define _VMWARE_SVGA2_H_ > + > +// > +// IDs for recognising the device > +// > +#define PCI_VENDOR_ID_VMWARE 0x15AD > +#define PCI_DEVICE_ID_VMWARE_SVGA2 0x0405 > + > +// > +// I/O port BAR offsets for register selection and read/write. > +// > +// The register index is written to the 32-bit index port, followed by a= 32-bit > +// read or write on the value port to read or set that register's conten= ts. > +// > +#define SVGA_INDEX_PORT 0x0 > +#define SVGA_VALUE_PORT 0x1 Thanks for taking Laszlo's advice about pulling out the minimal definitions and EDK II-ifying it. (I think he may be right about the Xen contribution.) One request I have is, how about prefixing all the SVGA items as VMWARE_SVGA? SVGA seems to generic of a term here. Thanks, -Jordan > + > +// > +// Some of the device's register indices for basic framebuffer functiona= lity. > +// > +enum { > + SVGA_REG_ID =3D 0, > + SVGA_REG_ENABLE =3D 1, > + SVGA_REG_WIDTH =3D 2, > + SVGA_REG_HEIGHT =3D 3, > + SVGA_REG_MAX_WIDTH =3D 4, > + SVGA_REG_MAX_HEIGHT =3D 5, > + > + SVGA_REG_BITS_PER_PIXEL =3D 7, > + > + SVGA_REG_RED_MASK =3D 9, > + SVGA_REG_GREEN_MASK =3D 10, > + SVGA_REG_BLUE_MASK =3D 11, > + SVGA_REG_BYTES_PER_LINE =3D 12, > + > + SVGA_REG_FB_OFFSET =3D 14, > + > + SVGA_REG_FB_SIZE =3D 16, > + SVGA_REG_CAPABILITIES =3D 17, > + > + SVGA_REG_HOST_BITS_PER_PIXEL =3D 28, > +}; > + > +// > +// Values used with SVGA_REG_ID for sanity-checking the device and getti= ng > +// its version. > +// > +#define SVGA_MAGIC 0x900000UL > +#define SVGA_MAKE_ID(ver) (SVGA_MAGIC << 8 | (ver)) > + > +#define SVGA_VERSION_2 2 > +#define SVGA_ID_2 SVGA_MAKE_ID(SVGA_VERSION_2) > + > +#define SVGA_VERSION_1 1 > +#define SVGA_ID_1 SVGA_MAKE_ID(SVGA_VERSION_1) > + > +#define SVGA_VERSION_0 0 > +#define SVGA_ID_0 SVGA_MAKE_ID(SVGA_VERSION_0) > + > +// > +// One of the capability bits advertised by SVGA_REG_CAPABILITIES. > +// > +#define SVGA_CAP_8BIT_EMULATION 0x00000100 > + > +#endif > -- = > 2.3.2 (Apple Git-55) >=20