Re: [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support

[Jordan Justen <jordan.l.justen@intel.com>]

On 2017-04-05 06:58:33, Laszlo Ersek wrote:
> 
> This is #2.
> 
> Which one do you want to keep? I think we should drop #1, and keep #2.
> 
> Do you wish to submit v5, or are you okay if I remove #1 for you at
> commit time?
> 
> With this tweak,
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Before committing, I would like to give Jordan a chance to comment as
> well. I think Friday this week should be a good day to commit the series.

After convincing myself that, yes, the unaligned i/o was *actually*
required. :) / :(

Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

The one comment I had, is given how verbose the 3 inline assembly
source files are in patch 2, maybe nasm code would actually be cleaner
looking. But, considering we'd need both an IA32 and X64 version, it
isn't much better.

> Impressive work!

Agreed. Thanks for your contribution Phil!

-Jordan

> 
> > +      ModeInfo->PixelsPerScanLine = BytesPerLine / (BitsPerPixel / 8);
> > +
> > +      ModeData++;
> > +      ModeInfo++;
> > +    }
> > +    VideoMode++;
> > +  }
> > +  Private->MaxMode = ModeData - Private->ModeData;
> > +  return EFI_SUCCESS;
> > +
> > +Rollback:
> > +  FreePool (Private->VmwareSvgaModeInfo);
> > +  Private->VmwareSvgaModeInfo = NULL;
> > +
> > +ModeInfoAllocError:
> > +  FreePool (Private->ModeData);
> > +  Private->ModeData = NULL;
> > +
> > +ModeDataAllocError:
> > +  return Status;
> > +}
> > 
>