From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jordan.l.justen@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id AF83421A6F107
 for <edk2-devel@lists.01.org>; Wed,  5 Apr 2017 12:41:42 -0700 (PDT)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga105.fm.intel.com with ESMTP; 05 Apr 2017 12:41:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,280,1488873600"; d="scan'208";a="1115919815"
Received: from decohen-mobl1.amr.corp.intel.com (HELO localhost)
 ([10.252.140.50])
 by orsmga001.jf.intel.com with ESMTP; 05 Apr 2017 12:41:42 -0700
MIME-Version: 1.0
To: Laszlo Ersek <lersek@redhat.com>, Phil Dennis-Jordan <lists@philjordan.eu>,
 edk2-devel@lists.01.org
Message-ID: <149142130153.3336.7566104675598571677@jljusten-skl>
From: Jordan Justen <jordan.l.justen@intel.com>
In-Reply-To: <9ccc975c-36ad-e3ba-d909-3863c09dbf57@redhat.com>
Cc: Phil Dennis-Jordan <phil@philjordan.eu>
References: <1491396916-53170-1-git-send-email-lists@philjordan.eu>
 <1491396916-53170-4-git-send-email-lists@philjordan.eu>
 <9ccc975c-36ad-e3ba-d909-3863c09dbf57@redhat.com>
User-Agent: alot/0.5.1
Date: Wed, 05 Apr 2017 12:41:41 -0700
Subject: Re: [PATCH v4 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Apr 2017 19:41:42 -0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2017-04-05 06:58:33, Laszlo Ersek wrote:
> =

> This is #2.
> =

> Which one do you want to keep? I think we should drop #1, and keep #2.
> =

> Do you wish to submit v5, or are you okay if I remove #1 for you at
> commit time?
> =

> With this tweak,
> =

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> =

> Before committing, I would like to give Jordan a chance to comment as
> well. I think Friday this week should be a good day to commit the series.

After convincing myself that, yes, the unaligned i/o was *actually*
required. :) / :(

Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

The one comment I had, is given how verbose the 3 inline assembly
source files are in patch 2, maybe nasm code would actually be cleaner
looking. But, considering we'd need both an IA32 and X64 version, it
isn't much better.

> Impressive work!

Agreed. Thanks for your contribution Phil!

-Jordan

> =

> > +      ModeInfo->PixelsPerScanLine =3D BytesPerLine / (BitsPerPixel / 8=
);
> > +
> > +      ModeData++;
> > +      ModeInfo++;
> > +    }
> > +    VideoMode++;
> > +  }
> > +  Private->MaxMode =3D ModeData - Private->ModeData;
> > +  return EFI_SUCCESS;
> > +
> > +Rollback:
> > +  FreePool (Private->VmwareSvgaModeInfo);
> > +  Private->VmwareSvgaModeInfo =3D NULL;
> > +
> > +ModeInfoAllocError:
> > +  FreePool (Private->ModeData);
> > +  Private->ModeData =3D NULL;
> > +
> > +ModeDataAllocError:
> > +  return Status;
> > +}
> > =

>=20