public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	Kevin W Shaw <kevin.w.shaw@intel.com>
Subject: [edk2-FdfSpecification PATCH] Fix conditional statement examples
Date: Thu,  6 Apr 2017 14:56:23 -0700	[thread overview]
Message-ID: <1491515783-6496-2-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1491515783-6496-1-git-send-email-michael.d.kinney@intel.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=373

* Removge space between !if and else
* Add $() around BARFOO

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 2_fdf_design_discussion/22_flash_description_file_format.md | 4 ++--
 README.md                                                   | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/2_fdf_design_discussion/22_flash_description_file_format.md b/2_fdf_design_discussion/22_flash_description_file_format.md
index 9c993f4..dfbd889 100644
--- a/2_fdf_design_discussion/22_flash_description_file_format.md
+++ b/2_fdf_design_discussion/22_flash_description_file_format.md
@@ -600,7 +600,7 @@ The following is an example of conditional statements.
 ```ini
 !if ("MSFT" in $(FAMILY)) or ("INTEL" in $(FAMILY))
 ... statements
-!else if $(FAMILY) == "GCC"
+!elseif $(FAMILY) == "GCC"
 ... statements
 !endif
 
@@ -610,7 +610,7 @@ The following is an example of conditional statements.
   !else
     # FOO defined, BAR is defined
   !endif
-!elseif BARFOO
+!elseif $(BARFOO)
   # FOO is not defined, BARFOO is defined as TRUE
 !elseif $(BARFOO) == "FOOBAR"
   # FOO is not defined, BARFOO is defined as FOOBAR
diff --git a/README.md b/README.md
index 9a7f13a..74269dc 100644
--- a/README.md
+++ b/README.md
@@ -196,3 +196,4 @@ Copyright (c) 2006-2017, Intel Corporation. All rights reserved.
 |            | Clarified [UserExtensions] content in chapter 2 (to match implementation)                                                                                                  |               |
 | 1.28       | Convert to GitBooks                                                                                                                                                        | March 2017    |
 |            | [#426](https://bugzilla.tianocore.org/show_bug.cgi?id=426) IMAGE_TYPE_ID must be provided with value, FDF should mark it as required section                               |               |
+|            | [#373](https://bugzilla.tianocore.org/show_bug.cgi?id=373) Conditional statement examples incorrect                                                                        |               |
-- 
2.6.3.windows.1



  reply	other threads:[~2017-04-06 21:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 21:56 [edk2-FdfSpecification PATCH] Fix conditional statement examples Michael Kinney
2017-04-06 21:56 ` Michael Kinney [this message]
2017-04-07  1:22   ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491515783-6496-2-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox