public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	Kevin W Shaw <kevin.w.shaw@intel.com>
Subject: [edk2-FdfSpecification PATCH 2/2] Remove illegal white space in FDF file examples
Date: Fri,  7 Apr 2017 19:44:44 -0700	[thread overview]
Message-ID: <1491619484-18836-3-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1491619484-18836-1-git-send-email-michael.d.kinney@intel.com>

Remove space between '$' and '(' for macro usage
Remove space before/after directory separator '/'

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 2_fdf_design_discussion/25_[fv]_sections.md  | 12 ++++++------
 appendix_a_nt32pkg_flash_description_file.md | 14 +++++++-------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/2_fdf_design_discussion/25_[fv]_sections.md b/2_fdf_design_discussion/25_[fv]_sections.md
index d35f268..928455c 100644
--- a/2_fdf_design_discussion/25_[fv]_sections.md
+++ b/2_fdf_design_discussion/25_[fv]_sections.md
@@ -278,7 +278,7 @@ FFS file specification syntax is one of the following:
 OR
 
 ```c
-FILE Type $ (NAMED_GUID) [Options] {
+FILE Type $(NAMED_GUID) [Options] {
   SECTION SECTION_TYPE = FileName
   SECTION SECTION_TYPE = FileName
 }
@@ -371,7 +371,7 @@ The following is an example for using additional sections:
 #Encapsulation - Compress
 FILE FOO = 12345678-0000-AAAA-FFFF-0123ABCD12BD {
   SECTION COMPRESS {
-    SECTION PE32 = $ (WORKSPACE) / EdkModulePkg / Core / Dxe / DxeMain.inf
+    SECTION PE32 = $(WORKSPACE)/EdkModulePkg/Core/Dxe/DxeMain.inf
     SECTION VERSION = "1.2.3"
   }
 }
@@ -379,13 +379,13 @@ FILE FOO = 12345678-0000-AAAA-FFFF-0123ABCD12BD {
 # Encapsulation - GUIDED
 FILE FV_IMAGE = 87654321-FFFF-BBBB-2222-9874561230AB {
   SECTION GUIDED gEfiTianoCompressionScheme {
-    SECTION PE32 = $ (WORKSPACE) / EdkModulePkg / Core / Dxe / DxeMain.inf
+    SECTION PE32 = $(WORKSPACE)/EdkModulePkg/Core/Dxe/DxeMain.inf
   }
 }
 
 # LEAF Section
 FILE DXE_CORE = B5596C75-37A2-4b69-B40B-72ABD6DD8708 {
-  SECTION VERSION $ (BUILD_DIR)/$(ARCH)/D6A2CB7F-6A18-4E2F-B43B-9920A733700A-DxeMain.ver
+  SECTION VERSION $(BUILD_DIR)/$(ARCH)/D6A2CB7F-6A18-4E2F-B43B-9920A733700A-DxeMain.ver
 }
 ```
 
@@ -418,12 +418,12 @@ specify a string, that will be used to create an EFI section.
 The `GUIDED` encapsulation section uses one of the following formats.
 
 ```c
-SECTION GUIDED $ (GUID_CNAME) [auth] {
+SECTION GUIDED $(GUID_CNAME) [auth] {
   SECTION EFI_SECTION_TYPE = FILENAME
   SECTION EFI_SECTION_TYPE = "string"
 }
 
-SECTION GUIDED $ (GUID_CNAME) [auth] FILENAME
+SECTION GUIDED $(GUID_CNAME) [auth] FILENAME
 ```
 
 The required argument is the `GUIDED` name followed by an optional "auth"
diff --git a/appendix_a_nt32pkg_flash_description_file.md b/appendix_a_nt32pkg_flash_description_file.md
index 8d7a0ce..89be76c 100644
--- a/appendix_a_nt32pkg_flash_description_file.md
+++ b/appendix_a_nt32pkg_flash_description_file.md
@@ -369,7 +369,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.PEIM]
-  FILE PEIM = $ (NAMED_GUID){
+  FILE PEIM = $(NAMED_GUID){
     PEI_DEPEX PEI_DEPEX                 Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
     PE32      PE32 Align=4K             $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI        STRING = "$(MODULE_NAME)" Optional
@@ -377,7 +377,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.DXE_CORE]
-  FILE DXE_CORE = $ (NAMED_GUID) {
+  FILE DXE_CORE = $(NAMED_GUID) {
     COMPRESS PI_STD {
       PE32    PE32                      $(INF_OUTPUT)/$(MODULE_NAME).efi
       UI      STRING = "$(MODULE_NAME)" Optional
@@ -386,7 +386,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.UEFI_DRIVER]
-  FILE DRIVER = $ (NAMED_GUID) {
+  FILE DRIVER = $(NAMED_GUID) {
     DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
     COMPRESS PI_STD {
       GUIDED {
@@ -398,7 +398,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.UEFI_DRIVER.TIANOCOMPRESSED]
-  FILE DRIVER = $ (NAMED_GUID) {
+  FILE DRIVER = $(NAMED_GUID) {
     DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
     GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
       PE32    PE32                      $(INF_OUTPUT)/$(MODULE_NAME).efi
@@ -408,7 +408,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.DXE_DRIVER]
-  FILE DRIVER = $ (NAMED_GUID) {
+  FILE DRIVER = $(NAMED_GUID) {
     DXE_DEPEX   DXE_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
     COMPRESS PI_STD {
       GUIDED {
@@ -420,7 +420,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.DXE_RUNTIME_DRIVER]
-  FILE DRIVER = $ (NAMED_GUID) {
+  FILE DRIVER = $(NAMED_GUID) {
     DXE_DEPEX   DXE_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
     COMPRESS PI_STD {
       GUIDED {
@@ -432,7 +432,7 @@ FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
   }
 
 [Rule.Common.UEFI_APPLICATION]
-  FILE APPLICATION = $ (NAMED_GUID) {
+  FILE APPLICATION = $(NAMED_GUID) {
     COMPRESS PI_STD {
       GUIDED {
         PE32    PE32                      $(INF_OUTPUT)/$(MODULE_NAME).efi
-- 
2.6.3.windows.1



  parent reply	other threads:[~2017-04-08  2:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08  2:44 [edk2-FdfSpecification PATCH 0/2] Allow macros in !include file paths Michael Kinney
2017-04-08  2:44 ` [edk2-FdfSpecification PATCH 1/2] Use " Michael Kinney
2017-04-08  2:44 ` Michael Kinney [this message]
2017-04-11  1:34 ` [edk2-FdfSpecification PATCH 0/2] Allow " Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491619484-18836-3-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox