From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: hao.a.wu@intel.com, feng.tian@intel.com,
leif.lindholm@linaro.org, ard.biesheuvel@linaro.org,
edk2-devel@lists.01.org
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: [PATCH] MdeModulePkg: ScsiDiskDxe: fix to support EFI_ERASE_BLOCK_PROTOCOL
Date: Sat, 15 Apr 2017 21:44:46 +0800 [thread overview]
Message-ID: <1492263886-17209-1-git-send-email-haojian.zhuang@linaro.org> (raw)
If bit TPZ and bit TPRZ are set, the erase feature is implemented.
If bit TPZ is set and bit TPRZ is clear, the discard feature is
implemented. And discard is a non-secure variant of the erase
functionality.
So the detecting operation of EFI_ERASE_BLOCK_PROTOCOL, we should
consider to support both functionality. Since discard functionality is
only supported in some UFS devices.
And both of these two features are relied on UNMAP command.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index b5eff25..6e12e4f 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
@@ -5400,11 +5400,11 @@ DetermineInstallEraseBlock (
if (CommandStatus == EFI_SUCCESS) {
//
// Universal Flash Storage (UFS) Version 2.0
- // Section 11.3.9.2
+ // Section 11.3.9.2 & Section 12.2.3
// Bits TPE and TPRZ should both be set to enable the erase feature on UFS.
+ // Setting bit TPE and clearing bit TPRZ to enable the discard feature on UFS.
//
- if (((CapacityData16->LowestAlignLogic2 & BIT7) == 0) ||
- ((CapacityData16->LowestAlignLogic2 & BIT6) == 0)) {
+ if ((CapacityData16->LowestAlignLogic2 & BIT7) == 0) {
DEBUG ((
EFI_D_VERBOSE,
"ScsiDisk EraseBlock: Either TPE or TPRZ is not set: 0x%x.\n",
--
2.7.4
next reply other threads:[~2017-04-15 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 13:44 Haojian Zhuang [this message]
2017-04-17 1:58 ` [PATCH] MdeModulePkg: ScsiDiskDxe: fix to support EFI_ERASE_BLOCK_PROTOCOL Wu, Hao A
2017-04-17 14:03 ` Haojian Zhuang
2017-04-18 13:06 ` Wu, Hao A
2017-04-18 13:17 ` Haojian Zhuang
2017-04-18 15:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492263886-17209-1-git-send-email-haojian.zhuang@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox