From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5BB8921A04823 for ; Mon, 17 Apr 2017 21:41:56 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2017 21:41:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,218,1488873600"; d="scan'208";a="91063620" Received: from mdkinney-mobl.amr.corp.intel.com ([10.241.98.47]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2017 21:41:55 -0700 From: Michael Kinney To: edk2-devel@lists.01.org Cc: Liming Gao , Yonghong Zhu , Kevin W Shaw Date: Mon, 17 Apr 2017 21:41:08 -0700 Message-Id: <1492490468-23216-2-git-send-email-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.6.3.windows.1 In-Reply-To: <1492490468-23216-1-git-send-email-michael.d.kinney@intel.com> References: <1492490468-23216-1-git-send-email-michael.d.kinney@intel.com> Subject: [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 04:41:56 -0000 https://bugzilla.tianocore.org/show_bug.cgi?id=490 Clarify when error or warning messages are generated for VOID* PCDs when VPD offset is not aligned. Unicode string VPD PCDs must be 2-byte aligned. Byte array {} VPD PCDs should be 8-byte aligned, but is only a warning message if they are not 8-byte aligned. All other data types only require byte-alignment. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 7_build_environment/73_guided_tools.md | 16 ++++++++++++++-- README.md | 1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/7_build_environment/73_guided_tools.md b/7_build_environment/73_guided_tools.md index 878ae33..a8881d3 100644 --- a/7_build_environment/73_guided_tools.md +++ b/7_build_environment/73_guided_tools.md @@ -123,8 +123,20 @@ file required by the build system is provided in the appendix, VPD Tool. * ASCII strings, "string", will be byte aligned. * Unicode strings, L"string" will be two-byte aligned. - * Byte arrays, {0x00, 0x01} will be 8-byte aligned. If the developer assigns - offset values in the DSC file, the developer must follow the same rules. + * Byte arrays, {0x00, 0x01} will be 8-byte aligned. + + If the developer manually assigns offset values in the DSC file, the developer + must follow the same rules. + + ********** + **Note:** If a developer manually sets the offset of a `VOID*` PCD with + Unicode string, L"string", style to a value that is not 2-byte aligned, then + an error is generated and the build halts. + ********** + **Note:** If a developer manually sets the offset of a `VOID*` PCD with byte + array {} style to a value that is not 8-byte aligned, then a warning is + generated, but the build will continue. + ********** 2. Modify the FDF file: diff --git a/README.md b/README.md index 71c4511..8542434 100644 --- a/README.md +++ b/README.md @@ -203,3 +203,4 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved. | 1.27 | Convert to Gitbook | April 2017 | | | [#471](https://bugzilla.tianocore.org/show_bug.cgi?id=471) Build spec: only copy the "TianoCore" Userextension section into "As Built" INF | | | | [#472](https://bugzilla.tianocore.org/show_bug.cgi?id=472) [Build Spec] Extend macro usage in the !include statements for DSC/FDF files | | +| | [#490](https://bugzilla.tianocore.org/show_bug.cgi?id=490) Build Spec: specify the alignment requirements for VOID* PCDs stored in a PCD section | | -- 2.6.3.windows.1