From: Fu Siyuan <siyuan.fu@intel.com>
To: edk2-devel@lists.01.org
Cc: Ye Ting <ting.ye@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] OptionRomPkg: Fix calling convention issue for UndiRuntiumeDxe driver.
Date: Fri, 21 Apr 2017 09:32:34 +0800 [thread overview]
Message-ID: <1492738354-14220-1-git-send-email-siyuan.fu@intel.com> (raw)
Add "EFIAPI" to UNDI command entry point function according to UEFI calling
convention.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
OptionRomPkg/UndiRuntimeDxe/Decode.c | 3 ++-
OptionRomPkg/UndiRuntimeDxe/Undi32.h | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/OptionRomPkg/UndiRuntimeDxe/Decode.c b/OptionRomPkg/UndiRuntimeDxe/Decode.c
index 5f85347..cff6942 100644
--- a/OptionRomPkg/UndiRuntimeDxe/Decode.c
+++ b/OptionRomPkg/UndiRuntimeDxe/Decode.c
@@ -1,7 +1,7 @@
/** @file
Provides the basic UNID functions.
-Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -1276,6 +1276,7 @@ UNDI_Receive (
**/
// TODO: cdb - add argument and description to function comment
VOID
+EFIAPI
UNDI_APIEntry_new (
IN UINT64 cdb
)
diff --git a/OptionRomPkg/UndiRuntimeDxe/Undi32.h b/OptionRomPkg/UndiRuntimeDxe/Undi32.h
index 18341dd..00b48f6 100644
--- a/OptionRomPkg/UndiRuntimeDxe/Undi32.h
+++ b/OptionRomPkg/UndiRuntimeDxe/Undi32.h
@@ -1,7 +1,7 @@
/** @file
EFI internal structures for the EFI UNDI driver.
-Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -338,7 +338,7 @@ UNDI_Receive (
IN NIC_DATA_INSTANCE *AdapterInfo
);
-VOID UNDI_APIEntry_new(UINT64);
+VOID EFIAPI UNDI_APIEntry_new(UINT64);
VOID UNDI_APIEntry_Common(UINT64);
PXE_IPV4 convert_mcip(PXE_MAC_ADDR *);
--
2.7.4.windows.1
next reply other threads:[~2017-04-21 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 1:32 Fu Siyuan [this message]
2017-04-21 1:55 ` [Patch] OptionRomPkg: Fix calling convention issue for UndiRuntiumeDxe driver Wu, Jiaxin
2017-04-21 2:02 ` Ye, Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492738354-14220-1-git-send-email-siyuan.fu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox