public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	Kevin W Shaw <kevin.w.shaw@intel.com>
Subject: [edk2-BuildSpecification PATCH V2 1/2] Clean up minor formatting issues
Date: Tue, 25 Apr 2017 23:56:51 -0700	[thread overview]
Message-ID: <1493189812-10248-2-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1493189812-10248-1-git-send-email-michael.d.kinney@intel.com>

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 .../43_pre-build_stage_overview.md                 | 22 ++++++++++------------
 .../45_post-build_stage.md                         | 12 ++++++------
 .../82_auto-generation_process.md                  |  2 +-
 .../87_generated_asbuilt_inf_files.md              |  2 +-
 4 files changed, 18 insertions(+), 20 deletions(-)

diff --git a/4_edk_ii_build_process_overview/43_pre-build_stage_overview.md b/4_edk_ii_build_process_overview/43_pre-build_stage_overview.md
index 30177a8..0fde612 100644
--- a/4_edk_ii_build_process_overview/43_pre-build_stage_overview.md
+++ b/4_edk_ii_build_process_overview/43_pre-build_stage_overview.md
@@ -250,21 +250,19 @@ directory name and the `BASE_NAME` of the module's INF file.
 
    * Create the module Makefiles
 
-   Individual modules may require different compilation options, over-riding any
-   global definitions. If an INF file is not listed in the DSC file and is listed
-   in the FDF file, the parsing tools must check if the INF in the FDF file
-   contains `PatchableInModule` or `DynamicEX` entries. If the INF lists other PCD
-   access methods (FeatureFlag,
-
-   FixedAtBuild or Dynamic), and the INF contains files listed in a `[Sources]`
-   section and does not contain a `[Binaries]` section, then the build tools must
-   break the build with an appropriate error message.
+   Individual modules may require different compilation options, over-riding
+   any global definitions. If an INF file is not listed in the DSC file and is
+   listed in the FDF file, the parsing tools must check if the INF in the FDF
+   file contains `PatchableInModule` or `DynamicEX` entries. If the INF lists
+   other PCD access methods (FeatureFlag, FixedAtBuild or Dynamic), and the INF
+   contains files listed in a `[Sources]` section and does not contain a
+   `[Binaries]` section, then the build tools must break the build with an
+   appropriate error message.
 
 6. The tools are also responsible for creating binary files containing all
    `DynamicEx` PCDs that are listed in the DSC, FDF and Binary INF files
-   (listed in the FDF file).
-   These binaries are automatically placed into the (PEIM and DXE) PCD driver FFS
-   files.
+   (listed in the FDF file). These binaries are automatically placed into the
+   (PEIM and DXE) PCD driver FFS files.
 
 7. If the build option, --ignore-sources is present on the build command-line,
    none of the source files listed in a [Sources] section will be processed,
diff --git a/4_edk_ii_build_process_overview/45_post-build_stage.md b/4_edk_ii_build_process_overview/45_post-build_stage.md
index c8a90e1..c35d9be 100644
--- a/4_edk_ii_build_process_overview/45_post-build_stage.md
+++ b/4_edk_ii_build_process_overview/45_post-build_stage.md
@@ -64,12 +64,12 @@ following must occur.
    that entry must be ignored - these files are not to be placed into an
    `EFI_SECTION_DISPOSABLE` encapsulation section.
 
-2. If an INF not listed in the DSC file. is listed in the FDF file and the INF
-   contains a `[PatchPcd]` section, the tools must test to determine if the PCD
-   is listed in the DSC (or FDF) file, and whether the value listed in the DSC
-   (or FDF) file is different from the value in the INF file. If the value is
-   different, the tools must patch the binary .efi file with the value from the
-   FDF or DSC file prior to creating the EFI leaf section.
+2. If an INF not listed in the DSC file, but is listed in the FDF file and the
+   INF contains a `[PatchPcd]` section, the tools must test to determine if the
+   PCD is listed in the DSC (or FDF) file, and whether the value listed in the
+   DSC (or FDF) file is different from the value in the INF file. If the value
+   is different, the tools must patch the binary .efi file with the value from
+   the FDF or DSC file prior to creating the EFI leaf section.
 
 3. The tools are also responsible for creating binary files containing all
    DynamicEx PCDs that are listed in the DSC, FDF and Binary INF files (listed
diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md b/8_pre-build_autogen_stage/82_auto-generation_process.md
index 6868d62..92b6d99 100644
--- a/8_pre-build_autogen_stage/82_auto-generation_process.md
+++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
@@ -772,7 +772,7 @@ that is unique to the GUID known as the TokenSpaceGuidCName.
 
 The following list defines the five PCD access methods.
 
-* **FeatureFlag PCD**; used in conditional directive statements in code.
+* **FeatureFlag PCD** - used in conditional directive statements in code.
 
 * **PatchableInModule PCD** - a volatile variable that can be updated either
   during a build or by a tool that knows the offset and data size of the
diff --git a/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.md b/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.md
index 9e89d83..0f39879 100644
--- a/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.md
+++ b/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.md
@@ -431,7 +431,7 @@ For ACPI files from a platform, the entry must use the following format:
 
 `<TS> ACPI|Filename.acpi <EOL>`
 
-For a Binary or raw binary file, the entry may use either of the the following
+For a Binary or raw binary file, the entry may use either of the following
 two formats:
 
 ```
-- 
2.6.3.windows.1



  reply	other threads:[~2017-04-26  6:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  6:56 [edk2-BuildSpecification PATCH V2 0/2] Add --pcd flag to override PCD values on command line Michael Kinney
2017-04-26  6:56 ` Michael Kinney [this message]
2017-04-26  6:56 ` [edk2-BuildSpecification PATCH V2 2/2] " Michael Kinney
2017-04-26  7:16 ` [edk2-BuildSpecification PATCH V2 0/2] " Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493189812-10248-2-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox