From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Fan, Jeff" <jeff.fan@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
edk2-devel-01 <edk2-devel@lists.01.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: SMRAM sizes on large hosts
Date: Thu, 04 May 2017 08:18:55 +0200 [thread overview]
Message-ID: <1493878735.371.8.camel@redhat.com> (raw)
In-Reply-To: <d3b31efe-598b-3c57-cb7a-29ee0210b7e2@redhat.com>
Hi,
> > The problem with this is that I need the TSEG size in another module as
> > well, namely PlatformPei. The dispatch order between PlatformPei and
> > SmmAccessPei is unspecified (they have both TRUE for DEPEX). If
> > PlatformPei gets dispatched second, I really wouldn't want to write to
> > MCH_ESMRAMC again, just to query MCH_TSEGMB. (I couldn't just read
> > MCH_TSEGMB because if PlatformPei were dispatched first, then MCH_TSEGMB
> > would still be unset).
> >
> > In other words, I wouldn't like to write a register just to receive the
> > information; I need the information in two places whose relative
> > ordering is unspecified, and one of those already writes the register in
> > question, genuinely. I guess I could hack it around with another dynamic
> > PCD, but that's kind of ugly.
Hmm, this unspecified ordering works nicely today because tseg size is a
compile time constant. If we make this dynamic we either need a pcd or
must probe tseg size twice (no matter whenever this is some pci cfg
space register or fw_cfg file), which is kind of ugly too ...
> > If we invented a read-only, side-effect-free PCI config space register
> > that gave me this value plain and simple (similarly to how a new fw_cfg
> > file would do), that would be a lot cleaner for me.
That makes the "probe twice" thing easier indeed.
> > I think this would
> > match your earlier alternative where you wrote "Alternatively we could
> > add some qemu-specific register".
Yes.
cheers,
Gerd
next prev parent reply other threads:[~2017-05-04 6:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 18:16 SMRAM sizes on large hosts Laszlo Ersek
2017-05-02 20:49 ` Kinney, Michael D
2017-05-03 1:20 ` Yao, Jiewen
2017-05-03 6:57 ` Gerd Hoffmann
2017-05-03 12:56 ` Paolo Bonzini
2017-05-03 13:14 ` Laszlo Ersek
2017-05-03 13:26 ` Paolo Bonzini
2017-05-03 13:35 ` Laszlo Ersek
2017-05-03 13:55 ` Paolo Bonzini
2017-05-03 22:34 ` Laszlo Ersek
2017-05-03 12:58 ` Laszlo Ersek
2017-05-03 13:44 ` Gerd Hoffmann
2017-05-03 22:33 ` Laszlo Ersek
2017-05-03 23:36 ` Laszlo Ersek
2017-05-04 6:18 ` Gerd Hoffmann [this message]
2017-05-04 14:52 ` Gerd Hoffmann
2017-05-04 15:21 ` Laszlo Ersek
2017-05-04 8:23 ` Igor Mammedov
2017-05-04 11:34 ` Laszlo Ersek
2017-05-04 14:00 ` Igor Mammedov
2017-05-04 14:41 ` Gerd Hoffmann
2017-05-04 14:50 ` Igor Mammedov
2017-05-04 15:19 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493878735.371.8.camel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox