From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A6E221A070BA for ; Fri, 5 May 2017 08:43:54 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2017 08:43:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,293,1491289200"; d="scan'208";a="1126883084" Received: from jcluyand-mobl1.amr.corp.intel.com (HELO localhost) ([10.255.66.185]) by orsmga001.jf.intel.com with ESMTP; 05 May 2017 08:43:53 -0700 MIME-Version: 1.0 To: Laszlo Ersek Message-ID: <149399903262.14207.13532012674948464509@jljusten-skl> From: Jordan Justen In-Reply-To: <9ff79644-8767-bf10-7d0a-2f5ab6555e23@redhat.com> Cc: edk2-devel-01 , Gary Ching-Pang Lin References: <20170503213947.32290-1-lersek@redhat.com> <20170503213947.32290-4-lersek@redhat.com> <149397463765.13335.18098739662202283758@jljusten-skl> <9ff79644-8767-bf10-7d0a-2f5ab6555e23@redhat.com> User-Agent: alot/0.5.1 Date: Fri, 05 May 2017 08:43:52 -0700 Subject: Re: [PATCH v2 3/5] OvmfPkg: introduce 4MB flash image (mainly) for Windows HCK X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 15:43:55 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-05-05 05:07:25, Laszlo Ersek wrote: > = > Which one do you prefer: > (1) I can take your patch, stick in the UINTN cast, and expand the > commit message a bit (similarly to what's on my patch), > (2) we can go with my patch as well. I prefer your patch. Re: "0001-OvmfPkg-PlatformPei-handle-non-power-of-two-spare-si.patch" > + Alignment =3D GetPowerOfTwo32 (Alignment) << 1; Do you think this might end up needing a UINT32 cast with 64-bit PEI? Reviewed-by: Jordan Justen > Regarding the non-flash path, I have the attached work-in-progress patche= s: > = > - "OvmfPkg: sync PcdVariableStoreSize with PcdFlashNvStorageVariableSize", > - and "wip". I looked over the non-wip patch, and it seems good, but maybe we should just revert the default size for now. For a revert of bba8dfbec3bbc4fba7fa6398ba3cf76593e0725e: Reviewed-by: Jordan Justen