From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>, Star Zeng <star.zeng@intel.com>,
Eric Dong <eric.dong@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [Patch 1/2] MdeModulePkg/RegularExpressionDxe: Fix XCODE5 build failure
Date: Tue, 23 May 2017 16:10:26 -0700 [thread overview]
Message-ID: <1495581027-18592-2-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1495581027-18592-1-git-send-email-michael.d.kinney@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=572
The ErrorMessage local variable in OnigurumaMatch() should
be type OnigUChar instead of type CHAR8. This resolves
a build failure with the XCODE5 tool chain.
Cc: Andrew Fish <afish@apple.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c
index a5ee7d5..cf325fc 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c
@@ -88,7 +88,7 @@ OnigurumaMatch (
OnigRegion *Region;
INT32 OnigResult;
OnigErrorInfo ErrorInfo;
- CHAR8 ErrorMessage[ONIG_MAX_ERROR_MESSAGE_LEN];
+ OnigUChar ErrorMessage[ONIG_MAX_ERROR_MESSAGE_LEN];
UINT32 Index;
OnigUChar *Start;
EFI_STATUS Status;
--
2.6.3.windows.1
next prev parent reply other threads:[~2017-05-23 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 23:10 [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures Michael Kinney
2017-05-23 23:10 ` Michael Kinney [this message]
2017-05-23 23:10 ` [Patch 2/2] MdeModulePkg/DebugSupportDxe: Fix XCODE5 build failure Michael Kinney
2017-05-24 0:58 ` [Patch 0/2] MdeModulePkg: Fix XCODE5 build failures Zeng, Star
2017-05-24 23:42 ` Andrew Fish
-- strict thread matches above, loose matches on Subject: below --
2017-05-23 23:03 Michael Kinney
2017-05-23 23:03 ` [Patch 1/2] MdeModulePkg/RegularExpressionDxe: Fix XCODE5 build failure Michael Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495581027-18592-2-git-send-email-michael.d.kinney@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox