public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated
@ 2017-05-27  3:08 Michael Kinney
  2017-05-27  3:08 ` Michael Kinney
  2017-05-31  1:49 ` Zhu, Yonghong
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Kinney @ 2017-05-27  3:08 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

https://bugzilla.tianocore.org/show_bug.cgi?id=481

GitHub branch for review:

* https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_481_NoValueCheckOnUnreferrencedPcd

GitHub word diff view of the patches in this series:

* [1/1] https://github.com/mdkinney/edk2-BuildSpecification/commit/b6e588b374a707311d8fc6088daf458fbc02a3ca?w=1

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (1):
  Clarify that values of unused PCD are not evaluated

 13_build_reports/134_platform_summary.md | 5 +++++
 README.md                                | 1 +
 2 files changed, 6 insertions(+)

-- 
2.6.3.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated
  2017-05-27  3:08 [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated Michael Kinney
@ 2017-05-27  3:08 ` Michael Kinney
  2017-05-31  1:49 ` Zhu, Yonghong
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Kinney @ 2017-05-27  3:08 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

https://bugzilla.tianocore.org/show_bug.cgi?id=481

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 13_build_reports/134_platform_summary.md | 5 +++++
 README.md                                | 1 +
 2 files changed, 6 insertions(+)

diff --git a/13_build_reports/134_platform_summary.md b/13_build_reports/134_platform_summary.md
index e6f2a15..0674141 100644
--- a/13_build_reports/134_platform_summary.md
+++ b/13_build_reports/134_platform_summary.md
@@ -140,6 +140,11 @@ The first line is required:
 Additional lines may be displayed showing default values when the value is not a
 default value.
 
+Since the PCDs in this section are not used by any module, the PCD value is not
+evaluated to determine if it is a valid value or in a value in a valid range.
+Instead, the PCD value from the DSC file, FDF file, or build option are
+displayed exactly as they were entered.
+
 ### Example
 
 ```
diff --git a/README.md b/README.md
index 16fcc4a..6b6d5b9 100644
--- a/README.md
+++ b/README.md
@@ -212,3 +212,4 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved.
 |            | [#504](https://bugzilla.tianocore.org/show_bug.cgi?id=504) Update build report to support -Y HASH option                                                                                                                                                                                                                                                            |               |
 |            | [#508](https://bugzilla.tianocore.org/show_bug.cgi?id=508) Build Spec: Add sections to PCD report for PCDs only used in conditions PCDs that are not used anywhere                                                                                                                                                                                                  |               |
 |            | [#480](https://bugzilla.tianocore.org/show_bug.cgi?id=480) Build spec: add description for Override PCD value on the command line                                                                                                                                                                                                                                   |               |
+|            | [#481](https://bugzilla.tianocore.org/show_bug.cgi?id=481) Build Spec: add clarification for not used Pcd that build tool will not do additional checks on its value                                                                                                                                                                                                |               |
-- 
2.6.3.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated
  2017-05-27  3:08 [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated Michael Kinney
  2017-05-27  3:08 ` Michael Kinney
@ 2017-05-31  1:49 ` Zhu, Yonghong
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, Yonghong @ 2017-05-31  1:49 UTC (permalink / raw)
  To: Kinney, Michael D, edk2-devel@lists.01.org
  Cc: Gao, Liming, Shaw, Kevin W, Zhu, Yonghong

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, May 27, 2017 11:09 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
Subject: [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated

https://bugzilla.tianocore.org/show_bug.cgi?id=481

GitHub branch for review:

* https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_481_NoValueCheckOnUnreferrencedPcd

GitHub word diff view of the patches in this series:

* [1/1] https://github.com/mdkinney/edk2-BuildSpecification/commit/b6e588b374a707311d8fc6088daf458fbc02a3ca?w=1

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (1):
  Clarify that values of unused PCD are not evaluated

 13_build_reports/134_platform_summary.md | 5 +++++
 README.md                                | 1 +
 2 files changed, 6 insertions(+)

-- 
2.6.3.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-31  1:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-27  3:08 [edk2-BuildSpecification PATCH] Clarify that values of unused PCD are not evaluated Michael Kinney
2017-05-27  3:08 ` Michael Kinney
2017-05-31  1:49 ` Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox