From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 19BEB2094552B for ; Thu, 8 Jun 2017 07:29:40 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5FF92B; Thu, 8 Jun 2017 07:30:48 -0700 (PDT) Received: from [10.0.2.15] (u203142.usa.arm.com [10.118.30.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8D77E3F3E1; Thu, 8 Jun 2017 07:30:48 -0700 (PDT) Message-ID: <1496932248.3781.6.camel@arm.com> From: Supreeth Venkatesh To: "Gao, Liming" , "edk2-devel@lists.01.org" Cc: "leif.lindholm@arm.com" , "ard.biesheuvel@linaro.org" Date: Thu, 08 Jun 2017 09:30:48 -0500 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D746FC9@shsmsx102.ccr.corp.intel.com> References: <1496699034-4186-1-git-send-email-supreeth.venkatesh@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D746FC9@shsmsx102.ccr.corp.intel.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Subject: Re: [PATCH 00/10] *** BaseTools: Tools change to support PI v1.5 Specification. *** X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 14:29:40 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Thu, 2017-06-08 at 03:32 +0000, Gao, Liming wrote: > Supreeth: >   Thanks for your contribution. I review this patch set, and have two > comments.  Thanks Liming for reviewing the Patch set. > 1) This is added in PI1.5. So, its version check should be with > 0x00010032 (1 and 50), not 0x0001000A (1 and 10).  Smm standalone > module INF needs to specify PI_SPECIFICATION_VERSION       = > 0x00010032. I will rectify it and upload v2 version. > 2) Does the change conform to doc change recorded in below bugzilla? > https://bugzilla.tianocore.org/show_bug.cgi?id=550 Not sure about the [Depex] sections (page 34). Will check this and confirm before uploading v2. > https://bugzilla.tianocore.org/show_bug.cgi?id=551 Yes. It conforms with this, though I will recheck once again. > https://bugzilla.tianocore.org/show_bug.cgi?id=552 Yes. It conforms with this, though I will recheck once again. > > Thanks > Liming > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > Of > > Supreeth Venkatesh > > Sent: Tuesday, June 06, 2017 5:44 AM > > To: edk2-devel@lists.01.org > > Cc: leif.lindholm@arm.com; ard.biesheuvel@linaro.org > > Subject: [edk2] [PATCH 00/10] *** BaseTools: Tools change to > > support PI v1.5 > > Specification. *** > > > > *** > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface. > > In order to support Management Mode Core Interface, Module Types > > MM_STANDALONE, MM_CORE_STANDALONE are needed. > > PI specification v1.5 defines the following new file types: > > #define EFI_FV_FILETYPE_MM 0x0A > > #define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > > #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > > The following changes are necessitated in order to support the > > above changes > > to the specification. > > *** > > > > Supreeth Venkatesh (10): > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > >  BaseTools: Tools change to support PI v1.5 Specification. > > > > BaseTools/Source/C/GenFfs/GenFfs.c                 |   6 +- > > BaseTools/Source/C/GenFw/GenFw.c                   |   5 +- > > BaseTools/Source/C/Include/Common/PiFirmwareFile.h |   1 + > > BaseTools/Source/Python/AutoGen/GenC.py            | 148 > > ++++++++++++++++++++- > > BaseTools/Source/Python/AutoGen/GenDepex.py        |  17 ++- > > BaseTools/Source/Python/Common/DataType.py         |   4 +- > > BaseTools/Source/Python/Common/FdfParserLite.py    |   4 +- > > .../Source/Python/CommonDataClass/CommonClass.py   |   6 +- > > .../Source/Python/CommonDataClass/PackageClass.py  |   2 +- > > BaseTools/Source/Python/Eot/FvImage.py             |   1 + > > BaseTools/Source/Python/GenFds/FdfParser.py        |   4 +- > > BaseTools/Source/Python/GenFds/Ffs.py              |   7 +- > > BaseTools/Source/Python/GenFds/FfsInfStatement.py  |   3 + > > .../Source/Python/Workspace/WorkspaceDatabase.py   |   4 + > > BaseTools/Source/Python/build/BuildReport.py       |   4 +- > > BaseTools/Source/Python/build/build.py             |   2 +- > > 16 files changed, 199 insertions(+), 19 deletions(-) > > > > -- > > 2.7.4 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel