* [Patch 1/2] MdeModulePkg/Network: Typo fix
2017-06-13 6:02 [Patch 0/2] Typo fix and comments correction Jiaxin Wu
@ 2017-06-13 6:02 ` Jiaxin Wu
2017-06-13 6:02 ` [Patch 2/2] NetworkPkg: Typo fix and comments correction Jiaxin Wu
2017-06-13 6:07 ` [Patch 0/2] " Fu, Siyuan
2 siblings, 0 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-06-13 6:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin
warter -> water
Maunual -> Manual
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 4 ++--
MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c
index f4dfbb6..3e38085 100644
--- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c
+++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c
@@ -1226,11 +1226,11 @@ Ip4Config2SetPolicy (
@retval EFI_SUCCESS The specified configuration data for the EFI IPv6
network stack was set.
**/
EFI_STATUS
-Ip4Config2SetMaunualAddress (
+Ip4Config2SetManualAddress (
IN IP4_CONFIG2_INSTANCE *Instance,
IN UINTN DataSize,
IN VOID *Data
)
{
@@ -1926,11 +1926,11 @@ Ip4Config2InitInstance (
DataItem->DataSize = sizeof (Instance->Policy);
Instance->Policy = Ip4Config2PolicyStatic;
SET_DATA_ATTRIB (DataItem->Attribute, DATA_ATTRIB_SIZE_FIXED);
DataItem = &Instance->DataItem[Ip4Config2DataTypeManualAddress];
- DataItem->SetData = Ip4Config2SetMaunualAddress;
+ DataItem->SetData = Ip4Config2SetManualAddress;
DataItem->Status = EFI_NOT_FOUND;
DataItem = &Instance->DataItem[Ip4Config2DataTypeGateway];
DataItem->SetData = Ip4Config2SetGateway;
DataItem->Status = EFI_NOT_FOUND;
diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
index 8c25c63..9c2e6d0 100644
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
@@ -371,11 +371,11 @@ typedef enum {
///
/// The buffer structure of rcvd data and send data used by socket.
///
typedef struct _SOCK_BUFFER {
UINT32 HighWater; ///< The buffersize upper limit of sock_buffer
- UINT32 LowWater; ///< The low warter mark of sock_buffer
+ UINT32 LowWater; ///< The low water mark of sock_buffer
NET_BUF_QUEUE *DataQueue; ///< The queue to buffer data
} SOCK_BUFFER;
/**
The handler of protocol for request from socket.
@@ -591,12 +591,12 @@ typedef struct _SOCK_INIT_DATA {
SOCK_TYPE Type;
UINT8 State;
SOCKET *Parent; ///< The parent of this socket
UINT32 BackLog; ///< The connection limit for listening socket
- UINT32 SndBufferSize; ///< The high warter mark of send buffer
- UINT32 RcvBufferSize; ///< The high warter mark of receive buffer
+ UINT32 SndBufferSize; ///< The high water mark of send buffer
+ UINT32 RcvBufferSize; ///< The high water mark of receive buffer
VOID *Protocol; ///< The pointer to protocol function template
///< wanted to install on socket
//
// Callbacks after socket is created and before socket is to be destroyed.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Patch 2/2] NetworkPkg: Typo fix and comments correction
2017-06-13 6:02 [Patch 0/2] Typo fix and comments correction Jiaxin Wu
2017-06-13 6:02 ` [Patch 1/2] MdeModulePkg/Network: Typo fix Jiaxin Wu
@ 2017-06-13 6:02 ` Jiaxin Wu
2017-06-13 6:07 ` [Patch 0/2] " Fu, Siyuan
2 siblings, 0 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-06-13 6:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin
warter -> water
Maunual -> Manual
TCP and UDP --> TCP4 and TCP6
TCP or UDP --> TCP4 or TCP6
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 6 +++---
NetworkPkg/TcpDxe/Socket.h | 10 +++++-----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
index 7575b79..7c7acc7 100644
--- a/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
+++ b/NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
@@ -754,11 +754,11 @@ Ip6ConfigSetDadXmits (
}
/**
The callback function for Ip6SetAddr. The prototype is defined
as IP6_DAD_CALLBACK. It is called after Duplicate Address Detection is performed
- for the manual address set by Ip6ConfigSetMaunualAddress.
+ for the manual address set by Ip6ConfigSetManualAddress.
@param[in] IsDadPassed If TRUE, Duplicate Address Detection passed.
@param[in] TargetAddress The tentative IPv6 address to be checked.
@param[in] Context Pointer to the IP6 configuration instance data.
@@ -894,11 +894,11 @@ Ip6ManualAddrDadCallback (
@retval EFI_SUCCESS The specified configuration data for the EFI IPv6
network stack was set.
**/
EFI_STATUS
-Ip6ConfigSetMaunualAddress (
+Ip6ConfigSetManualAddress (
IN IP6_CONFIG_INSTANCE *Instance,
IN UINTN DataSize,
IN VOID *Data
)
{
@@ -2216,11 +2216,11 @@ Ip6ConfigInitInstance (
DataItem->DataSize = sizeof (Instance->DadXmits);
Instance->DadXmits.DupAddrDetectTransmits = IP6_CONFIG_DEFAULT_DAD_XMITS;
SET_DATA_ATTRIB (DataItem->Attribute, DATA_ATTRIB_SIZE_FIXED);
DataItem = &Instance->DataItem[Ip6ConfigDataTypeManualAddress];
- DataItem->SetData = Ip6ConfigSetMaunualAddress;
+ DataItem->SetData = Ip6ConfigSetManualAddress;
DataItem->Status = EFI_NOT_FOUND;
DataItem = &Instance->DataItem[Ip6ConfigDataTypeGateway];
DataItem->SetData = Ip6ConfigSetGateway;
DataItem->Status = EFI_NOT_FOUND;
diff --git a/NetworkPkg/TcpDxe/Socket.h b/NetworkPkg/TcpDxe/Socket.h
index 371e9ab..f7f4a7a 100644
--- a/NetworkPkg/TcpDxe/Socket.h
+++ b/NetworkPkg/TcpDxe/Socket.h
@@ -359,11 +359,11 @@ typedef enum {
///
/// The buffer structure of rcvd data and send data used by socket.
///
typedef struct _SOCK_BUFFER {
UINT32 HighWater; ///< The buffersize upper limit of sock_buffer
- UINT32 LowWater; ///< The low warter mark of sock_buffer
+ UINT32 LowWater; ///< The low water mark of sock_buffer
NET_BUF_QUEUE *DataQueue; ///< The queue to buffer data
} SOCK_BUFFER;
/**
The handler of protocol for request from socket.
@@ -423,12 +423,12 @@ typedef struct _SOCK_INIT_DATA {
SOCK_TYPE Type;
UINT8 State;
SOCKET *Parent; ///< The parent of this socket
UINT32 BackLog; ///< The connection limit for listening socket
- UINT32 SndBufferSize; ///< The high warter mark of send buffer
- UINT32 RcvBufferSize; ///< The high warter mark of receive buffer
+ UINT32 SndBufferSize; ///< The high water mark of send buffer
+ UINT32 RcvBufferSize; ///< The high water mark of receive buffer
UINT8 IpVersion;
VOID *Protocol; ///< The pointer to protocol function template
///< wanted to install on socket
//
@@ -448,11 +448,11 @@ typedef struct _SOCK_INIT_DATA {
EFI_HANDLE DriverBinding; ///< The driver binding handle
} SOCK_INIT_DATA;
///
-/// The union type of TCP and UDP protocol.
+/// The union type of TCP4 and TCP6 protocol.
///
typedef union _NET_PROTOCOL {
EFI_TCP4_PROTOCOL Tcp4Protocol; ///< Tcp4 protocol
EFI_TCP6_PROTOCOL Tcp6Protocol; ///< Tcp6 protocol
} NET_PROTOCOL;
@@ -500,11 +500,11 @@ struct _TCP_SOCKET {
// Interface for low level protocol
//
SOCK_PROTO_HANDLER ProtoHandler; ///< The request handler of protocol
UINT8 ProtoReserved[PROTO_RESERVED_LEN]; ///< Data fields reserved for protocol
UINT8 IpVersion;
- NET_PROTOCOL NetProtocol; ///< TCP or UDP protocol socket used
+ NET_PROTOCOL NetProtocol; ///< TCP4 or TCP6 protocol socket used
//
// Callbacks after socket is created and before socket is to be destroyed.
//
SOCK_CREATE_CALLBACK CreateCallback; ///< Callback after created
SOCK_DESTROY_CALLBACK DestroyCallback; ///< Callback before destroied
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch 0/2] Typo fix and comments correction
2017-06-13 6:02 [Patch 0/2] Typo fix and comments correction Jiaxin Wu
2017-06-13 6:02 ` [Patch 1/2] MdeModulePkg/Network: Typo fix Jiaxin Wu
2017-06-13 6:02 ` [Patch 2/2] NetworkPkg: Typo fix and comments correction Jiaxin Wu
@ 2017-06-13 6:07 ` Fu, Siyuan
2 siblings, 0 replies; 4+ messages in thread
From: Fu, Siyuan @ 2017-06-13 6:07 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
-----Original Message-----
From: Wu, Jiaxin
Sent: Tuesday, June 13, 2017 2:03 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin
Subject: [Patch 0/2] Typo fix and comments correction
warter -> water
Maunual -> Manual
TCP and UDP --> TCP4 and TCP6
TCP or UDP --> TCP4 or TCP6
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Jiaxin Wu (2):
MdeModulePkg/Network: Typo fix
NetworkPkg: Typo fix and comments correction
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 4 ++--
MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h | 6 +++---
NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c | 6 +++---
NetworkPkg/TcpDxe/Socket.h | 10 +++++-----
4 files changed, 13 insertions(+), 13 deletions(-)
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 4+ messages in thread