public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, michael.d.kinney@intel.com,
	liming.gao@intel.com, achin.gupta@arm.com,
	supreeth.venkatesh@arm.com, felixp@ami.com,
	jbrasen@qti.qualcomm.com, jonathan.zhang@cavium.com,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH v3 09/10] BaseTools: Tools change to support PI v1.5 Specification.
Date: Thu, 22 Jun 2017 20:54:25 +0100	[thread overview]
Message-ID: <1498161266-18877-10-git-send-email-supreeth.venkatesh@arm.com> (raw)
In-Reply-To: <1498161266-18877-1-git-send-email-supreeth.venkatesh@arm.com>

This patch checks SUP_MODULE_SMM_CORE_STANDALONE and
SUP_MODULE_SMM_STANDALONE module compatibility with PI specification
version.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 BaseTools/Source/Python/Workspace/WorkspaceDatabase.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
index c1af5c7..599c6df 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
@@ -1977,6 +1977,11 @@ class InfBuildData(ModuleBuildClassObject):
             if (self._Specification == None) or (not 'PI_SPECIFICATION_VERSION' in self._Specification) or (int(self._Specification['PI_SPECIFICATION_VERSION'], 16) < 0x0001000A):
                 if self._ModuleType == SUP_MODULE_SMM_CORE:
                     EdkLogger.error("build", FORMAT_NOT_SUPPORTED, "SMM_CORE module type can't be used in the module with PI_SPECIFICATION_VERSION less than 0x0001000A", File=self.MetaFile)
+            if (self._Specification == None) or (not 'PI_SPECIFICATION_VERSION' in self._Specification) or (int(self._Specification['PI_SPECIFICATION_VERSION'], 16) < 0x00010032):
+                if self._ModuleType == SUP_MODULE_SMM_CORE_STANDALONE:
+                    EdkLogger.error("build", FORMAT_NOT_SUPPORTED, "SMM_CORE_STANDALONE module type can't be used in the module with PI_SPECIFICATION_VERSION less than 0x00010032", File=self.MetaFile)
+                if self._ModuleType == SUP_MODULE_SMM_STANDALONE:
+                    EdkLogger.error("build", FORMAT_NOT_SUPPORTED, "SMM_STANDALONE module type can't be used in the module with PI_SPECIFICATION_VERSION less than 0x00010032", File=self.MetaFile)
             if self._Defs and 'PCI_DEVICE_ID' in self._Defs and 'PCI_VENDOR_ID' in self._Defs \
                and 'PCI_CLASS_CODE' in self._Defs and 'PCI_REVISION' in self._Defs:
                 self._BuildType = 'UEFI_OPTIONROM'
-- 
2.7.4



  parent reply	other threads:[~2017-06-22 19:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 19:54 [PATCH v3 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification *** Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Specification Supreeth Venkatesh
2017-06-23  3:23   ` Gao, Liming
2017-06-23 16:08     ` Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 02/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 03/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 04/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 05/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 06/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 07/10] " Supreeth Venkatesh
2017-06-22 19:54 ` [PATCH v3 08/10] " Supreeth Venkatesh
2017-06-22 19:54 ` Supreeth Venkatesh [this message]
2017-06-22 19:54 ` [PATCH v3 10/10] " Supreeth Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498161266-18877-10-git-send-email-supreeth.venkatesh@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox