From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 062CD21A143F5 for ; Mon, 26 Jun 2017 09:14:25 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 105A880D; Mon, 26 Jun 2017 09:15:54 -0700 (PDT) Received: from [10.0.2.15] (u203142.usa.arm.com [10.118.30.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 99D213F4FF; Mon, 26 Jun 2017 09:15:53 -0700 (PDT) Message-ID: <1498493753.2947.1.camel@arm.com> From: Supreeth Venkatesh To: Laszlo Ersek , edk2-devel@lists.01.org Cc: jonathan.zhang@cavium.com, liming.gao@intel.com, leif.lindholm@linaro.org, felixp@ami.com, michael.d.kinney@intel.com, jbrasen@qti.qualcomm.com Date: Mon, 26 Jun 2017 11:15:53 -0500 In-Reply-To: References: <1498250516-47996-1-git-send-email-supreeth.venkatesh@arm.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Subject: Re: [PATCH v4 00/10] *** BaseTools: Tools change to support MM Interface in PI v1.5 Specification *** X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 16:14:25 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Fri, 2017-06-23 at 23:19 +0200, Laszlo Ersek wrote: > Hi, > > On 06/23/17 22:41, Supreeth Venkatesh wrote: > > > > ***  > > PI v1.5 Specification Volume 4 defines Management Mode Core > > Interface. > > In order to support Management Mode Core Interface, Module Types > > MM_STANDALONE, MM_CORE_STANDALONE are needed.  > > PI specification v1.5 defines the following new file types: > > #define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > > #define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F > > The following changes are necessitated in order to support the > > above changes to the specification.  > > > > Changes Since v3: > > (*) Update Review Comments from Liming, Felix. > > (*) Directly define FV file types MM_STANDALONE / > > MM_CORE_STANDALONE > > and module types MM_STANDALONE / MM_CORE_STANDALONE > > i.e., with MM prefix instead of SMM prefix. > > > > Changes Since v2: > > Add missing EFI_FV_FILETYPE_MM_CORE_STANDALONE defined in PI > > Specification v1.5 VOL3,  > > but not defined in VOL4. > > > > Changes Since v1: > > Corrected Version check HEX Value "0x00010032" (1 and 50), not > > 0x0001000A (1 and 10) > > *** > I have a generic comment for this series (sorry that I'm making it > this > late; I'm somewhat surprised that others haven't pointed out the same > yet): > > Every patch in the series has the exact same subject: > >   BaseTools: Tools change to support PI v1.5 Specification. > > Unfortunately, that's useless. The commit message *bodies* look great > and thoughtful, but the subject lines convey zero meaning. > > Please replace every subject with a meaningful summary of the larger > commit message, such that the subject line still fits in 74 > characters > or so. For example, for the first two patches: > > BaseTools/GenFfs: add FFS file types for management mode modules > BaseTools/GenFw: recognize MM file types as EFI Boot Service Drivers > > and so on. Alright. Thanks for looking at it. I will upload the same patch set with just the commit subject change. > > Thanks, > Laszlo