public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: Purma, Kondal R <kondal.r.purma@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] EDK II Python development process specification -draft
Date: Mon, 16 Mar 2020 03:21:47 -0700	[thread overview]
Message-ID: <14987.1584354107104009732@groups.io> (raw)
In-Reply-To: <14952.1584212837980088983@groups.io>

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Hi Kondal ,

I agree the coding guidelines and tools can help improve the python code quality, but I think these guidelines in this spec are too general for BaseTools. Besides the coding style,  BaseTools has many specific code issues, such as the high coupling between modules, not clear module interface, big function with hundreds lines, abused global variables. I hope there could be a python code design guidelines, for example, how to apply the software design principle or the software design pattern in the Basetools development process.

I think this spec itself looks good.

Thanks,
Bob

[-- Attachment #2: Type: text/html, Size: 643 bytes --]

  reply	other threads:[~2020-03-16 10:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 20:05 [edk2-devel] EDK II Python development process specification -draft Rebecca Cran
2020-03-11 16:52 ` Purma, Kondal R
2020-03-14 19:07   ` Purma, Kondal R
2020-03-16 10:21     ` Bob Feng [this message]
2020-03-24 20:22       ` Purma, Kondal R
2020-03-25 21:23         ` Purma, Kondal R
  -- strict thread matches above, loose matches on Subject: below --
2020-03-07  0:27 Purma, Kondal R
2020-03-07 21:35 ` [edk2-devel] " Sean
2020-03-07 23:26   ` Purma, Kondal R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14987.1584354107104009732@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox