From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] EDK II Python development process specification -draft
To: Purma, Kondal R <kondal.r.purma@intel.com>,devel@edk2.groups.io
From: "Bob Feng" <bob.c.feng@intel.com>
X-Originating-Location: Shanghai, CN (192.102.204.36)
X-Originating-Platform: Windows Chrome 79
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Mon, 16 Mar 2020 03:21:47 -0700
References: <14952.1584212837980088983@groups.io>
In-Reply-To: <14952.1584212837980088983@groups.io>
Message-ID: <14987.1584354107104009732@groups.io>
Content-Type: multipart/alternative; boundary="Y40xbSB9bjrObh42xDka"

--Y40xbSB9bjrObh42xDka
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Kondal=C2=A0,

I agree the coding guidelines and tools can help improve the python code q=
uality, but I think these guidelines in this spec are too general for BaseT=
ools. Besides the coding style,=C2=A0 BaseTools has many specific code issu=
es, such as the high coupling between modules, not clear module interface, =
big function with hundreds lines, abused global variables. I hope there cou=
ld be a python code design guidelines, for example, how to apply the softwa=
re design principle or the software design pattern in the Basetools develop=
ment process.

I think this spec itself looks good.

Thanks,
Bob

--Y40xbSB9bjrObh42xDka
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Kondal&nbsp;,<br /><br />I agree the coding guidelines and tools can hel=
p improve the python code quality, but I think these guidelines in this spe=
c are too general for BaseTools. Besides the coding style,&nbsp; BaseTools =
has many specific code issues, such as the high coupling between modules, n=
ot clear module interface, big function with hundreds lines, abused global =
variables. I hope there could be a python code design guidelines, for examp=
le, how to apply the software design principle or the software design patte=
rn in the Basetools development process.<br /><br />I think this spec itsel=
f looks good.<br /><br />Thanks,<br />Bob

--Y40xbSB9bjrObh42xDka--