From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 645AE2095896D for ; Wed, 5 Jul 2017 10:29:54 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2017 10:31:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,312,1496127600"; d="scan'208";a="1168409807" Received: from dwsu-mobl.amr.corp.intel.com (HELO localhost) ([10.254.57.106]) by fmsmga001.fm.intel.com with ESMTP; 05 Jul 2017 10:31:16 -0700 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel-01 Message-ID: <149927587550.638.9288616709761107179@jljusten-skl> From: Jordan Justen In-Reply-To: <20170704165629.13610-1-lersek@redhat.com> References: <20170704165629.13610-1-lersek@redhat.com> User-Agent: alot/0.5.1 Date: Wed, 05 Jul 2017 10:31:16 -0700 Subject: Re: [PATCH v2 0/8] OvmfPkg: recognize an extended TSEG when QEMU offers it X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 17:29:54 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-07-04 09:56:21, Laszlo Ersek wrote: > This is version 2 of the series posted previously at > . > = > Version 2 is a rewrite from scratch based on Jordan's feedback for v1 > and the subsequent discussion. > = > Repo: https://github.com/lersek/edk2.git > Branch: extended_tseg_bz1447027_v2 > = > Cc: Jordan Justen > = > Thanks > Laszlo > = > Laszlo Ersek (8): > OvmfPkg: widen PcdQ35TsegMbytes to UINT16 > OvmfPkg/PlatformPei: prepare for PcdQ35TsegMbytes becoming dynamic > OvmfPkg/SmmAccess: prepare for PcdQ35TsegMbytes becoming dynamic Maybe InitQ35TsegMbytes instead of FetchQ35TsegMbytes. I also thought a GetQ35TsegMbytes function could just return the value rather than adding an externally visible global. Not a big deal. > OvmfPkg: make PcdQ35TsegMbytes dynamic > OvmfPkg/IndustryStandard/Q35MchIch9.h: add extended TSEG size macros > OvmfPkg/SmmAccess: support extended TSEG size Some indentation issues in SmramInternal.c. > OvmfPkg/PlatformPei: honor extended TSEG in PcdQ35TsegMbytes if > available > OvmfPkg: mention the extended TSEG near the PcdQ35TsegMbytes > declaration Series Reviewed-by: Jordan Justen > = > OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 4 ++ > OvmfPkg/OvmfPkg.dec | 15 +++-- > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/PlatformPei/MemDetect.c | 67 +++++++++++++++++++- > OvmfPkg/PlatformPei/Platform.c | 14 ++-- > OvmfPkg/PlatformPei/Platform.h | 7 ++ > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 1 + > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 3 + > OvmfPkg/SmmAccess/SmmAccessPei.c | 10 +-- > OvmfPkg/SmmAccess/SmmAccessPei.inf | 4 +- > OvmfPkg/SmmAccess/SmramInternal.c | 25 +++++++- > OvmfPkg/SmmAccess/SmramInternal.h | 13 ++++ > 14 files changed, 142 insertions(+), 24 deletions(-) > = > -- = > 2.13.1.3.g8be5a757fa67 >=20