* [Patch 1/4] MdePkg MpServices: Update return status to follow spec.
2017-07-06 1:30 [Patch 0/4] Update code to follow spec definition Eric Dong
@ 2017-07-06 1:30 ` Eric Dong
2017-07-06 1:30 ` [Patch 2/4] UefiCpuPkg CpuDxe: " Eric Dong
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Eric Dong @ 2017-07-06 1:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
---
MdePkg/Include/Ppi/MpServices.h | 4 ++--
MdePkg/Include/Protocol/MpService.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Ppi/MpServices.h b/MdePkg/Include/Ppi/MpServices.h
index 2c21d64..37d6b8e 100644
--- a/MdePkg/Include/Ppi/MpServices.h
+++ b/MdePkg/Include/Ppi/MpServices.h
@@ -3,7 +3,7 @@
This PPI is installed by some platform or chipset-specific PEIM that abstracts
handling multiprocessor support.
- Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -187,7 +187,7 @@ EFI_STATUS
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to this
service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or a disabled
diff --git a/MdePkg/Include/Protocol/MpService.h b/MdePkg/Include/Protocol/MpService.h
index 0dbd150..b76ecd0 100644
--- a/MdePkg/Include/Protocol/MpService.h
+++ b/MdePkg/Include/Protocol/MpService.h
@@ -27,7 +27,7 @@
APs to help test system memory in parallel with other device initialization.
Diagnostics applications may also use this protocol for multi-processor.
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available under
the terms and conditions of the BSD License that accompanies this distribution.
The full text of the license may be found at
@@ -491,7 +491,7 @@ EFI_STATUS
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to
this service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Patch 2/4] UefiCpuPkg CpuDxe: Update return status to follow spec.
2017-07-06 1:30 [Patch 0/4] Update code to follow spec definition Eric Dong
2017-07-06 1:30 ` [Patch 1/4] MdePkg MpServices: Update return status to follow spec Eric Dong
@ 2017-07-06 1:30 ` Eric Dong
2017-07-06 1:30 ` [Patch 3/4] UefiCpuPkg CpuMpPei: " Eric Dong
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Eric Dong @ 2017-07-06 1:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/CpuDxe/CpuMp.c | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
index 4456946..372c1e3 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.c
+++ b/UefiCpuPkg/CpuDxe/CpuMp.c
@@ -412,7 +412,7 @@ StartupThisAP (
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to
this service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or
diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h b/UefiCpuPkg/CpuDxe/CpuMp.h
index 43ec3bd..d530149 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.h
+++ b/UefiCpuPkg/CpuDxe/CpuMp.h
@@ -375,7 +375,7 @@ StartupThisAP (
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to
this service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Patch 3/4] UefiCpuPkg CpuMpPei: Update return status to follow spec.
2017-07-06 1:30 [Patch 0/4] Update code to follow spec definition Eric Dong
2017-07-06 1:30 ` [Patch 1/4] MdePkg MpServices: Update return status to follow spec Eric Dong
2017-07-06 1:30 ` [Patch 2/4] UefiCpuPkg CpuDxe: " Eric Dong
@ 2017-07-06 1:30 ` Eric Dong
2017-07-06 1:30 ` [Patch 4/4] UefiCpuPkg MpInitLib: " Eric Dong
2017-07-06 1:53 ` [Patch 0/4] Update code to follow spec definition Fan, Jeff
4 siblings, 0 replies; 6+ messages in thread
From: Eric Dong @ 2017-07-06 1:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 2 +-
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.c b/UefiCpuPkg/CpuMpPei/CpuMpPei.c
index eaf99c7..3b72f44 100644
--- a/UefiCpuPkg/CpuMpPei/CpuMpPei.c
+++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.c
@@ -302,7 +302,7 @@ PeiStartupThisAP (
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to this
service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or a disabled
diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.h b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
index 0836593..aae5665 100644
--- a/UefiCpuPkg/CpuMpPei/CpuMpPei.h
+++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
@@ -271,7 +271,7 @@ PeiStartupThisAP (
@retval EFI_UNSUPPORTED Switching the BSP cannot be completed prior to this
service returning.
@retval EFI_UNSUPPORTED Switching the BSP is not supported.
- @retval EFI_SUCCESS The calling processor is an AP.
+ @retval EFI_DEVICE_ERROR The calling processor is an AP.
@retval EFI_NOT_FOUND The processor with the handle specified by
ProcessorNumber does not exist.
@retval EFI_INVALID_PARAMETER ProcessorNumber specifies the current BSP or a disabled
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Patch 4/4] UefiCpuPkg MpInitLib: Update return status to follow spec.
2017-07-06 1:30 [Patch 0/4] Update code to follow spec definition Eric Dong
` (2 preceding siblings ...)
2017-07-06 1:30 ` [Patch 3/4] UefiCpuPkg CpuMpPei: " Eric Dong
@ 2017-07-06 1:30 ` Eric Dong
2017-07-06 1:53 ` [Patch 0/4] Update code to follow spec definition Fan, Jeff
4 siblings, 0 replies; 6+ messages in thread
From: Eric Dong @ 2017-07-06 1:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index df19b43..a3eea29 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -1584,7 +1584,7 @@ SwitchBSPWorker (
//
MpInitLibWhoAmI (&CallerNumber);
if (CallerNumber != CpuMpData->BspNumber) {
- return EFI_SUCCESS;
+ return EFI_DEVICE_ERROR;
}
if (ProcessorNumber >= CpuMpData->CpuCount) {
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Patch 0/4] Update code to follow spec definition.
2017-07-06 1:30 [Patch 0/4] Update code to follow spec definition Eric Dong
` (3 preceding siblings ...)
2017-07-06 1:30 ` [Patch 4/4] UefiCpuPkg MpInitLib: " Eric Dong
@ 2017-07-06 1:53 ` Fan, Jeff
4 siblings, 0 replies; 6+ messages in thread
From: Fan, Jeff @ 2017-07-06 1:53 UTC (permalink / raw)
To: Dong, Eric, edk2-devel@lists.01.org
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Eric Dong
Sent: Thursday, July 06, 2017 9:30 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/4] Update code to follow spec definition.
Update return status code for SwitchBSP function to follow spec.
Eric Dong (4):
MdePkg MpServices: Update return status to follow spec.
UefiCpuPkg CpuDxe: Update return status to follow spec.
UefiCpuPkg CpuMpPei: Update return status to follow spec.
UefiCpuPkg MpInitLib: Update return status to follow spec.
MdePkg/Include/Ppi/MpServices.h | 4 ++--
MdePkg/Include/Protocol/MpService.h | 4 ++--
UefiCpuPkg/CpuDxe/CpuMp.c | 2 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 2 +-
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 2 +-
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
7 files changed, 9 insertions(+), 9 deletions(-)
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread