From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0CF7621A00AD0 for ; Thu, 6 Jul 2017 14:40:59 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 14:42:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,319,1496127600"; d="scan'208";a="108134687" Received: from jljusten-skl.jf.intel.com (HELO localhost) ([10.241.230.85]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2017 14:42:39 -0700 MIME-Version: 1.0 To: Brijesh Singh , edk2-devel@lists.01.org Message-ID: <149937735857.21467.1917283905856299959@jljusten-skl.jf.intel.com> From: Jordan Justen In-Reply-To: <6b79e292-e587-46a8-1f6a-a0483a01f8f7@amd.com> Cc: brijesh.singh@amd.com, Thomas.Lendacky@amd.com, leo.duran@amd.com, Jeff Fan , Liming Gao , Laszlo Ersek , Jiewen Yao , Michael D Kinney References: <1495809845-32472-1-git-send-email-brijesh.singh@amd.com> <2c3b8722-0e91-af09-5d3b-c5751dd53a9f@amd.com> <149935954954.18473.9057866656909328887@jljusten-skl> <6b79e292-e587-46a8-1f6a-a0483a01f8f7@amd.com> User-Agent: alot/0.5.1 Date: Thu, 06 Jul 2017 14:42:38 -0700 Subject: Re: [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 21:40:59 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-07-06 13:11:03, Brijesh Singh wrote: > = > = > On 07/06/2017 11:45 AM, Jordan Justen wrote: > > On 2017-07-05 15:31:20, Brijesh Singh wrote: > >> Hi Jordan and Laszlo, > >> > >> Ping. > >> > >> It has been a while, Do you have any further feedbacks on this series ? > >> If you want then I can rebase the patches before you commit into upstr= eam repos. > >> > > = > > I'm still dissappointed by the APRIORI usage. > > = > > As I understand it, you are also dissatisfied with this approach and > > you hope to improve things by somehow hooking into DXE Core. Is that > > true? If so, can you create a bugzilla regarding this feature? When > > would you plan to work to address that? > > = > = > I think we agree in that this particular use-case has shown the need for = re-thinking > the existing GCD interface. However, the problem we are trying to solve w= ith this > patch-set is enabling the SEV feature. As it turns out, we can do so with= in the > existing GCD framework by simply leveraging the APRIORI hook already in u= se by OvmfPkg. > = > In that context, our proposal is that we limit the scope of this patch-se= t to simply > enabling the SEV feature, and then allow the 'GCD experts' to separately = propose updates > to the framework. This sounds like you don't plan to work on this, but will just leave it to the 'GCD experts'. Is that right? I am asking that you file and own a bugzilla for this. You'd obviously need to work with the package owners though. Unless you drive this, I don't think anyone will be motivated enough to get it fixed. -Jordan > = > > I guess with that resolved, you could add an Acked-by from me. > > = > > In general, it'd also be nice to move the processor features to more > > generic places, although that may be challenging if the next step is > > some kind of platform hook from DXE Core. Maybe if the DXE Core calls > > out to some protocol or signals an event then a driver in UefiCpuPkg > > could handle the protocol implementation to modify the page tables. > > = > > -Jordan > > = > >