From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mx.groups.io with SMTP id smtpd.web12.1746.1610121337314722289 for ; Fri, 08 Jan 2021 07:55:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=KkpZ1p1U; spf=pass (domain: nuviainc.com, ip: 209.85.222.180, mailfrom: rebecca@nuviainc.com) Received: by mail-qk1-f180.google.com with SMTP id f26so8837890qka.0 for ; Fri, 08 Jan 2021 07:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PvxYF5vQikboi7kaK2YjqcE+TquBKlbeVhdulvz6PTM=; b=KkpZ1p1UonApiNXI0B7GjLaGnHnyjs83EtBHgDQ28XS6bYhLlxrvubUJlsRdtWVjV9 9OQ7Ho9KH2MUvLLpxQR6XCKbCXGOx3u43Inx1z9OZIr4dDTxS4DWoem4Yw8O6v35A/Ua U712aDMC9FC3uO96Tjd0AqyXXO2SLfY7iOiFcK4UDGlkB9JaTr825YMqb22VnNXCh0GR 38PhD0hPVqp8nQ5TYEGg4i28gqRnkrx2gpitWQYelUju8P6VYvuTYdp5ztishjTIDLiT AY6q0NHtxOuUX43xRfjHeibGOk2rYOnz/g9PoGvH/BoFLxVkKpLuZrX0bV40/zyligrs GMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PvxYF5vQikboi7kaK2YjqcE+TquBKlbeVhdulvz6PTM=; b=njBh/gn9sFZ2rTThwO6W+wgwbEwbHLBPa3pyYJ1NAVxnn2RnFmiTEhgEW3IZ2+YtV/ R549T3GPab9TbIqaA0z80w/h9Ydn+7V/mZ4dWTKpSOY+T/ULRwFZeyezh/STU+nmqGh/ pI3FYkfNRyvKsALUZcdQluDL0XdfV2nJZ88oTi+qbIzSctVLWsfKWolKRbPtV7xRM5iq hkMcCNvvk1e8tMN+Mm+1D99kVLZRbuGG9GOdTz2gSmK3utjI2Sw+kwV7XIUzYejoInWC icqevRRJKHMzD9LObPTev06rW1cYFReZfFpwYOuInYeUUNH/hde7x/Fu7hYw+/pe4MIy jXLg== X-Gm-Message-State: AOAM531OOyi2U7oi7UzO9tt99/+xVdJxk39lnYNVJKlivWih7r58+INl 5twF7R+XmMxV/sMXyZaNCTCu5w== X-Google-Smtp-Source: ABdhPJzMcsUjE/5CEByBdynNWSK5vL4fBP+ZvHip+BOqpWlL3Hc2wAhuroIsj2cVb5Wn986sv+pgwQ== X-Received: by 2002:a37:6611:: with SMTP id a17mr4543128qkc.150.1610121336484; Fri, 08 Jan 2021 07:55:36 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id n5sm4857774qkh.126.2021.01.08.07.55.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 07:55:35 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v5 00/23] ArmPkg,MdePkg: Add Universal/Smbios, and related changes To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Liming Gao , Michael D Kinney , Zhiguang Liu References: <20210104225830.12606-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <1499c0a3-0e35-7678-e898-4c71226abb45@nuviainc.com> Date: Fri, 8 Jan 2021 08:55:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/5/21 3:14 PM, Samer El-Haj-Mahmoud wrote: > I did quick review of parts of the patch, mostly compared against the RPi4 implementation which has been validated in the past. > > On the platform on which you are implementing this, are you able to run the FWTS SMBIOS tests and confirm that everything passes? > > Also, one question on the patch in general: Any reason why not to include the nuvia copyright header in these files? I haven't run the FWTS SMBIOS tests, but I'll make sure to run them before I submit the next version of the patch series. I'm never sure whether the changes I'm making are large enough to justify adding my own or NUVIA's copyright. Since I have now made quite a few changes to the original sources, I'll add it. -- Rebecca Cran