From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 08B1F74005E for ; Thu, 2 Nov 2023 10:20:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y5paLHhWnoJxGgQfuG2UtPwwcodNEKxcBOEKw7/Z8C0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:From:Subject:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698920414; v=1; b=Kox3GOscdzgkqEChywSyEmz5/+4e1JDhzSFgl7mCNNyM7RqOfl0zpRYrlI6F6IoEzv+aWxRP sC/G5T11KShphjhA1pjrxC4X5g5UhBZxwgPTAHQ9IGqtZAgpz/eT4y0ofFHoE2ughB5VPFqLUWe ShCcEErX7bQ5mf9dljQW8lF4= X-Received: by 127.0.0.2 with SMTP id yoAmYY7687511xNHUN4QHXbJ; Thu, 02 Nov 2023 03:20:14 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.27686.1698920414170400147 for ; Thu, 02 Nov 2023 03:20:14 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 044F7C15; Thu, 2 Nov 2023 03:20:56 -0700 (PDT) X-Received: from [10.34.100.114] (e126645.nice.arm.com [10.34.100.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E659B3F67D; Thu, 2 Nov 2023 03:20:12 -0700 (PDT) Message-ID: <149b3a0e-98c2-4032-afea-4eccb7b57336@arm.com> Date: Thu, 2 Nov 2023 11:20:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "PierreGondois" Subject: Re: [edk2-devel] [PATCH v2 07/11] DynamicTablesPkg: Add PsdToken field to CM_ARM_GICC_INFO object To: Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-8-pierre.gondois@arm.com> In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ObtrrKAPFwYcK4BbU9GrWelYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Kox3GOsc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/26/23 12:45, Leif Lindholm wrote: > On Wed, Oct 25, 2023 at 13:25:36 +0200, pierre.gondois@arm.com wrote: >> From: Pierre Gondois >> >> The _PSD object (cf. ACPI 6.4, s8.4.5.5 _PSD (P-State Dependency) >> allows to describe CPU's power state dependencies. Add a PsdToken >> field to the CM_ARM_GICC_INFO object so that interdependent CPUs >> can reference the same CM_ARM_PSD_INFO object. >> >> Signed-off-by: Pierre Gondois >> --- >> DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 5 +++++ >> .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 5 +++-- >> 2 files changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTab= lesPkg/Include/ArmNameSpaceObjects.h >> index ddd17fa45b1e..2a0ebe24bd04 100644 >> --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h >> +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h >> @@ -204,6 +204,11 @@ typedef struct CmArmGicCInfo { >> i.e. a token referencing a CM_ARM_CPC_INFO object. >> */ >> CM_OBJECT_TOKEN CpcToken; >> + >> + /** Optional field: Reference Token for the Psd info of this processo= r. >> + i.e. a token referencing a CM_ARM_PSD_INFO object. >> + */ >> + CM_OBJECT_TOKEN PsdToken; >> } CM_ARM_GICC_INFO; >> =20 >> /** A structure that describes the >> diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/Configuratio= nManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Con= figurationManagerObjectParser.c >> index b3ee12da8c4f..a9f5c95c1039 100644 >> --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManage= rObjectParser.c >> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManage= rObjectParser.c >> @@ -83,7 +83,8 @@ STATIC CONST CM_OBJ_PARSER CmArmGicCInfoParser[] =3D = { >> { "ProximityDomain", 4, "0x%x",= NULL }, >> { "ClockDomain", 4, "0x%x",= NULL }, >> { "AffinityFlags", 4, "0x%x",= NULL }, >> - { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", = NULL } >> + { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", = NULL }, >> + { "PsdToken", sizeof (CM_OBJECT_TOKEN), "0x%p", = NULL }, >> }; >> =20 >> /** A parser for EArmObjGicDInfo. >> @@ -766,7 +767,7 @@ STATIC CONST CM_OBJ_PARSER_ARRAY ArmNamespaceObject= Parser[] =3D { >> ARRAY_SIZE (CmArmPccSubspaceType34InfoParser) }, >> { "EArmObjPccSubspaceType5Info", CmArmPccSubspaceType5InfoPa= rser, >> ARRAY_SIZE (CmArmPccSubspaceType5InfoParser) }, >> - { "EArmObjCpcInfo", CmArmPsdInfoParser, >> + { "EArmObjPsdInfo", CmArmPsdInfoParser, >=20 > Can you add something to the commit message about this bit? This is actually a naming mistake in: [PATCH v1 06/11] DynamicTablesPkg: Add CM_ARM_PSD_INFO object I will correct it it there, the change in this patch should be removed. Regards, Pierre >=20 > / > Leif >=20 >> ARRAY_SIZE (CmArmPsdInfoParser) }, >> { "EArmObjMax", NULL, = 0 }, >> }; >> --=20 >> 2.25.1 >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110516): https://edk2.groups.io/g/devel/message/110516 Mute This Topic: https://groups.io/mt/102175817/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-