From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.sgi.com [192.48.180.66]) by ml01.01.org (Postfix) with ESMTP id 3304D1A1E05 for ; Tue, 18 Oct 2016 08:34:08 -0700 (PDT) Received: from xmail.sgi.com (pv-excas3-dc21.corp.sgi.com [137.38.106.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id E49A98F8087; Tue, 18 Oct 2016 08:34:06 -0700 (PDT) Received: from [128.162.232.243] (128.162.232.243) by xmail.sgi.com (137.38.106.6) with Microsoft SMTP Server (TLS) id 14.3.301.0; Tue, 18 Oct 2016 10:34:06 -0500 To: Feng Tian , Star Zeng References: <20161007155942.GD3471@bivouac.eciton.net> <69f91a5f-c1bf-db40-6800-6aafb8fc6faf@redhat.com> CC: Laszlo Ersek , Ryan Harkin , Leif Lindholm , Roy Franz , "edk2-devel@lists.01.org" From: "Brian J. Johnson" Message-ID: <14a9ee7d-f184-c2bd-ed13-3d146fff4e36@sgi.com> Date: Tue, 18 Oct 2016 10:34:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <69f91a5f-c1bf-db40-6800-6aafb8fc6faf@redhat.com> X-Originating-IP: [128.162.232.243] Subject: Re: [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 15:34:08 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 10/14/2016 03:37 PM, Laszlo Ersek wrote: > On 10/14/16 21:39, Brian J. Johnson wrote: >> On 10/12/2016 03:17 AM, Ryan Harkin wrote: >>> On 7 October 2016 at 16:59, Leif Lindholm >>> wrote: >>>> Roy can now be found at Roy Franz (cc:d). >>>> >>>> On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: >>>>> Roy, Ryan, >>>>> >>>>> On 10/07/16 16:53, Brian J. Johnson wrote: >>>>>> This patch series implements some improvements to the TtyTerm terminal >>>>>> type in the TerminalDxe driver. It fixes an end case with cursor >>>>>> position tracking, and uses that to optimize cursor motion escape >>>>>> sequences. It also adds support for the page up, page down, insert, >>>>>> home, and end keys on some additional common terminal emulators. >>>>>> >>>>>> The result is improved performance, especially at the shell prompt, >>>>>> and better compatibility with common terminal emulators. In >>>>>> particular, as a side effect of the optimized cursor motion, terminal >>>>>> windows which are taller than the current mode setting (eg. 25 lines) >>>>>> work much better than before. >>>>>> >>>>>> Most of these fixes have been in production in some form on SGI's >>>>>> servers for years. >>>>>> >>>>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>>>> Signed-off-by: Brian Johnson >>>>>> Cc: Feng Tian >>>>>> Cc: Star Zeng >>>>>> >>>>>> Brian J. Johnson (3): >>>>>> MdeModulePkg/TerminalDxe: Improve TtyTerm cursor position tracking >>>>>> MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion >>>>>> MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm >>>>>> >>>>>> .../Universal/Console/TerminalDxe/Terminal.h | 2 + >>>>>> .../Universal/Console/TerminalDxe/TerminalConIn.c | 24 +++++++-- >>>>>> .../Universal/Console/TerminalDxe/TerminalConOut.c | 61 >>>>>> ++++++++++++++++++++-- >>>>>> 3 files changed, 79 insertions(+), 8 deletions(-) >>>>>> >>>>> >>>>> can you please provide feedback (testing or otherwise) on this series? >>>>> >>> >>> Well, they "work" for me and I'd be happy with them being submitted. >>> >>> Tested-by: Ryan Harkin >>> >>> The only curious effect I can see is the Print(L"xxx"); lines that >>> expect the \n to be missing will no longer "work". For example, I >>> carry a patch by Daniil Egranov titled >>> "IntelFrameworkModulePkg/BdsDxe: Show boot timeout message" and it no >>> longer displays the countdown on the same line each time, it prints >>> each message on a new line. >>> >>> However, I don't see that as a blocking point, Daniil's patch could be >>> changed easily and there are other advantages to this series that make >>> it worthwhile, IMO, eg, Shell commands with lots of output (like >>> "help" or "dir fs0:") no longer create an awful mess on the serial >>> console. >>> >> >> So, is this just waiting for a maintainer's review? > > That's my understanding, yes. Feng or Star, could you please review these changes? Thanks, -- Brian J. Johnson -------------------------------------------------------------------- My statements are my own, are not authorized by SGI, and do not necessarily represent SGI’s positions.