From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.9013.1579517519907890371 for ; Mon, 20 Jan 2020 02:52:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gra8Yr7Q; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579517519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YOxJoNIiJEHDNbf4KxfQH7/ZoEzXvy+qE1oUpDBMnxI=; b=Gra8Yr7QNJTGRs1kKRWgH9eDdOdqBf8jYQuM0wu3dC6D/lcwhlctFeCJU8bbGJ2fPx7Pdn /T2al8S9yaDWyxTF+94jRox/5ZC4IGe1PdtXVBEhgywnhIMGu+JsX7c1OEyYaYPIqedSm3 CcAjYNYn029dSdoz7VyWUEqH0JtAVyo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-2kzu9HWbOguq2fMw68dsdg-1; Mon, 20 Jan 2020 05:51:51 -0500 Received: by mail-wm1-f71.google.com with SMTP id s25so2020487wmj.3 for ; Mon, 20 Jan 2020 02:51:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2+YWJo6chFrG0stJ+NC78N70Kxm7Wab6KcPuJuB+Xew=; b=r0/03m7JQYqYmNGC5lZ9I/sTQy6jnMVZAVZkmBMhxkGDSD94u4AkO2QFZhm93Oys/B FH+8RcdO8I4Mle4cPw7NyeHYPGhI4YQ/knkPVhXCUSql2lUqLFiYyG+6Oaj0rfw1h4n5 c8Ip4U3cMidnK0zqqFEkZxE3GVqjR1+zCKa1mDENSzKFs0s7NCzW9xZRkgaOKmtTKkSV lYyZIfLii8y/0woiLvaCUPAqINph1+4tZ8JuljVcSLPuZJEFHu4+pAJJmB15QhqEroq6 iFTjI6SI/m77br3AC4FOsqiK0KyR6kVl2RY26hlhzVdbQrU43wP1YSn60sWUEBDx+5qh ybCQ== X-Gm-Message-State: APjAAAVyODKMIgbv3bSrkFSh6S651jepB5mwB+pl4LwFA3OV7unXQdAo bmFx4kIQfYEKUoj5dv2xacAQQA1qzrL4RH6Ui74L6BIazRq9osR9UAW+DEhz9H4/klfyTUGKPNC SG5xa706wDjB9wA== X-Received: by 2002:a5d:62d0:: with SMTP id o16mr17489614wrv.197.1579517510322; Mon, 20 Jan 2020 02:51:50 -0800 (PST) X-Google-Smtp-Source: APXvYqy1AOTkr84H98yf4uoQSDjwdRKFZvqnn65esBuX1TTIB+GnFenUry7rizffb6YDUXmhAAnLoA== X-Received: by 2002:a5d:62d0:: with SMTP id o16mr17489580wrv.197.1579517509986; Mon, 20 Jan 2020 02:51:49 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id l15sm45108927wrv.39.2020.01.20.02.51.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2020 02:51:49 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length To: Laszlo Ersek , devel@edk2.groups.io, "Feng, Bob C" Cc: "Gao, Liming" , "Justen, Jordan L" , "Zhu, Yonghong" , "Gao, Zhichao" References: <20200102121656.29572-1-philmd@redhat.com> <08650203BA1BD64D8AD9B6D5D74A85D1615A09AE@SHSMSX104.ccr.corp.intel.com> <79341b5f-e604-4455-d812-4617ff403a72@redhat.com> <7ea32675-bd23-287c-8cfd-730c403c8f03@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <14ba8428-86fd-3588-7d77-b5b65213e6f3@redhat.com> Date: Mon, 20 Jan 2020 11:51:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <7ea32675-bd23-287c-8cfd-730c403c8f03@redhat.com> X-MC-Unique: 2kzu9HWbOguq2fMw68dsdg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 1/20/20 11:27 AM, Laszlo Ersek wrote: > On 01/20/20 10:11, Philippe Mathieu-Daud=C3=A9 wrote: >> Hi Liming, >> >> On 1/9/20 6:35 AM, Feng, Bob C wrote: >>> Reviewed-by: Bob Feng >> >> Is the Review-by tag from Bob enough to get this patch merged? >=20 > Yes, see the "M" role: >=20 > BaseTools > F: BaseTools/ > W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools > M: Bob Feng > M: Liming Gao >=20 > ... In fact, the patch has been committed as 2649a735b249e. >=20 > Unfortunately: >=20 > - your name has been messed up in the "Author" meta-datum :( Now I see it, OK. I don't understand charset encoding enough to avoid=20 mojibake, but I'll try few things with PatchCheck. > - we don't directly know who committed the patch, becaus "Committer" > only says "mergify[bot]" >=20 > Now, based on the subject and the commit date of the patch, I can find > some related notification emails in my "github.com email notifications" > folder. From those, the revelant (merged) GitHub PR seems to be: >=20 > https://github.com/tianocore/edk2/pull/283 Thanks Bob for pushing it, sorry for the noise. Thanks Laszlo for checking and updating me. > I agree it's annoying to not have confirmation on the mailing list, > directly in your patch's thread. The only thing I can recommend is, > check the git history periodically, for recently committed patches, > authored by yourself. >=20 > Personally, on the maintainer side, I always make sure to confirm a > merge on-list, separately. >=20 > Thanks > Laszlo >=20