public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Chao Zhang <chao.b.zhang@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 0/2] Fix typos in MdePkg and SecurityPkg
Date: Mon, 17 Dec 2018 11:08:58 +0100	[thread overview]
Message-ID: <14bbe8e4-3361-1150-ba3e-ee2ecd2ff53b@redhat.com> (raw)
In-Reply-To: <20181211013132.25028-1-shenglei.zhang@intel.com>

Hi,

On 12/11/18 2:31 AM, Shenglei Zhang wrote:
> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to
> EFI_RETURNING_FROM_EFI_APPLICATION.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Shenglei Zhang (2):
>   MdePkg/IndustryStandard: Fix a typo in UefiTcgPlatform.h
>   SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c
> 
>  MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 2 +-
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c                 | 4 ++--
>  SecurityPkg/Tcg/TcgDxe/TcgDxe.c                   | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 

NACK, this change has to be in the same patch to be bisectable.

However, if you resend the same change squashed in a single patch, you
can directly add my:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Regards,

Phil.


  parent reply	other threads:[~2018-12-17 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  1:31 [PATCH 0/2] Fix typos in MdePkg and SecurityPkg Shenglei Zhang
2018-12-11  1:31 ` [PATCH 1/2] MdePkg/IndustryStandard: Fix a typo in UefiTcgPlatform.h Shenglei Zhang
2018-12-11  1:31 ` [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c Shenglei Zhang
2018-12-17  3:32   ` Zhang, Chao B
2018-12-17 10:08 ` Philippe Mathieu-Daudé [this message]
2018-12-17 10:27   ` [PATCH 0/2] Fix typos in MdePkg and SecurityPkg Laszlo Ersek
2018-12-17 10:45     ` Philippe Mathieu-Daudé
2019-01-17 16:44 ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14bbe8e4-3361-1150-ba3e-ee2ecd2ff53b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox