Oops, please ignore my last mail... I mistakenly think this patch is about qemu mailmap. In edk2, I am ok for this patch. Reviewed-by: Yu-Chen Lin -- Best Regards, Yu-Chen Lin yuchenlin 於 2019-12-06 21:59 寫道: > > Hi, > > > > Cool, it is a good idea for mapping this. > > However, I have two mail address, named npes87184@gmail.com and yuchenlin@synology.com (mailto:yuchenlin@synology.com) > > > > IMO, the entry should be > > > > diff --git a/.mailmap b/.mailmap > > index 3816e4effe..3fbf3902a3 100644 > > --- a/.mailmap > > +++ b/.mailmap > > @@ -151,7 +151,8 @@ Xiaoqiang Zhao > > Xinhua Cao > > Xiong Zhang > > Yin Yin > > -yuchenlin > > +Yu-Chen Lin > > +Yu-Chen Lin > > YunQiang Su > > YunQiang Su > > Yuri Pudgorodskiy > > > > And the final output of `git shortlog -s -n -e | grep Yu-Chen` will be > > > > 12 Yu-Chen Lin > > > > It is correct! > > > > Thank you > > > -- > > Best Regards, > > Yu-Chen Lin > > > > > > Philippe Mathieu-Daude 於 2019-12-06 21:03 寫道: > > > > > > We use .mailmap to display contributors email addresses in an > > uniform format. > > > > Add an entry for Yu-Chen Lin to have his name and email address > > displayed properly in the git history. > > > > Cc: Yu-Chen Lin > > Signed-off-by: Philippe Mathieu-Daude > > --- > > [Due to MTA restricting the recipient list to 100, I can not Cc all the > > named developers in the cover. Therefore I'm adapting the explaination > > from the cover in each patch] > > > > This patch won't get merged if Yu-Chen Lin doesn't give his > > approval, by replying to this patch with: > > Reviewed-by: Yu-Chen Lin > > > > If you think this patch is inappropriate, you don't need to justify, > > reply with: > > NAcked-by: Yu-Chen Lin > > or simply: > > NACK > > > > If your Firstname Lastname order is incorrect, tell me and I will fix it. > > > > You can also ignore this mail, but I might resend it and keep bothering > > you. > > > > Regards, > > > > Phil. > > --- > > .mailmap | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.mailmap b/.mailmap > > index dc0e59705f6c..1e385f7591c2 100644 > > --- a/.mailmap > > +++ b/.mailmap > > @@ -196,3 +196,4 @@ Yeh Greg GregX Yeh > > Yingke Liu > > Yonghong Zhu > > Yonghong Zhu > > +Yu-Chen Lin > > -- > > 2.21.0 > > >