From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mx.groups.io with SMTP id smtpd.web08.713.1655936098779160905 for ; Wed, 22 Jun 2022 15:14:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PTo2oGfv; spf=pass (domain: gmail.com, ip: 209.85.210.179, mailfrom: taylor.d.beebe@gmail.com) Received: by mail-pf1-f179.google.com with SMTP id w6so10148767pfw.5 for ; Wed, 22 Jun 2022 15:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:reply-to:references:in-reply-to :content-transfer-encoding; bh=nsQpcBbKA0n8+jmemFTLCm8VuXE3v/F6IjbrTpTrYmU=; b=PTo2oGfvUpZBoiJm0hXwA+SzVu2znyvYSYCp07F8NH90qI+RBnnyRJS3sOL2604kNN CnLpOooQ/Idq2dvBgIhVA6G/FZ4QjAf2h7Nc9Iw9eDUHoYWndaCxRqApaMTVzHSJCzLr KaZV+8dtffRjysOUC+iqQvPkeoqKwskZ4it9cL40PSywGoX4T2KTYNYewTymZ0bsT3iY U7KYMLqhTxbhFt5Y0HEdtV+gTES4zez2sbu1+xFxkll2USSa3ul9nIBMpZteBSnz11bJ C17TTvbsz/MwBwutQJpIWEkICXkYraM2WxKgQvdEYqlGn7qTDSDrjnj05xRv/pYIf4Kk kQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:reply-to:references:in-reply-to :content-transfer-encoding; bh=nsQpcBbKA0n8+jmemFTLCm8VuXE3v/F6IjbrTpTrYmU=; b=ocnuiONtUfvbP4eKphFGsf+FZymQWtnMFCVem4YSzZZh+gQvnPqKe0DN5O4XR8ikvB j+NpalaPfQQT2Y52U8Bx5gmBc19BXfFbIur7I/vG8suYAVOo8GLiw5vA41rQbsXQHNkq FuMGM8ArxkehfM566cqGq9XfZQCClZtCqwFiRdyxb7w4AC+r6SF0U1N+cjChp+Q//Vw3 QA4X+0UfHBOJIeMK1gCN6xLnUG9+eV5ybIEzEtqap6N0NeRqPK5TTS7fRu6R63B9bzhU 7ayChEK5tS082oYuiyqVcwkaeshqMM3qe95k/ODNAXOvAA65xIqcKemKJ9vxXd+7/rwR Nq+g== X-Gm-Message-State: AJIora9Jy/EElloZbT3ISmxNZb3xZN+zUmX1ms1U9FcNLS/fUCSGvBZR tlKztMt31pB+4hBWRIzHAebGSwCIg1a3WA== X-Google-Smtp-Source: AGRyM1tkLnoESYSjdGI+jRFixUtLCcTCSEgUxMHe725Fhi771GgtORzayEOU/OvQiMXKOpQ/aNi2rg== X-Received: by 2002:a05:6a00:cd1:b0:525:4c0e:d0a3 with SMTP id b17-20020a056a000cd100b005254c0ed0a3mr3455880pfv.67.1655936098105; Wed, 22 Jun 2022 15:14:58 -0700 (PDT) Return-Path: Received: from [192.168.50.162] ([50.47.81.182]) by smtp.gmail.com with ESMTPSA id x15-20020a63b34f000000b0040d027e1f0fsm3677259pgt.25.2022.06.22.15.14.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 15:14:57 -0700 (PDT) Message-ID: <14e4aae2-9887-2892-b653-17feb2911a2f@gmail.com> Date: Wed, 22 Jun 2022 15:14:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [edk2-devel] [PATCH v1 0/1] Set RW and P Attributes on Split Page From: Taylor Beebe To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar Reply-To: devel@edk2.groups.io References: <20220615212307.1007-1-taylor.d.beebe@gmail.com> In-Reply-To: <20220615212307.1007-1-taylor.d.beebe@gmail.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Reminder to review On 6/15/2022 2:23 PM, Taylor Beebe wrote: > From: Taylor Beebe > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3869 > > A split page should always have the RW and P attributes set so the lowest level page frame > determines the access rights as detailed in 4.10.2.2 of the Intel 64 and IA-32 Architectures > Software Developer’s Manual. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > > Taylor Beebe (1): > UefiCpuPkg: CpuDxe: Set RW and P Attributes on Split Pages > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >