From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 05E58941068 for ; Fri, 13 Oct 2023 03:25:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kd6t2Sl6TRlM9IAPueHDX/8yTrhpX5qQ9v1MsdhOBao=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:From:To:CC:References:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697167509; v=1; b=dkJRe6cIXTGIJtpeZxLMjWkH5KfRNIpeGGF29CfxlsNesDel3L4uzeW+MFWw/snJX03cD2WP coXvfTWtwOKmRxALdOJ+4Srw0tVOhITthY6Yg+9OFhXk0fng5fSJAyd+jrtfwX9No9/pR6hrwuS h/Nn7L66z+XCgGISwMHK2nEs= X-Received: by 127.0.0.2 with SMTP id CqeCYY7687511xCaENn80LIb; Thu, 12 Oct 2023 20:25:09 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.109]) by mx.groups.io with SMTP id smtpd.web11.31144.1697167508457578265 for ; Thu, 12 Oct 2023 20:25:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NhXNuwwWcFE20H6BsYp7AyOXp3F6QlFiVpP/KjF+6yyClSsDAOWpOll8ZAS3LqnEqK5g9qjA9jch+21xWgKbHguqeWFekv1xQtJB2NrDWHLP9/gV565Vu18+tfleae7+Ul4KMYoDAaWJ2vAh9Sdc5gyxGfZ0ryJozexo7TrGjnMuNSB6cfSeMULcK6HwOuLQd+WZM/ZNFnhgEgdiIBLurIvtW1JVz0ca3W/F9sdrX2VVelU1MOwx4yaoa+2CgHiWKuZ+UsTRpKn0WU2oikU0FbnoV8wWQyfGW0nD9E1l0pU0g/sLTUzaW5bxzuGoOvn0ySFeoC9rI9/hkdJJhermnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1r9mg5AQQsbZm6L/vuN31s/x14sRXbCV7X3J4q/TyPY=; b=iWE+TTgwbfRicwmLb1qjrHuOaqWQOLD+bsD1QN1HWE+vsHHV5tcnYU03hng1bRo8Wt2+KMHyw+/q62upTZtjgou0ppgQB9WS0HyHyzJWvm/fKelfsJlrrlUcxzo0qihjSwA64495qzWbObSXmyZlf5JlBP8XyETnIB4DfZ/9o9bmqdsQ+FOZ26QSnZfRU4TdpO6gLDwbMBCpvTzXYY2pwlnha5y/hMhE7E/8OKoru2qnW4uLXybb4iqmtGzTss4OI1rfkGhJ0l3DuECdL06CRz7/cBLRTyggy3SRMSV/JulSAULDyTcgXwzgOYctHNyxADFE1sdC4aiyg4n7wl0l2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BL3PR01MB7178.prod.exchangelabs.com (2603:10b6:208:345::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Fri, 13 Oct 2023 03:25:04 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7%6]) with mapi id 15.20.6863.043; Fri, 13 Oct 2023 03:25:04 +0000 Message-ID: <14fb38d6-5a58-4eca-83af-ed9a5d453298@os.amperecomputing.com> Date: Fri, 13 Oct 2023 10:24:53 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error From: "Nhi Pham via groups.io" To: Laszlo Ersek , edk2-devel-groups-io CC: Chuong Tran , Leif Lindholm , Rebecca Cran References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> <20231012090950.108577-13-lersek@redhat.com> <0c983e60-e094-d1b1-fb20-aecd533a822e@os.amperecomputing.com> In-Reply-To: <0c983e60-e094-d1b1-fb20-aecd533a822e@os.amperecomputing.com> X-ClientProxiedBy: SI2PR06CA0005.apcprd06.prod.outlook.com (2603:1096:4:186::12) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|BL3PR01MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f4b7a3e-1d92-4b79-d95c-08dbcb9bfda0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: ZWhB4Dxj2U9+xWBDqIF33lU96cLYxtAN8NEgGDg0p4dl7L9mdGHfesG9UFIb5/gnczNW2ms+Znd9C/eHN3VhDU2qE4rT4Qb15oav7iVc1emt2gRrtKSm2/kztI4fwbRxDQFqd94B/kVJG3XjuG3iR3zvRv87JGBfsNlIOIgPeo8F1Yq4yyFji7Irq3sSo+5Kg/5kA9Sd2BPwaRpMJXrkqMuO7zLt1TVNu8VdxUmlYrlwLLtkN5rl4KWovUuuXZjAfxcS0iz9A7HVo8kmN+OOILUPFzOgojpPaQEkmEAHam383jzoHnAJUmBtIHu5kLbIvKIANWzy3mIg9dTK6wGau5m8BaJ1uPTpKBf8C4xrs3y5Q1tA/YNWP2dJNioUwd8XfUnZJhSXj7y2TN9xihZ3ljiBNJarano9mOBSoUjgSaauZFvuT3Z3M4T27ywJrPINUEhy78S1A3tgSaLHzJZyuB3EsB7RatVYLrFSq/BcvLaWb3TgDM+UdU3Rn3ZSAbaYU37MRmn/qX7I4vuIemEewn1Akb977PHWYBT19lP+x4kaFzxUoJQRQZFYxve+ItA27/5TaOTcpEDayNXtL1wnJMs242hBIAyRE8LbZ9C+yk8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4Y7BVQWLFLVGQIy9xjv3wz4aRlaqig+f55qgcfAEieKHpxzXishuiVUJzFQ+?= =?us-ascii?Q?PvypuVO0OSV4ddtdAMmBCTwgG+FFOF4uc4bGXi75kRSmHr7DJY3/AH/6cniP?= =?us-ascii?Q?Vn0jFYTpLm5ekWZ6TbwMxiFD+am7kT5zMPZod+WCjI5WEC6nDp1tTzTykIDw?= =?us-ascii?Q?BDNQI6CIO7OEseO44ZGnmqsMyAPvM3nR7FJw1R1JmgkH5Zj2K06UnyEtjWlj?= =?us-ascii?Q?91WSP0EAmMkxlQ8556ojliPVNj5PhUMv8v9V+nsP9aswt48z9xyxUy8t6o5F?= =?us-ascii?Q?6cr6Ld9DF0StgM8wLiVloIrZHycszz6jcdUrL2T366E8rDwzWiINahE8B7Qz?= =?us-ascii?Q?uoEsKkph1xHA/xtNwHxXjLm7P8esym7bQlD+MxZbnWPqZa4FYA826WOJ2R5Q?= =?us-ascii?Q?pnP9F3k2vEAbGuqR4kbnPP3/eCM/0jB0rFaqEsxDs9H6QXtDCC5V9VdcMqSD?= =?us-ascii?Q?nTgeQvBzXiBqFj2A6qBU5A/Rpeh26eajqhljn4Vfg/TV99deIT1AEDuFgOgv?= =?us-ascii?Q?HL1YLmNkTn/OHsMnWyQYo13DOrlcOgCvCT6E6JY9nPKNONfvoaolOJMYjZUf?= =?us-ascii?Q?UMcObE+T2BrmOGrsUvgZoRQB8okSbyKTg6RGGUkb9SEgllTW5ptWxwdImxhf?= =?us-ascii?Q?XXPY4OMaILZYUtA9MKMBatKuLE1qwAIUbr+roW3gbFybVya2HRfE3qfQcuAO?= =?us-ascii?Q?a9YZkIxiWV6OjqfT0RyBi8e1WdNPLBsD7g0brE82SglkdNP8h213bdJdm3kU?= =?us-ascii?Q?LsclL15E32eCOF5cCfjHfzEpjWgUxk+7SBxTOuOoDBz3j/aWQdFM4WPfK449?= =?us-ascii?Q?M89E9qSY65yuzHUAWEqZKCjptTWfpsQ512+FhwfR/X4xjm4OrVmGc7f/GI+N?= =?us-ascii?Q?qZEnTebrLNOh0P9UUS55FJoN/aIWWDBXRnoJglZ1L4skSCwfRG7UWxCDseJ5?= =?us-ascii?Q?oF0JmTvNKCCwdBEyZoex2JbC9BkrwzWU1PkKC2QHUCpdRmXKxjWgjBxf+PrU?= =?us-ascii?Q?LJ30FmIHGbZquwAktSVPTv5FkUZJHdjPiYfX8MVbjF14otMf6vVQ00HbFy0e?= =?us-ascii?Q?cJtbCSzUkpyCY+OqelC9T8bxW/ZV7bu7pzp4k2F71ok/o3N6GgWlnJO9P238?= =?us-ascii?Q?kyDzKLuistxCjyvNsnu34epvboeCe3qeVN37Vv5WEEpcoOoT54NmyzpLhzgk?= =?us-ascii?Q?i8clowW2jk8dyc5foyarC13p7vVk+xwDIrTxlvkMJ+RNA2ZCws9IpOAq+6f9?= =?us-ascii?Q?hc1W/9u+B5kqIcgOeNnxIFgeX4Dd6e674H/bH4dLPFnvek/6TtV3s9a+Q5vW?= =?us-ascii?Q?oTptXLG7zTiVYFCIINMAGikjKAHTTKNyY5gviGG/K42evcj9w9VtAoFMoSKp?= =?us-ascii?Q?wBGGUGpjVuoycsHwUxpVP4xGhKYPYMWbhnz1nf0JshqUKJKJBdcOVVuWSrCN?= =?us-ascii?Q?/Z8poOpfEGhfENTlIQaY3GosOa3GtEVHbuQLyILBUy2UJXTGasIdHco0cp2f?= =?us-ascii?Q?i5ZSbrFp9IgsCju5eUHz/GQ39rR1SyyfxEEXbL3/dCzrTFLSip3a4sQb+kow?= =?us-ascii?Q?oMiudYwc9rRZAuXC0Hq9PIVjNVloQJXwlIBmlsGHhO4KM5Q/8PZUnmVhNXk6?= =?us-ascii?Q?WYDHD+Au2BBPKQMfhEzQXtw=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4b7a3e-1d92-4b79-d95c-08dbcb9bfda0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 03:25:03.9614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2KI06UnUTcO2BAU54H2qXR1pXcmZMhFI5dhAOIz12yzDuTfV8Y+zW7hSur1C0I+EA3Ab2xGaMvhia2UcDTJdrW2w3dI+vvcLNGGzPzKPOW0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB7178 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xnOEcfwALoPpA7qjXqtg24xwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dkJRe6cI; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io HI Lazslo, I was not reviewing carefully. The MmioRead32 is redundant code. Can you=20 help me get rid of that code? Thanks, Nhi On 10/13/2023 9:20 AM, Nhi Pham wrote: > Thanks for fixing it. >=20 > Reviewed-by: Nhi Pham >=20 > Regards, > Nhi >=20 > On 10/12/2023 4:09 PM, Laszlo Ersek wrote: >> Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform=20 >> PCIe >> core", 2023-03-29) removed the DEBUG macro call from >> Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then, >> Val has only been set, but never read. This triggers >> "-Werror=3Dunused-but-set-variable". >> >> Found when trying to build "Jade.dsc". >> >> Keep the MmioRead32() call, so that the PCIe config space sees the same >> behavior as before, but explicitly throw away the result. >> >> Cc: Chuong Tran >> Cc: Leif Lindholm >> Cc: Nhi Pham >> Cc: Rebecca Cran >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 >> Signed-off-by: Laszlo Ersek >> --- >> =C2=A0 Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 = +-- >> =C2=A0 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git=20 >> a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c=20 >> b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c >> index 3c1fe5e35ca2..fa00c1e36999 100644 >> --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c >> +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c >> @@ -1747,7 +1747,6 @@ Ac01PcieCoreUpdateLink ( >> =C2=A0=C2=A0=C2=A0 PHYSICAL_ADDRESS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 CfgBase; >> =C2=A0=C2=A0=C2=A0 UINT8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Pc= ieIndex; >> =C2=A0=C2=A0=C2=A0 UINT32=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Index= ; >> -=C2=A0 UINT32=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Val; >> =C2=A0=C2=A0=C2=A0 *IsNextRoundNeeded =3D FALSE; >> =C2=A0=C2=A0=C2=A0 *FailedPcieCount=C2=A0=C2=A0 =3D 0; >> @@ -1767,7 +1766,7 @@ Ac01PcieCoreUpdateLink ( >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (Pcie->Active && !Pcie->LinkUp) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (PcieLinkUpCheck (Pcie)) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Pcie->LinkUp =3D = TRUE; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Val =3D MmioRead32 (CfgBase = + PCIE_CAPABILITY_BASE +=20 >> LINK_CONTROL_LINK_STATUS_REG); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (VOID)MmioRead32 (CfgBase + = PCIE_CAPABILITY_BASE +=20 >> LINK_CONTROL_LINK_STATUS_REG); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // Doing link che= cking and recovery if needed >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Ac01PcieCoreQoSLi= nkCheckRecovery (RootComplex, PcieIndex); >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109581): https://edk2.groups.io/g/devel/message/109581 Mute This Topic: https://groups.io/mt/101914660/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-