From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C23E2095D8D3 for ; Tue, 18 Jul 2017 09:11:00 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 09:12:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="126526948" Received: from unknown (HELO localhost) ([10.254.183.174]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2017 09:12:52 -0700 MIME-Version: 1.0 To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Message-ID: <150039437240.2449.15892869732817184679@jljusten-skl> From: Jordan Justen In-Reply-To: Cc: Leif Lindholm , Andrew Fish , "Gao, Liming" References: <20170717212829.36548-1-michael.d.kinney@intel.com> <20170717212829.36548-2-michael.d.kinney@intel.com> <150032961440.22153.12979783199124767709@jljusten-skl> User-Agent: alot/0.5.1 Date: Tue, 18 Jul 2017 09:12:52 -0700 Subject: Re: [Patch 1/2] BaseTools/PatchCheck: Support Contribution Agreement 1.1 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 16:11:00 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-07-18 08:59:46, Kinney, Michael D wrote: > Hi Jordan, > = > I can update the logic. The loop of supported > version values looks good. > = > One of the reasons I choose the style I did is that = > this patch is intended to be short lived. I would > like to see everyone transition to the new agreement > in their commit messages. I know there are patches = > in progress, so we need a period of time where both > are supported. I a month or two, I would like to = > require the 1.1 agreement in the commit messages. > = > Adding flexibility in the compare did not make much > sense if we are going to use one most of the time. Oh. Good point. What about something like: def check_contributed_under(self): cu_msg=3D'Contributed-under: TianoCore Contribution Agreement 1.1' if self.msg.find(cu_msg) < 0: # Allow 1.0 for now while EDK II community transitions to 1.1 cu_msg=3D'Contributed-under: TianoCore Contribution Agreement 1= .0' if self.msg.find(cu_msg) < 0: self.error('Missing Contributed-under! (Note: this must be = ' + 'added by the code contributor!)') And, maybe we could mention in the commit message that allowing 1.0 is temporary? With that: Reviewed-by: Jordan Justen