public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jordan Justen <jordan.l.justen@intel.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,  edk2-devel@lists.01.org
Cc: Leif Lindholm <leif.lindholm@linaro.org>, Andrew Fish <afish@apple.com>
Subject: Re: [Patch 4/6] edk2: Remove commit message details from Contributions.txt
Date: Tue, 18 Jul 2017 16:40:36 -0700	[thread overview]
Message-ID: <150042123598.7417.658078738092802916@jljusten-skl> (raw)
In-Reply-To: <20170718211701.37196-5-michael.d.kinney@intel.com>

On 2017-07-18 14:16:59, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=629
> 
> Remove the change description, commit message, and
> patch email section from Contributions.txt.  This
> section is not part of the TianoCore Contribution
> Agreement.  The information is very important and is
> provided on the TianoCore web site and wiki and will
> be added to Readme.md in the root of the edk2
> repository.

I don't think this should be removed. If the readme is added at a
later time, then perhaps we could consider moving it.

This information is specifically about contributing to the EDK II
project, so why isn't Contributions.txt a better place than a generic
readme?

Some parts of this are closely tied to the contribution agreement
process. For example, the text: '"Signed-off-by" is the contributor's
signature identifying them by their real/legal name and their email
address.' It seems better to have this nearby the contribution
agreement text.

-Jordan

> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Contributions.txt | 49 -------------------------------------------------
>  1 file changed, 49 deletions(-)
> 
> diff --git a/Contributions.txt b/Contributions.txt
> index f87cbd73c6..06c60d8e17 100644
> --- a/Contributions.txt
> +++ b/Contributions.txt
> @@ -34,55 +34,6 @@ To make a contribution to a TianoCore project, follow these steps.
>     Contributions using other licenses might be accepted, but further
>     review will be required.
>  
> -=====================================================
> -= Change Description / Commit Message / Patch Email =
> -=====================================================
> -
> -Your change description should use the standard format for a
> -commit message, and must include your "Signed-off-by" signature
> -and the "Contributed-under" message.
> -
> -== Sample Change Description / Commit Message =
> -
> -=== Start of sample patch email message ===
> -
> -From: Contributor Name <contributor@example.com>
> -Subject: [PATCH] CodeModule: Brief-single-line-summary
> -
> -Full-commit-message
> -
> -Contributed-under: TianoCore Contribution Agreement 1.0
> -Signed-off-by: Contributor Name <contributor@example.com>
> ----
> -
> -An extra message for the patch email which will not be considered part
> -of the commit message can be added here.
> -
> -Patch content inline or attached
> -
> -=== End of sample patch email message ===
> -
> -=== Notes for sample patch email ===
> -
> -* The first line of commit message is taken from the email's subject
> -  line following [PATCH]. The remaining portion of the commit message
> -  is the email's content until the '---' line.
> -* git format-patch is one way to create this format
> -
> -=== Definitions for sample patch email ===
> -
> -* "CodeModule" is a short idenfier for the affected code.  For
> -  example MdePkg, or MdeModulePkg UsbBusDxe.
> -* "Brief-single-line-summary" is a short summary of the change.
> -* The entire first line should be less than ~70 characters.
> -* "Full-commit-message" a verbose multiple line comment describing
> -  the change.  Each line should be less than ~70 characters.
> -* "Contributed-under" explicitely states that the contribution is
> -  made under the terms of the contribtion agreement.  This
> -  agreement is included below in this document.
> -* "Signed-off-by" is the contributor's signature identifying them
> -  by their real/legal name and their email address.
> -
>  ========================================
>  = TianoCore Contribution Agreement 1.0 =
>  ========================================
> -- 
> 2.13.1.windows.2
> 


  reply	other threads:[~2017-07-18 23:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 21:16 [Patch 0/6] Update to Tiano Contribution Agreement 1.1 Michael D Kinney
2017-07-18 21:16 ` [Patch 1/6] BaseTools/PatchCheck: Support " Michael D Kinney
2017-07-18 21:16 ` [Patch 2/6] edk2: Move Tiano Contribution Agreement to root Michael D Kinney
2017-07-18 21:16 ` [Patch 3/6] edk2: Remove Tiano Contribution Agreement from packages Michael D Kinney
2017-07-18 22:47   ` Jordan Justen
2017-07-19 15:50     ` Kinney, Michael D
2017-07-18 21:16 ` [Patch 4/6] edk2: Remove commit message details from Contributions.txt Michael D Kinney
2017-07-18 23:40   ` Jordan Justen [this message]
2017-07-19 15:54     ` Kinney, Michael D
2017-07-19 17:39       ` Jordan Justen
2017-07-18 21:17 ` [Patch 5/6] edk2: Update to TianoCore Contribution Agreement 1.1 Michael D Kinney
2017-07-18 23:50   ` Jordan Justen
2017-07-19 17:35     ` Kinney, Michael D
2017-07-18 21:17 ` [Patch 6/6] edk2: Reformat " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150042123598.7417.658078738092802916@jljusten-skl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox