public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 0/2] Update comments to follow spec update.
@ 2017-07-19  2:37 Eric Dong
  2017-07-19  2:37 ` [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec Eric Dong
  2017-07-19  2:37 ` [Patch 2/2] MdeModulePkg SmmAccess: " Eric Dong
  0 siblings, 2 replies; 5+ messages in thread
From: Eric Dong @ 2017-07-19  2:37 UTC (permalink / raw)
  To: edk2-devel

This patches series used to update comments to follow spec update.

Eric Dong (2):
  MdePkg SmmAccess2: Update comments to follow PI spec.
  MdeModulePkg SmmAccess: Update comments to follow PI spec.

 MdeModulePkg/Include/Ppi/SmmAccess.h | 5 +++--
 MdePkg/Include/Protocol/SmmAccess2.h | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

-- 
2.7.0.windows.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec.
  2017-07-19  2:37 [Patch 0/2] Update comments to follow spec update Eric Dong
@ 2017-07-19  2:37 ` Eric Dong
  2017-07-19  2:59   ` Ni, Ruiyu
  2017-07-19  2:37 ` [Patch 2/2] MdeModulePkg SmmAccess: " Eric Dong
  1 sibling, 1 reply; 5+ messages in thread
From: Eric Dong @ 2017-07-19  2:37 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jeff Fan, Ruiyu Ni

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 MdePkg/Include/Protocol/SmmAccess2.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Protocol/SmmAccess2.h b/MdePkg/Include/Protocol/SmmAccess2.h
index eb315db..5904266 100644
--- a/MdePkg/Include/Protocol/SmmAccess2.h
+++ b/MdePkg/Include/Protocol/SmmAccess2.h
@@ -108,8 +108,9 @@ EFI_STATUS
 
 ///
 ///  EFI SMM Access2 Protocol is used to control the visibility of the SMRAM on the platform.
-///  It abstracts the location and characteristics of SMRAM.  The expectation is
-///  that the north bridge or memory controller would publish this protocol.
+///  It abstracts the location and characteristics of SMRAM. The platform should report all 
+///  MMRAM via EFI_MM_ACCESS_PROTOCOL. The expectation is that the north bridge or memory 
+///  controller would publish this protocol.
 /// 
 struct _EFI_SMM_ACCESS2_PROTOCOL {
   EFI_SMM_OPEN2          Open;
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Patch 2/2] MdeModulePkg SmmAccess: Update comments to follow PI spec.
  2017-07-19  2:37 [Patch 0/2] Update comments to follow spec update Eric Dong
  2017-07-19  2:37 ` [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec Eric Dong
@ 2017-07-19  2:37 ` Eric Dong
  2017-07-19  2:59   ` Ni, Ruiyu
  1 sibling, 1 reply; 5+ messages in thread
From: Eric Dong @ 2017-07-19  2:37 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jeff Fan, Ruiyu Ni

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Include/Ppi/SmmAccess.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Include/Ppi/SmmAccess.h b/MdeModulePkg/Include/Ppi/SmmAccess.h
index 085ad64..d91374e 100644
--- a/MdeModulePkg/Include/Ppi/SmmAccess.h
+++ b/MdeModulePkg/Include/Ppi/SmmAccess.h
@@ -128,8 +128,9 @@ EFI_STATUS
 
 ///
 ///  EFI SMM Access PPI is used to control the visibility of the SMRAM on the platform.
-///  It abstracts the location and characteristics of SMRAM.  The expectation is
-///  that the north bridge or memory controller would publish this PPI.
+///  It abstracts the location and characteristics of SMRAM. The platform should report 
+///  all MMRAM via PEI_SMM_ACCESS_PPI. The expectation is that the north bridge or 
+///  memory controller would publish this PPI.
 /// 
 struct _PEI_SMM_ACCESS_PPI {
   PEI_SMM_OPEN          Open;
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Patch 2/2] MdeModulePkg SmmAccess: Update comments to follow PI spec.
  2017-07-19  2:37 ` [Patch 2/2] MdeModulePkg SmmAccess: " Eric Dong
@ 2017-07-19  2:59   ` Ni, Ruiyu
  0 siblings, 0 replies; 5+ messages in thread
From: Ni, Ruiyu @ 2017-07-19  2:59 UTC (permalink / raw)
  To: Dong, Eric, edk2-devel@lists.01.org; +Cc: Fan, Jeff

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Dong, Eric
> Sent: Wednesday, July 19, 2017 10:38 AM
> To: edk2-devel@lists.01.org
> Cc: Fan, Jeff <jeff.fan@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch 2/2] MdeModulePkg SmmAccess: Update comments to
> follow PI spec.
> 
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  MdeModulePkg/Include/Ppi/SmmAccess.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Ppi/SmmAccess.h
> b/MdeModulePkg/Include/Ppi/SmmAccess.h
> index 085ad64..d91374e 100644
> --- a/MdeModulePkg/Include/Ppi/SmmAccess.h
> +++ b/MdeModulePkg/Include/Ppi/SmmAccess.h
> @@ -128,8 +128,9 @@ EFI_STATUS
> 
>  ///
>  ///  EFI SMM Access PPI is used to control the visibility of the SMRAM on the
> platform.
> -///  It abstracts the location and characteristics of SMRAM.  The expectation
> is
> -///  that the north bridge or memory controller would publish this PPI.
> +///  It abstracts the location and characteristics of SMRAM. The platform
> should report
> +///  all MMRAM via PEI_SMM_ACCESS_PPI. The expectation is that the
> north bridge or
> +///  memory controller would publish this PPI.
>  ///
>  struct _PEI_SMM_ACCESS_PPI {
>    PEI_SMM_OPEN          Open;
> --
> 2.7.0.windows.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec.
  2017-07-19  2:37 ` [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec Eric Dong
@ 2017-07-19  2:59   ` Ni, Ruiyu
  0 siblings, 0 replies; 5+ messages in thread
From: Ni, Ruiyu @ 2017-07-19  2:59 UTC (permalink / raw)
  To: Dong, Eric, edk2-devel@lists.01.org; +Cc: Fan, Jeff

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Wednesday, July 19, 2017 10:38 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Fan, Jeff <jeff.fan@intel.com>
> Subject: [edk2] [Patch 1/2] MdePkg SmmAccess2: Update comments to
> follow PI spec.
> 
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  MdePkg/Include/Protocol/SmmAccess2.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/SmmAccess2.h
> b/MdePkg/Include/Protocol/SmmAccess2.h
> index eb315db..5904266 100644
> --- a/MdePkg/Include/Protocol/SmmAccess2.h
> +++ b/MdePkg/Include/Protocol/SmmAccess2.h
> @@ -108,8 +108,9 @@ EFI_STATUS
> 
>  ///
>  ///  EFI SMM Access2 Protocol is used to control the visibility of the SMRAM
> on the platform.
> -///  It abstracts the location and characteristics of SMRAM.  The expectation
> is
> -///  that the north bridge or memory controller would publish this protocol.
> +///  It abstracts the location and characteristics of SMRAM. The platform
> should report all
> +///  MMRAM via EFI_MM_ACCESS_PROTOCOL. The expectation is that the
> north bridge or memory
> +///  controller would publish this protocol.
>  ///
>  struct _EFI_SMM_ACCESS2_PROTOCOL {
>    EFI_SMM_OPEN2          Open;
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-07-19  2:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19  2:37 [Patch 0/2] Update comments to follow spec update Eric Dong
2017-07-19  2:37 ` [Patch 1/2] MdePkg SmmAccess2: Update comments to follow PI spec Eric Dong
2017-07-19  2:59   ` Ni, Ruiyu
2017-07-19  2:37 ` [Patch 2/2] MdeModulePkg SmmAccess: " Eric Dong
2017-07-19  2:59   ` Ni, Ruiyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox