From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CDFE42095D9D0 for ; Fri, 21 Jul 2017 14:14:57 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 21 Jul 2017 14:16:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,392,1496127600"; d="scan'208";a="127903307" Received: from slsmallm-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.190.217]) by orsmga005.jf.intel.com with ESMTP; 21 Jul 2017 14:16:54 -0700 MIME-Version: 1.0 To: Michael D Kinney , edk2-devel@lists.01.org Message-ID: <150067181439.20068.8395013529501693336@jljusten-skl> From: Jordan Justen In-Reply-To: <20170720054411.18928-4-michael.d.kinney@intel.com> Cc: Andrew Fish , Leif Lindholm References: <20170720054411.18928-1-michael.d.kinney@intel.com> <20170720054411.18928-4-michael.d.kinney@intel.com> User-Agent: alot/0.5.1 Date: Fri, 21 Jul 2017 14:16:54 -0700 Subject: Re: [Patch V3 3/8] edk2: Remove commit message details from Contributions.txt X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2017 21:14:58 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-07-19 22:44:06, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D629 > = > Remove the change description, commit message, and > patch email section from Contributions.txt. This > section is not part of the TianoCore Contribution > Agreement. Neither are the ~35 remaining lines before this content, which you are not removing. > The information is very important and is > provided on the TianoCore web site and wiki and will > be added to Readme.md in the root of the edk2 > repository. Yes. It is important for making contributions, as is the ~35 lines before the agreement that you didn't remove. So, why don't we just keep them in Contributions.txt since they document how to make a contribution? If you want a single file that only has the contribution agreement text, then how about moving it to a ContributionAgreement.txt file, and making Contributions.txt refer to it? I'm not sure why this would be needed though. -Jordan > = > Cc: Leif Lindholm > Cc: Andrew Fish > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney > --- > Contributions.txt | 49 ------------------------------------------------- > 1 file changed, 49 deletions(-) > = > diff --git a/Contributions.txt b/Contributions.txt > index f87cbd73c6..06c60d8e17 100644 > --- a/Contributions.txt > +++ b/Contributions.txt > @@ -34,55 +34,6 @@ To make a contribution to a TianoCore project, follow = these steps. > Contributions using other licenses might be accepted, but further > review will be required. > = > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > -=3D Change Description / Commit Message / Patch Email =3D > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > - > -Your change description should use the standard format for a > -commit message, and must include your "Signed-off-by" signature > -and the "Contributed-under" message. > - > -=3D=3D Sample Change Description / Commit Message =3D > - > -=3D=3D=3D Start of sample patch email message =3D=3D=3D > - > -From: Contributor Name > -Subject: [PATCH] CodeModule: Brief-single-line-summary > - > -Full-commit-message > - > -Contributed-under: TianoCore Contribution Agreement 1.0 > -Signed-off-by: Contributor Name > ---- > - > -An extra message for the patch email which will not be considered part > -of the commit message can be added here. > - > -Patch content inline or attached > - > -=3D=3D=3D End of sample patch email message =3D=3D=3D > - > -=3D=3D=3D Notes for sample patch email =3D=3D=3D > - > -* The first line of commit message is taken from the email's subject > - line following [PATCH]. The remaining portion of the commit message > - is the email's content until the '---' line. > -* git format-patch is one way to create this format > - > -=3D=3D=3D Definitions for sample patch email =3D=3D=3D > - > -* "CodeModule" is a short idenfier for the affected code. For > - example MdePkg, or MdeModulePkg UsbBusDxe. > -* "Brief-single-line-summary" is a short summary of the change. > -* The entire first line should be less than ~70 characters. > -* "Full-commit-message" a verbose multiple line comment describing > - the change. Each line should be less than ~70 characters. > -* "Contributed-under" explicitely states that the contribution is > - made under the terms of the contribtion agreement. This > - agreement is included below in this document. > -* "Signed-off-by" is the contributor's signature identifying them > - by their real/legal name and their email address. > - > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D TianoCore Contribution Agreement 1.0 =3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -- = > 2.13.1.windows.2 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel