From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F4C32193B804 for ; Mon, 24 Jul 2017 01:23:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E00F7C01F263; Mon, 24 Jul 2017 08:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E00F7C01F263 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E00F7C01F263 Received: from sirius.home.kraxel.org (ovpn-116-225.ams2.redhat.com [10.36.116.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81D3D7E569; Mon, 24 Jul 2017 08:25:04 +0000 (UTC) Received: from localhost (localhost [IPv6:::1]) by sirius.home.kraxel.org (Postfix) with ESMTP id 0391E16E04; Mon, 24 Jul 2017 10:25:02 +0200 (CEST) Message-ID: <1500884701.15837.1.camel@redhat.com> From: Gerd Hoffmann To: "Michael S. Tsirkin" , Brijesh Singh Cc: Jason Wang , edk2-devel@lists.01.org, Tom Lendacky , Jordan Justen , Laszlo Ersek , David Airlie , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Date: Mon, 24 Jul 2017 10:25:01 +0200 In-Reply-To: <20170722024318-mutt-send-email-mst@kernel.org> References: <1500502151-13508-1-git-send-email-brijesh.singh@amd.com> <62320c1a-0cec-947c-8c63-5eb0416e4e33@redhat.com> <25d78a89-59bd-157a-ccf5-70cd25e14a05@amd.com> <20170722024318-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 24 Jul 2017 08:25:08 +0000 (UTC) Subject: Re: [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2017 08:23:08 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi, > > I see that OVMF has the following virtio drivers, we need to update > > them > > all: > > > > VirtioBlkDxe > > VirtioGpuDxe > > VirtioNetDxe > > VirtioRngDxe > > VirtioScsiDxe > > > > I will wait for Laszlo and Jordan's initial feedback before > > changing > > other drivers. > > I'm not sure about the GPU. Cc relevant maintainers - > can virtio GPU work from behind an IOMMU? GPU uses main memory as backing storage for framebuffers, and this is passed as guest physical address (scatterlist of addresses to be exact) to the host. So, I think no, this isn't going to work with the current code. Should be possible to fix though. We need to define what "guest physical address" should be with VIRTIO_F_IOMMU_PLATFORM enabled (probably guest pci bus address) and add support for proper iommu lookups. cheers, Gerd