public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 0/2] Refine the coding style.
@ 2017-07-25 12:41 Jiaxin Wu
  2017-07-25 12:41 ` [Patch 1/2] MdePkg/Http.h: " Jiaxin Wu
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-07-25 12:41 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdePkg/Http.h: Refine the coding style.
  NetworkPkg/HttpDxe: Refine the coding style.

 MdePkg/Include/Protocol/Http.h | 8 ++++----
 NetworkPkg/HttpDxe/HttpImpl.c  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Patch 1/2] MdePkg/Http.h: Refine the coding style.
  2017-07-25 12:41 [Patch 0/2] Refine the coding style Jiaxin Wu
@ 2017-07-25 12:41 ` Jiaxin Wu
  2017-07-25 12:41 ` [Patch 2/2] NetworkPkg/HttpDxe: " Jiaxin Wu
  2017-07-26  2:05 ` [Patch 0/2] " Fu, Siyuan
  2 siblings, 0 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-07-25 12:41 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdePkg/Include/Protocol/Http.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/MdePkg/Include/Protocol/Http.h b/MdePkg/Include/Protocol/Http.h
index f7a9aa6..8ac16ec 100644
--- a/MdePkg/Include/Protocol/Http.h
+++ b/MdePkg/Include/Protocol/Http.h
@@ -2,11 +2,11 @@
   This file defines the EFI HTTP Protocol interface. It is split into
   the following two main sections:
   HTTP Service Binding Protocol (HTTPSB)
   HTTP Protocol (HTTP)
 
-  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution. The full text of the license may be found at
   http://opensource.org/licenses/bsd-license.php
@@ -316,11 +316,11 @@ typedef struct {
                                   HttpConfigData->IPv6Node is NULL.
   @retval EFI_NOT_STARTED         This EFI HTTP Protocol instance has not been started.
 **/
 typedef
 EFI_STATUS
-(EFIAPI * EFI_HTTP_GET_MODE_DATA)(
+(EFIAPI *EFI_HTTP_GET_MODE_DATA)(
   IN  EFI_HTTP_PROTOCOL         *This,
   OUT EFI_HTTP_CONFIG_DATA      *HttpConfigData
   );
 
 /**
@@ -354,13 +354,13 @@ EFI_STATUS
   @retval EFI_UNSUPPORTED         One or more options in ConfigData are not supported
                                   in the implementation.
 **/
 typedef
 EFI_STATUS
-(EFIAPI * EFI_HTTP_CONFIGURE)(
+(EFIAPI *EFI_HTTP_CONFIGURE)(
   IN  EFI_HTTP_PROTOCOL         *This,
-  IN  EFI_HTTP_CONFIG_DATA      *HttpConfigData
+  IN  EFI_HTTP_CONFIG_DATA      *HttpConfigData OPTIONAL
   );
 
 /**
   The Request() function queues an HTTP request to this HTTP instance, 
   similar to Transmit() function in the EFI TCP driver. When the HTTP request is sent
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Patch 2/2] NetworkPkg/HttpDxe: Refine the coding style.
  2017-07-25 12:41 [Patch 0/2] Refine the coding style Jiaxin Wu
  2017-07-25 12:41 ` [Patch 1/2] MdePkg/Http.h: " Jiaxin Wu
@ 2017-07-25 12:41 ` Jiaxin Wu
  2017-07-26  2:05 ` [Patch 0/2] " Fu, Siyuan
  2 siblings, 0 replies; 4+ messages in thread
From: Jiaxin Wu @ 2017-07-25 12:41 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/HttpDxe/HttpImpl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c
index 1f7a4fa..c9ad59b 100644
--- a/NetworkPkg/HttpDxe/HttpImpl.c
+++ b/NetworkPkg/HttpDxe/HttpImpl.c
@@ -128,11 +128,11 @@ EfiHttpGetModeData (
 **/
 EFI_STATUS
 EFIAPI
 EfiHttpConfigure (
   IN  EFI_HTTP_PROTOCOL         *This,
-  IN  EFI_HTTP_CONFIG_DATA      *HttpConfigData
+  IN  EFI_HTTP_CONFIG_DATA      *HttpConfigData OPTIONAL
   ) 
 {
   HTTP_PROTOCOL                 *HttpInstance;
   EFI_STATUS                    Status;
   
-- 
1.9.5.msysgit.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch 0/2] Refine the coding style.
  2017-07-25 12:41 [Patch 0/2] Refine the coding style Jiaxin Wu
  2017-07-25 12:41 ` [Patch 1/2] MdePkg/Http.h: " Jiaxin Wu
  2017-07-25 12:41 ` [Patch 2/2] NetworkPkg/HttpDxe: " Jiaxin Wu
@ 2017-07-26  2:05 ` Fu, Siyuan
  2 siblings, 0 replies; 4+ messages in thread
From: Fu, Siyuan @ 2017-07-26  2:05 UTC (permalink / raw)
  To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>


-----Original Message-----
From: Wu, Jiaxin 
Sent: Tuesday, July 25, 2017 8:42 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch 0/2] Refine the coding style.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  MdePkg/Http.h: Refine the coding style.
  NetworkPkg/HttpDxe: Refine the coding style.

 MdePkg/Include/Protocol/Http.h | 8 ++++----
 NetworkPkg/HttpDxe/HttpImpl.c  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
1.9.5.msysgit.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-26  2:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 12:41 [Patch 0/2] Refine the coding style Jiaxin Wu
2017-07-25 12:41 ` [Patch 1/2] MdePkg/Http.h: " Jiaxin Wu
2017-07-25 12:41 ` [Patch 2/2] NetworkPkg/HttpDxe: " Jiaxin Wu
2017-07-26  2:05 ` [Patch 0/2] " Fu, Siyuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox