public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Cc: chenbo@pdx.edu, Liming Gao <liming.gao@intel.com>
Subject: [Patch 2/6] BaseTools/GenSec: Fix a segmentation fault in main()
Date: Thu, 27 Jul 2017 09:42:28 +0800	[thread overview]
Message-ID: <1501119752-3856-3-git-send-email-yonghong.zhu@intel.com> (raw)
In-Reply-To: <1501119752-3856-1-git-send-email-yonghong.zhu@intel.com>

Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=537
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/C/GenSec/GenSec.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/C/GenSec/GenSec.c b/BaseTools/Source/C/GenSec/GenSec.c
index 9129b50..c0e4de2 100644
--- a/BaseTools/Source/C/GenSec/GenSec.c
+++ b/BaseTools/Source/C/GenSec/GenSec.c
@@ -1,9 +1,9 @@
 /** @file
 Creates output file that is a properly formed section per the PI spec.
 
-Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials                          
 are licensed and made available under the terms and conditions of the BSD License         
 which accompanies this distribution.  The full text of the license may be found at        
 http://opensource.org/licenses/bsd-license.php                                            
                                                                                           
@@ -144,11 +144,11 @@ Returns:
   fprintf (stdout, "\nUsage: %s [options] [input_file]\n\n", UTILITY_NAME);
   
   //
   // Copyright declaration
   // 
-  fprintf (stdout, "Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.\n\n");
+  fprintf (stdout, "Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.\n\n");
 
   //
   // Details Option
   //
   fprintf (stdout, "Options:\n");
@@ -1118,10 +1118,14 @@ Returns:
       argv += 2;
       continue;
     }
 
     if ((stricmp (argv[0], "-r") == 0) || (stricmp (argv[0], "--attributes") == 0)) {
+      if (argv[1] == NULL) {
+        Error (NULL, 0, 1003, "Invalid option value", "Guid section attributes can't be NULL");
+        goto Finish;
+      }
       if (stricmp (argv[1], mGUIDedSectionAttribue[EFI_GUIDED_SECTION_PROCESSING_REQUIRED]) == 0) {
         SectGuidAttribute |= EFI_GUIDED_SECTION_PROCESSING_REQUIRED;
       } else if (stricmp (argv[1], mGUIDedSectionAttribue[EFI_GUIDED_SECTION_AUTH_STATUS_VALID]) == 0) {
         SectGuidAttribute |= EFI_GUIDED_SECTION_AUTH_STATUS_VALID;
       } else if (stricmp (argv[1], mGUIDedSectionAttribue[0]) == 0) {
-- 
2.6.1.windows.1



  parent reply	other threads:[~2017-07-27  1:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27  1:42 [Patch 0/6] BaseTools: Fix some segmentation fault in Tools Yonghong Zhu
2017-07-27  1:42 ` [Patch 1/6] BaseTools/Split: Fix the segmentation fault in GetSplitValue() Yonghong Zhu
2017-07-27  1:42 ` Yonghong Zhu [this message]
2017-07-27  1:42 ` [Patch 3/6] BaseTools/GenFfs: Fix a segmentation fault from vsprintf()/vfprintf() Yonghong Zhu
2017-07-27  1:42 ` [Patch 4/6] BaseTools/EfiRom: " Yonghong Zhu
2017-07-27  1:42 ` [Patch 5/6] BaseTools/EfiLdrImage: Fix a segmentation fault from vfprintf() Yonghong Zhu
2017-07-27  1:42 ` [Patch 6/6] BaseTools/GenCrc32: Fix a bug to hand empty file for decode Yonghong Zhu
2017-08-01  2:41 ` [Patch 0/6] BaseTools: Fix some segmentation fault in Tools Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501119752-3856-3-git-send-email-yonghong.zhu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox