public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Star Zeng <star.zeng@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Eric Dong <eric.dong@intel.com>
Subject: Re: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg
Date: Wed, 29 Nov 2017 13:34:41 +0100	[thread overview]
Message-ID: <1501eff1-861e-9683-acd7-82b3e0266b0d@redhat.com> (raw)
In-Reply-To: <1511931533-16456-1-git-send-email-star.zeng@intel.com>

On 11/29/17 05:58, Star Zeng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540
> 
> To consume FIT table for Microcode update,
> UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe
> needs to be updated to consume
> IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h,
> but UefiCpuPkg could not depend on IntelSiliconPkg.
> 
> Since the Microcode update feature is specific to Intel,
> we can first move the Microcode update feature code from
> UefiCpuPkg to IntelSiliconPkg [first step], then update
> the code to consume FIT table [second step].
> 
> This patch series is for the first step.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Regression-tested-by: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> 
> Star Zeng (2):
>   IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg
>   IntelSiliconPkg: Update MicrocodeUpdate to build with the package
> 
>  .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c  |  0
>  .../MicrocodeFlashAccessLibNull.inf                            |  6 +++---
>  .../MicrocodeFlashAccessLibNull.uni                            |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc        |  0
>  .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md              |  0
>  .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc        |  0
>  .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf        |  0
>  .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md              |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c          |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h       |  0
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf  |  3 ++-
>  .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni  |  0
>  .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni     |  0
>  {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h    |  0
>  .../Include/Library/MicrocodeFlashAccessLib.h                  |  0
>  IntelSiliconPkg/IntelSiliconPkg.dec                            | 10 +++++++++-
>  IntelSiliconPkg/IntelSiliconPkg.dsc                            |  2 ++
>  UefiCpuPkg/UefiCpuPkg.dec                                      |  7 -------
>  UefiCpuPkg/UefiCpuPkg.dsc                                      |  2 --
>  22 files changed, 16 insertions(+), 14 deletions(-)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (85%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (91%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%)
>  rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%)
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo


  parent reply	other threads:[~2017-11-29 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  4:58 [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Star Zeng
2017-11-29  4:58 ` [PATCH 1/2] IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg Star Zeng
2017-11-29  4:58 ` [PATCH 2/2] IntelSiliconPkg: Update MicrocodeUpdate to build with the package Star Zeng
2017-11-29  6:52 ` [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg Yao, Jiewen
2017-11-29 12:34 ` Laszlo Ersek [this message]
2017-11-29 12:41 ` Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501eff1-861e-9683-acd7-82b3e0266b0d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox