From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 86F1721A04E2F for ; Wed, 29 Nov 2017 04:30:19 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92958796E5; Wed, 29 Nov 2017 12:34:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-48.rdu2.redhat.com [10.10.120.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FC0B5D987; Wed, 29 Nov 2017 12:34:41 +0000 (UTC) To: Star Zeng , edk2-devel@lists.01.org Cc: Michael D Kinney , Jiewen Yao , Eric Dong References: <1511931533-16456-1-git-send-email-star.zeng@intel.com> From: Laszlo Ersek Message-ID: <1501eff1-861e-9683-acd7-82b3e0266b0d@redhat.com> Date: Wed, 29 Nov 2017 13:34:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511931533-16456-1-git-send-email-star.zeng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 29 Nov 2017 12:34:43 +0000 (UTC) Subject: Re: [PATCH 0/2] Move MicrocodeUpdate from UefiCpuPkg to IntelSiliconPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 12:30:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/29/17 05:58, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=540 > > To consume FIT table for Microcode update, > UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe > needs to be updated to consume > IntelSiliconPkg/Include/IndustryStandard/FirmwareInterfaceTable.h, > but UefiCpuPkg could not depend on IntelSiliconPkg. > > Since the Microcode update feature is specific to Intel, > we can first move the Microcode update feature code from > UefiCpuPkg to IntelSiliconPkg [first step], then update > the code to consume FIT table [second step]. > > This patch series is for the first step. > > Cc: Jiewen Yao > Cc: Michael D Kinney > Cc: Eric Dong > Cc: Laszlo Ersek > Regression-tested-by: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > > Star Zeng (2): > IntelSiliconPkg: Move MicrocodeUpdate from UefiCpuPkg > IntelSiliconPkg: Update MicrocodeUpdate to build with the package > > .../MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c | 0 > .../MicrocodeFlashAccessLibNull.inf | 6 +++--- > .../MicrocodeFlashAccessLibNull.uni | 0 > .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc | 0 > .../Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf | 0 > .../Feature/Capsule/MicrocodeCapsulePdb/Readme.md | 0 > .../Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf | 0 > .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc | 0 > .../Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf | 0 > .../Feature/Capsule/MicrocodeCapsuleTxt/Readme.md | 0 > .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c | 0 > .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c | 0 > .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h | 0 > .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf | 3 ++- > .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni | 0 > .../Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni | 0 > {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h | 0 > .../Include/Library/MicrocodeFlashAccessLib.h | 0 > IntelSiliconPkg/IntelSiliconPkg.dec | 10 +++++++++- > IntelSiliconPkg/IntelSiliconPkg.dsc | 2 ++ > UefiCpuPkg/UefiCpuPkg.dec | 7 ------- > UefiCpuPkg/UefiCpuPkg.dsc | 2 -- > 22 files changed, 16 insertions(+), 14 deletions(-) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf (85%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.uni (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.fdf (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsulePdb/Readme.md (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Microcode/Microcode.inf (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.fdf (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeCapsuleTxt/Readme.md (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.h (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf (91%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.uni (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxeExtra.uni (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Include/Guid/MicrocodeFmp.h (100%) > rename {UefiCpuPkg => IntelSiliconPkg}/Include/Library/MicrocodeFlashAccessLib.h (100%) > Acked-by: Laszlo Ersek Thanks Laszlo