From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49E0B21AEB0A3 for ; Thu, 10 Aug 2017 11:34:30 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 10 Aug 2017 11:36:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,354,1498546800"; d="scan'208";a="888652669" Received: from dtmedina-mobl.amr.corp.intel.com (HELO localhost) ([10.254.186.35]) by FMSMGA003.fm.intel.com with ESMTP; 10 Aug 2017 11:36:47 -0700 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel@lists.01.org Message-ID: <150239020750.4777.16972339809591983854@jljusten-skl> From: Jordan Justen In-Reply-To: References: <1501776600-16369-1-git-send-email-brijesh.singh@amd.com> <1501776600-16369-2-git-send-email-brijesh.singh@amd.com> <2517ecce-c92c-b85c-39a7-f454048e6b3d@redhat.com> <2b7e7cfb-0006-9dc2-951f-2d1f7d1a3214@redhat.com> <150186651004.27627.8056916076752739657@jljusten-skl> User-Agent: alot/0.5.1 Date: Thu, 10 Aug 2017 11:36:47 -0700 Subject: Re: [PATCH v2 1/1] OvmfPkg : QemuFwCfgLib: Use BusMasterCommandBuffer to map FW_CFG_DMA_ACCESS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 18:34:30 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-08-04 13:25:09, Laszlo Ersek wrote: > > = > > I have another reason why going beyond 80 is not a good idea for code > > that doesn't apply to normal reading. If you need ~120 columns visible > > to view some lines, then most lines will end up having a lot of wasted > > horizontal whitespace because they can commonly fit into 80 columns. > = > One reason I dislike the "all arguments on separate lines" rule is just > this -- it wastes perfectly good horizontal space, and eats up precious > vertical space. > = > We have a patch submission process for our documents now, I think I agree about the multiple args/multiple lines issue. I guess you could try to submit a code style doc change, but I'm not sure how controversial it might be. > but I don't > think maintainers of other Pkgs would bother with following and > enforcing a stricter 80 columns rule, even if we got it codified. :/ I still think we should have it written stricter even if it isn't always followed. It could be a step in the right direction. -Jordan