From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Rohit Mathew <rohit.mathew@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase
Date: Thu, 21 Jul 2022 09:26:38 -0700 [thread overview]
Message-ID: <15026.1658420798225177209@groups.io> (raw)
In-Reply-To: <20220706134234.17847-1-rohit.mathew@arm.com>
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
Hi Rohit,
On Wed, Jul 6, 2022 at 06:42 AM, Rohit Mathew wrote:
>
> =20
> @@ -86,6 +86,10 @@ CEntryPoint (
> ArmEnableVFP ();
> }
> =20
> + // Explicitly invoke the library constructor to resolve any library
> + // dependency.
> + ProcessLibraryConstructorList();
> +
I missed this in my previous feedback, but ProcessLibraryConstructorList() should only be called by the Primary core.
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 494 bytes --]
next prev parent reply other threads:[~2022-07-21 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 13:42 [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase Rohit Mathew
2022-07-06 14:20 ` Thomas Abraham
2022-07-18 18:11 ` [edk2-devel] " Rohit Mathew
2022-07-21 15:54 ` Sami Mujawar
2022-07-22 17:08 ` [edk2-devel] " Rohit Mathew
2022-07-21 16:26 ` Sami Mujawar [this message]
2022-07-22 17:12 ` Rohit Mathew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15026.1658420798225177209@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox