public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Eric Dong <eric.dong@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.
Date: Mon, 14 Aug 2017 15:22:53 +0800	[thread overview]
Message-ID: <1502695374-11368-2-git-send-email-eric.dong@intel.com> (raw)
In-Reply-To: <1502695374-11368-1-git-send-email-eric.dong@intel.com>

Add valid/default values for PCD PcdCpuProcTraceMemSize and
PcdCpuProcTraceOutputScheme in the comment part.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.dec | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
index 2ddeab4..b4e099d 100644
--- a/UefiCpuPkg/UefiCpuPkg.dec
+++ b/UefiCpuPkg/UefiCpuPkg.dec
@@ -285,12 +285,36 @@
   # @ValidList   0x80000001 | 0
   gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019
 
-  ## Contains the size of memory required when CPU processor trace is enabled.
+  ## Contains the size of memory required when CPU processor trace is enabled.<BR><BR>
+  #  Default value is 0x10 which disables the processor trace.<BR>
+  #  0x0  -  4K.<BR>
+  #  0x1  -  8K.<BR>
+  #  0x2  -  16K.<BR>
+  #  0x3  -  32K.<BR>
+  #  0x4  -  64K.<BR>
+  #  0x5  -  128K.<BR>
+  #  0x6  -  256K.<BR>
+  #  0x7  -  512K.<BR>
+  #  0x8  -  1M.<BR>
+  #  0x9  -  2M.<BR>
+  #  0xA  -  4M.<BR>
+  #  0xB  -  8M.<BR>
+  #  0xC  -  16M.<BR>
+  #  0xD  -  32M.<BR>
+  #  0xE  -  64M.<BR>
+  #  0xF  -  128M.<BR>
+  #  0x10 -  ProcTraceMemDisable.<BR>
   # @Prompt The memory size used for processor trace.
+  # @ValidRange  0x80000001 | 0 - 0x10
   gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x60000012
 
-  ## Contains the processor trace output scheme when CPU processor trace is enabled.
+  ## Contains the processor trace output scheme when CPU processor trace is enabled.<BR><BR>
+  #  Default value is 2 which disables the processor trace.<BR>
+  #  0 - Single Range output scheme.<BR>
+  #  1 - ToPA(Table of physical address) scheme.<BR>
+  #  2 - Invalid scheme.<BR>
   # @Prompt The processor trace output scheme.
+  # @ValidRange  0x80000001 | 0 - 2
   gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8|0x60000015
 
 [UserExtensions.TianoCore."ExtraFiles"]
-- 
2.7.0.windows.1



  reply	other threads:[~2017-08-14  7:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14  7:22 [Patch 0/2] Add comments for two new added Pcds Eric Dong
2017-08-14  7:22 ` Eric Dong [this message]
2017-08-16 15:58   ` [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition Kinney, Michael D
2017-08-17  6:47     ` Dong, Eric
2017-08-17  7:55       ` Kinney, Michael D
2017-08-17  8:52         ` Dong, Eric
2017-08-17 17:39           ` Kinney, Michael D
     [not found]             ` <ED077930C258884BBCB450DB737E66224A9C366B@shsmsx102.ccr.corp.intel.com>
2017-08-22 22:30               ` Kinney, Michael D
2017-08-14  7:22 ` [Patch 2/2] UefiCpuPkg UefiCpupkg.uni: Add new pcds comments Eric Dong
2017-08-16  6:40 ` [Patch 0/2] Add comments for two new added Pcds Gao, Liming
  -- strict thread matches above, loose matches on Subject: below --
2017-08-09  6:32 [Patch 0/2] Add comments for new Pcds Eric Dong
2017-08-09  6:32 ` [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition Eric Dong
2017-08-09 23:08   ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502695374-11368-2-git-send-email-eric.dong@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox