From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 52EEF21D2DD0F for ; Mon, 14 Aug 2017 00:20:53 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2017 00:23:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,372,1498546800"; d="scan'208";a="1003305322" Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.51]) by orsmga003.jf.intel.com with ESMTP; 14 Aug 2017 00:22:57 -0700 From: Eric Dong To: edk2-devel@lists.01.org Cc: Liming Gao , Ruiyu Ni , Michael D Kinney Date: Mon, 14 Aug 2017 15:22:53 +0800 Message-Id: <1502695374-11368-2-git-send-email-eric.dong@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 In-Reply-To: <1502695374-11368-1-git-send-email-eric.dong@intel.com> References: <1502695374-11368-1-git-send-email-eric.dong@intel.com> Subject: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 07:20:53 -0000 Add valid/default values for PCD PcdCpuProcTraceMemSize and PcdCpuProcTraceOutputScheme in the comment part. Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/UefiCpuPkg.dec | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index 2ddeab4..b4e099d 100644 --- a/UefiCpuPkg/UefiCpuPkg.dec +++ b/UefiCpuPkg/UefiCpuPkg.dec @@ -285,12 +285,36 @@ # @ValidList 0x80000001 | 0 gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 - ## Contains the size of memory required when CPU processor trace is enabled. + ## Contains the size of memory required when CPU processor trace is enabled.

+ # Default value is 0x10 which disables the processor trace.
+ # 0x0 - 4K.
+ # 0x1 - 8K.
+ # 0x2 - 16K.
+ # 0x3 - 32K.
+ # 0x4 - 64K.
+ # 0x5 - 128K.
+ # 0x6 - 256K.
+ # 0x7 - 512K.
+ # 0x8 - 1M.
+ # 0x9 - 2M.
+ # 0xA - 4M.
+ # 0xB - 8M.
+ # 0xC - 16M.
+ # 0xD - 32M.
+ # 0xE - 64M.
+ # 0xF - 128M.
+ # 0x10 - ProcTraceMemDisable.
# @Prompt The memory size used for processor trace. + # @ValidRange 0x80000001 | 0 - 0x10 gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x60000012 - ## Contains the processor trace output scheme when CPU processor trace is enabled. + ## Contains the processor trace output scheme when CPU processor trace is enabled.

+ # Default value is 2 which disables the processor trace.
+ # 0 - Single Range output scheme.
+ # 1 - ToPA(Table of physical address) scheme.
+ # 2 - Invalid scheme.
# @Prompt The processor trace output scheme. + # @ValidRange 0x80000001 | 0 - 2 gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8|0x60000015 [UserExtensions.TianoCore."ExtraFiles"] -- 2.7.0.windows.1