From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 74B2421DFC878 for ; Mon, 14 Aug 2017 22:29:18 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2017 22:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,376,1498546800"; d="scan'208";a="137503228" Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.51]) by orsmga005.jf.intel.com with ESMTP; 14 Aug 2017 22:31:41 -0700 From: Eric Dong To: edk2-devel@lists.01.org Cc: Ruiyu Ni , Shao, Ming Date: Tue, 15 Aug 2017 13:31:37 +0800 Message-Id: <1502775098-14688-2-git-send-email-eric.dong@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 In-Reply-To: <1502775098-14688-1-git-send-email-eric.dong@intel.com> References: <1502775098-14688-1-git-send-email-eric.dong@intel.com> Subject: [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 05:29:18 -0000 Current code allocate buffer for the pointer which later get value from PCD database. but current code error use "=" for this case. Use CopyMem instead to fix it. Cc: Ruiyu Ni Cc: Shao, Ming Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 474aea3..77834ae 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -66,7 +66,7 @@ GetSupportPcds ( BitMaskSize = PcdGetSize (PcdCpuFeaturesSupport); SupportBitMask = AllocateZeroPool (BitMaskSize); ASSERT (SupportBitMask != NULL); - SupportBitMask = (UINT8 *) PcdGetPtr (PcdCpuFeaturesSupport); + CopyMem (SupportBitMask, (UINT8 *) PcdGetPtr (PcdCpuFeaturesSupport), BitMaskSize); return SupportBitMask; } @@ -87,7 +87,7 @@ GetConfigurationPcds ( BitMaskSize = PcdGetSize (PcdCpuFeaturesUserConfiguration); SupportBitMask = AllocateZeroPool (BitMaskSize); ASSERT (SupportBitMask != NULL); - SupportBitMask = (UINT8 *) PcdGetPtr (PcdCpuFeaturesUserConfiguration); + CopyMem (SupportBitMask, (UINT8 *) PcdGetPtr (PcdCpuFeaturesUserConfiguration), BitMaskSize); return SupportBitMask; } -- 2.7.0.windows.1