From: Jordan Justen <jordan.l.justen@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"
Date: Fri, 25 Aug 2017 08:42:39 -0700 [thread overview]
Message-ID: <150367575953.19279.11202446826605718459@jljusten-skl> (raw)
In-Reply-To: <20170825093454.27667-1-lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2017-08-25 02:34:54, Laszlo Ersek wrote:
> This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
>
> TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
> been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
> option in GCC tool chain", 2017-08-23), so we can return to the GCC5
> toolchain with gcc-7.*.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 5868d3b8c498..682155202564 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -102,7 +102,7 @@ case `uname` in
> 4.8.*)
> TARGET_TOOLS=GCC48
> ;;
> - 4.9.*|6.[0-2].*|7.*)
> + 4.9.*|6.[0-2].*)
> TARGET_TOOLS=GCC49
> ;;
> *)
> --
> 2.14.1.3.gb7cf6e02401b
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-08-25 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 9:34 [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*" Laszlo Ersek
2017-08-25 15:42 ` Jordan Justen [this message]
2017-08-25 17:23 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150367575953.19279.11202446826605718459@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox