* [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"
@ 2017-08-25 9:34 Laszlo Ersek
2017-08-25 15:42 ` Jordan Justen
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2017-08-25 9:34 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Jordan Justen
This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
option in GCC tool chain", 2017-08-23), so we can return to the GCC5
toolchain with gcc-7.*.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 5868d3b8c498..682155202564 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -102,7 +102,7 @@ case `uname` in
4.8.*)
TARGET_TOOLS=GCC48
;;
- 4.9.*|6.[0-2].*|7.*)
+ 4.9.*|6.[0-2].*)
TARGET_TOOLS=GCC49
;;
*)
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"
2017-08-25 9:34 [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*" Laszlo Ersek
@ 2017-08-25 15:42 ` Jordan Justen
2017-08-25 17:23 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Jordan Justen @ 2017-08-25 15:42 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2017-08-25 02:34:54, Laszlo Ersek wrote:
> This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
>
> TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
> been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
> option in GCC tool chain", 2017-08-23), so we can return to the GCC5
> toolchain with gcc-7.*.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 5868d3b8c498..682155202564 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -102,7 +102,7 @@ case `uname` in
> 4.8.*)
> TARGET_TOOLS=GCC48
> ;;
> - 4.9.*|6.[0-2].*|7.*)
> + 4.9.*|6.[0-2].*)
> TARGET_TOOLS=GCC49
> ;;
> *)
> --
> 2.14.1.3.gb7cf6e02401b
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"
2017-08-25 15:42 ` Jordan Justen
@ 2017-08-25 17:23 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2017-08-25 17:23 UTC (permalink / raw)
To: Jordan Justen, edk2-devel-01
On 08/25/17 17:42, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Thank you, pushed as commit 656ac0c7d8ea.
Laszlo
> On 2017-08-25 02:34:54, Laszlo Ersek wrote:
>> This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
>>
>> TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
>> been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
>> option in GCC tool chain", 2017-08-23), so we can return to the GCC5
>> toolchain with gcc-7.*.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> OvmfPkg/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 5868d3b8c498..682155202564 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -102,7 +102,7 @@ case `uname` in
>> 4.8.*)
>> TARGET_TOOLS=GCC48
>> ;;
>> - 4.9.*|6.[0-2].*|7.*)
>> + 4.9.*|6.[0-2].*)
>> TARGET_TOOLS=GCC49
>> ;;
>> *)
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-25 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-25 9:34 [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*" Laszlo Ersek
2017-08-25 15:42 ` Jordan Justen
2017-08-25 17:23 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox