* [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
@ 2017-09-01 0:50 Jiaxin Wu
2017-09-01 1:02 ` Fu, Siyuan
0 siblings, 1 reply; 2+ messages in thread
From: Jiaxin Wu @ 2017-09-01 0:50 UTC (permalink / raw)
To: edk2-devel; +Cc: Ye Ting, Fu Siyuan, Wu Jiaxin
When creating the ISCSI string OpCode for IP_ADDRESS, the max length
should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index e20fe91..efd05cf 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -1007,11 +1007,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorNetmask Keyword.
@@ -1033,11 +1033,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorGateway Keyword.
@@ -1059,11 +1059,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSITargetInfoViaDHCP Keyword.
@@ -1165,11 +1165,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP_MIN_SIZE,
- IP_MAX_SIZE,
+ IP_STR_MAX_SIZE,
NULL
);
//
// Create iSCSILUN Keyword.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
2017-09-01 0:50 [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS Jiaxin Wu
@ 2017-09-01 1:02 ` Fu, Siyuan
0 siblings, 0 replies; 2+ messages in thread
From: Fu, Siyuan @ 2017-09-01 1:02 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Wu, Jiaxin
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, September 1, 2017 8:51 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
When creating the ISCSI string OpCode for IP_ADDRESS, the max length
should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE.
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index e20fe91..efd05cf 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -1007,11 +1007,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorNetmask Keyword.
@@ -1033,11 +1033,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSIInitiatorGateway Keyword.
@@ -1059,11 +1059,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP4_MIN_SIZE,
- IP4_MAX_SIZE,
+ IP4_STR_MAX_SIZE,
NULL
);
//
// Create iSCSITargetInfoViaDHCP Keyword.
@@ -1165,11 +1165,11 @@ IScsiCreateKeywords (
StringToken,
StringToken,
0,
0,
IP_MIN_SIZE,
- IP_MAX_SIZE,
+ IP_STR_MAX_SIZE,
NULL
);
//
// Create iSCSILUN Keyword.
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-01 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 0:50 [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS Jiaxin Wu
2017-09-01 1:02 ` Fu, Siyuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox